From: Shuah Khan <skhan@linuxfoundation.org>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>,
shuah@kernel.org, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] selftest/vm clarify error statement in gup_test
Date: Wed, 6 Apr 2022 13:35:25 -0600 [thread overview]
Message-ID: <c0ba950a-9210-1a73-dc6b-6655fcda9878@linuxfoundation.org> (raw)
In-Reply-To: <20220405214809.3351223-1-sidhartha.kumar@oracle.com>
On 4/5/22 3:48 PM, Sidhartha Kumar wrote:
> Print three possible reasons /sys/kernel/debug/gup_test
> cannot be opened to help users of this test diagnose
> failures.
>
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
> v2:
> - Add support for skipping the test due to unmet dependencies.
> - Use errno to print a more specific message.
> - Add check for root privileges.
> - dropped CC to stable.
> tools/testing/selftests/vm/gup_test.c | 22 +++++++++++++--
> tools/testing/selftests/vm/run_vmtests.sh | 33 ++++++++++++++++-------
> 2 files changed, 44 insertions(+), 11 deletions(-)
>
Thank you for fixing the reporting and adding tests for dependencies
and skip conditions.
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
prev parent reply other threads:[~2022-04-06 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 21:48 Sidhartha Kumar
2022-04-05 22:33 ` Matthew Wilcox
2022-04-06 19:38 ` Shuah Khan
2022-04-06 19:35 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0ba950a-9210-1a73-dc6b-6655fcda9878@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=sidhartha.kumar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox