From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79A1EC4332F for ; Wed, 13 Dec 2023 14:00:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 124FE6B04C8; Wed, 13 Dec 2023 09:00:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D5BE6B04C9; Wed, 13 Dec 2023 09:00:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB76F6B04CA; Wed, 13 Dec 2023 09:00:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D550A6B04C8 for ; Wed, 13 Dec 2023 09:00:46 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id ABE83120B38 for ; Wed, 13 Dec 2023 14:00:46 +0000 (UTC) X-FDA: 81561955692.22.B90A5A8 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf09.hostedemail.com (Postfix) with ESMTP id A4D0314000A for ; Wed, 13 Dec 2023 14:00:43 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="MaBOz/47"; spf=pass (imf09.hostedemail.com: domain of broonie@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702476043; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vOw8d+JXilPrP9AP5/jrg3IJrQx+xZsvEaX+/R4+fc8=; b=Pk4GGnIzDVOsoQtAQYfyG5mfgN4v+iseHMXesBJPEf34lhMHnJeL3fTrKFBO/Wx9TsYcwn fxGvuYzCkMkKLgrdcTfOG5t31fDkOX8J9ZmGw2RZTmX8XAWzKKZ/KAuZJB+sV5tCfxm8bC qv7pENU32FUfIWPz6N5qYsqNNgAhXVk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="MaBOz/47"; spf=pass (imf09.hostedemail.com: domain of broonie@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702476043; a=rsa-sha256; cv=none; b=H/Zj12UDr/9AiAzRY4NYBOpbf4KtpKkOxemBslh/rb5N7sG8u6SksL+viVGi8uTh2BJSv5 oWaOCfDUkAcCHeYkLqFh0xsbkQkNWJAXjif29w2rU9QMinWsMqhADKR0AyUJk/+LL9X0/M hhVudbHwEglaJMSQlgZf0ud+s/UNVyI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id A48D3B81D95; Wed, 13 Dec 2023 14:00:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C1A6C433C7; Wed, 13 Dec 2023 14:00:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702476041; bh=uBRmDLreG8WgwNQkvzLPBqQqss2T/ZofeYOVFa+eznA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MaBOz/47yY6VrRxrv3KKFtukVEZ+DALugU+umNCVqzDhVU9TRoPPiFIp6ki7L9H85 +SSElnIH3cjgLrJjtr+W8i5TGHkloO1SPoxHDMtPwN7rgnMdsPs8Je95lVTgYqohyR JqrZYSFXbJEp38k/t+mh2g0yhf4bcVTVKhzt8BhWXEmA+Dp95HZqRoBeVDRrQFdJer vaqixHfU41igB/RuHZQCeqqD00PejJoOR9FbU1fUo6TJxgJ11TH6I5zO5bFGZAsJNH DIhMhseUcZXSIwpFgmoLPWal2mkolYNmSACLQw+G+Y6KkL40k6cbvAwEE3B3ToU/m3 +VG3sMai75JfA== Date: Wed, 13 Dec 2023 14:00:32 +0000 From: Mark Brown To: Muhammad Usama Anjum Cc: John Hubbard , David Hildenbrand , Suren Baghdasaryan , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, peterx@redhat.com, ryan.roberts@arm.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, Peter Zijlstra Subject: Re: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test Message-ID: References: <50385948-5eb4-47ea-87f8-add4265933d6@redhat.com> <6a34b0c9-e084-4928-b239-7af01c8d4479@sirena.org.uk> <3240f4b5-081b-4075-851a-7d1cd86f4333@redhat.com> <3eadd79c-c02a-495f-92c0-0315046ef59f@nvidia.com> <3d22f342-280f-4a44-87f4-8cca291cfce7@sirena.org.uk> <0f97db9c-5b86-4f56-8463-2520fe79f709@sirena.org.uk> <2e4a719b-f2b3-48db-99db-d96040d78b12@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/XZEbL4J1kAPYGOF" Content-Disposition: inline In-Reply-To: <2e4a719b-f2b3-48db-99db-d96040d78b12@collabora.com> X-Cookie: One size fits all. X-Rspamd-Queue-Id: A4D0314000A X-Rspam-User: X-Stat-Signature: xyoyby6uyaahbxh5wfe7kt4qqjgny4kr X-Rspamd-Server: rspam01 X-HE-Tag: 1702476043-167829 X-HE-Meta: U2FsdGVkX1+m13BHY6+9cTwZ9MBenc3vYjPUNMq2yGX9qlvsKtBZStDpEGpimHUxEis7tfNdkE27JJX8A2pvhwjXmH6VaBym8VqJsCh8cRNcJIcKv5JiWxQkfBO7hkYYUUZJCt3rQT5Fqz+mk93WZ6FIpibnTEU5pPe/zvqf89APXHsdAs10haM1vIIqomwAb5boUwIKl+BXP+r8ZdzgMFs14UlrvEfAMFMZI8OB/dsF4GOgTOBdx7bVcpg52mXSJU6ZmshEN31UZyoAbCkQiZd1MCx/tD8UwITjGNLV7I+7aAoSYgbLuvXr12jNUa8QRyWnopbeLHPbgOe/v6frs2JDeRF9F0MxuJkl6IcGjhVYp53w5qzIR1iBujNSuSWtMNSFrv6gJ51c+OtcphqcskulLE8ZvGvu6fGihRU6xzSjQB62cuKjtwQnupz926rWtT9Buz3M+zOC8PSExdqcb0mGJblBu2cgaa+tD26QCpdITcTvzkrJLwOPEF9BbW4YxKieAEny4DEQu19Skql5wt3PQS6QhBgw3JhliDVhM5dajEthtZU+cmCSCkgAOVBOv4hPZ7BGz8lSy/kga6VDssxpuYWM9aQf+P2wERg/VkvOItOmH/THBDevvLQj0SoKdBm5yrjQCxs0+qkXsRInZtOn78834ByJMR/OFK4UOmyJ8FCVUQ3Esn4xIFlEBocm+CAUF22ItIPxWRZ51M0KtuLF6MhMISpTWoSqa/AMY59JTi5b0Ibv14fGmeHZy0eQWi57IYrXEYs8qIgxdc7AbkuXPWxYx2TQYuyIKFHfp330mr1bMKrpAVYxjdJ1GKyyWIwoFJFCRRo/VdKWukh67DW+G6f36y6QQDiayNBp2Y1ZRBZSXjZXOtQFIAQsGRYJChB7zONWDOubJk2ii5qaoDhU2x6sp4KgxBFSCyiclkQfb05JfE9BPjycHWOs+ebUdyHx085aU1bjxTwv26j CGSaIktg MJXg+AAvERJlwd4t8d7sXEY9yMi2waaK9fRBRyntDTwnpLXwBbXgz3mEZDlgxCnRqsnoBFbYx5oIF0PPDEtB2DOjnm4hOh26su0juiXNpev2UdcXTTEvhYc/xsQNo973UqOcT6G+OPZaiyvUUjlmFag3ZTSe0nmS1m0vFj3Jbkj9jEKYtX9yXbl/il+Bf5q02m6W2gMWoQ6H2a3vfVrSiOv3HNGQnOtKt0mLh733iFKzyoTxSFrDCkexk5VAKZS2jesTY7Yx119N67qcwsDU6TavUbya1JlBIRvxfz86q8fgJzEM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --/XZEbL4J1kAPYGOF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 13, 2023 at 08:58:06AM +0500, Muhammad Usama Anjum wrote: > On 12/13/23 7:14 AM, John Hubbard wrote: > > Oh, this sounds like it would work nicely. No more "make headers" > > required (hooray!). Instead, the new approach would be "selftests are > > allowed to include from tools/include", and then we can just start > > copying the files that we need to that location, and gradually fix up > > all the selftests. > No, this wouldn't work. Note that we have a bunch of selftests (at least arm64, hid, kvm, rseq and sgx from a quick grep) which already use and rely on the headers in tools/include. > * The selftests are applications which include default header files. The > application don't care from where the header files are picked up at compile > time. We should be able to build the application on normal system with > latest headers installed without any changes. I think there is much less interest in building out of the kernel than there is in avoiding having to handle random userspace headers... > * The header files cannot be included directly as they need to be processed > first which is done by `make headers`. Here is a diff between kernel fs.h > and processed header file to be used by applications: I guess that's another reason why the sync is done manually. There are also a bunch of files in tools/include that are just completely different implementations of things (not just uapi). --/XZEbL4J1kAPYGOF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmV5uP8ACgkQJNaLcl1U h9B4Agf+MNb0FxSD5g83dGXjn3wfAIHYImULMzBSAyVwk+xbUBcF5RwuyI/Up6pe jF7sirB8JObQgIDvOntBvbLGxjnrbKVZmrnnrz3IZLy9coVcvydGocN2dgTK/U63 0n4vbXdOYqavpATUodi9QyrB+1peaITg+DvOBR95uoORBc94VM7bXVxGgD61oZ0N ZElj6Uuiegt+pu4yzSnCsNrXvvIUk1y1jl59tH1NV+WAnoHsDkNJReua3pUtYU3c MUyU+EkGOUI256iUVCafNaBqkbWvy070pa/QToV9OI+js6AF5//Yj0LR1LtZprjq q371z9Rj+1s+jACuAtuq8ELOJrN3QQ== =PCP4 -----END PGP SIGNATURE----- --/XZEbL4J1kAPYGOF--