From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB7A8C38145 for ; Thu, 8 Sep 2022 01:43:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DC4B6B0072; Wed, 7 Sep 2022 21:43:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4650B6B0073; Wed, 7 Sep 2022 21:43:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32C018D0001; Wed, 7 Sep 2022 21:43:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 206A86B0072 for ; Wed, 7 Sep 2022 21:43:58 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E7706A0494 for ; Thu, 8 Sep 2022 01:43:57 +0000 (UTC) X-FDA: 79887222114.13.A05C406 Received: from out30-43.freemail.mail.aliyun.com (out30-43.freemail.mail.aliyun.com [115.124.30.43]) by imf04.hostedemail.com (Postfix) with ESMTP id 65E1340079 for ; Thu, 8 Sep 2022 01:43:56 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R221e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=xhao@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0VP.zpTy_1662601430; Received: from 30.240.97.117(mailfrom:xhao@linux.alibaba.com fp:SMTPD_---0VP.zpTy_1662601430) by smtp.aliyun-inc.com; Thu, 08 Sep 2022 09:43:52 +0800 Message-ID: Date: Thu, 8 Sep 2022 09:43:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH] mm/damon: Remove duplicate get_monitoring_region() definitions To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220907205911.62483-1-sj@kernel.org> From: haoxin In-Reply-To: <20220907205911.62483-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662601437; a=rsa-sha256; cv=none; b=IBfkolFxUWsqqFTSYI7/CJOwK1XHVDvzknlCYKMgssBv0m2eGZgijCVqi+xT3u4U/2Fa78 NDm/ulXrq78JIuII3k+8N0BovIp7FA+4sohxNSJcxCBff8uFdofGCN8bK7x/v1KvagHjQs WGDfwleNe5NL9mCyGDtTgmprGdbB5L8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of xhao@linux.alibaba.com designates 115.124.30.43 as permitted sender) smtp.mailfrom=xhao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662601437; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p8NDzMUj2L04r2vPACFHxlnDZT1GV0FPFDn+hFd/PIc=; b=ovxAYJV6KgFiX8649RuwJcgPH/26SOE9dhPHHOlNqZ3AaY8tp6+Z6KYMh7xZjLSU99eAN5 AzfmgKhAGwCHCzqe2hzIA4v+ujxccXyok2cQK1JgfSWQgEfd7P0Mko2u/Lgh7O/K4TuH0/ erviLk4dkSvwBE3j18pRYTP+zPyLea8= X-Rspamd-Queue-Id: 65E1340079 Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of xhao@linux.alibaba.com designates 115.124.30.43 as permitted sender) smtp.mailfrom=xhao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: zxycs1n1xpa98i6kommpddbmmpa5yx9m X-HE-Tag: 1662601436-492261 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2022/9/8 上午4:59, SeongJae Park 写道: > On Wed, 7 Sep 2022 17:27:12 +0000 SeongJae Park wrote: > > [...] >>> diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c >>> index b1335de200e7..01938f33038d 100644 >>> --- a/mm/damon/ops-common.c >>> +++ b/mm/damon/ops-common.c >>> @@ -172,3 +172,31 @@ int damon_hot_score(struct damon_ctx *c, struct damon_region *r, >>> >>> return hotness; >>> } >>> + >>> +static inline int walk_system_ram(struct resource *res, void *arg) >>> +{ >>> + struct damon_addr_range *a = arg; >>> + >>> + if (a->end - a->start < resource_size(res)) { >>> + a->start = res->start; >>> + a->end = res->end; >>> + } >>> + return 0; >>> +} >>> + >>> +/* >>> + * Find biggest 'System RAM' resource and store its start and end address in >>> + * @start and @end, respectively. If no System RAM is found, returns false. >>> + */ >>> +bool get_monitoring_region(unsigned long *start, unsigned long *end) >>> +{ >>> + struct damon_addr_range arg = {}; >>> + >>> + walk_system_ram_res(0, ULONG_MAX, &arg, walk_system_ram); >>> + if (arg.end <= arg.start) >>> + return false; >>> + >>> + *start = arg.start; >>> + *end = arg.end; >>> + return true; >>> +} >> 'ops-common.c' is for code that common in monitoring operations >> implementations. I'd prefer to have yet another source file for the DAMON >> modules including reclaim and lru_sort, say, 'modules-common.c'. > Or, putting it in damon/core.c might make more sense. Ok,  i will fix them in my next patch, thanks. > > > Thanks, > SJ > > [...]