From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4862C4829A for ; Tue, 13 Feb 2024 19:46:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 712536B0096; Tue, 13 Feb 2024 14:46:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 69CEA6B0099; Tue, 13 Feb 2024 14:46:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 561E96B009B; Tue, 13 Feb 2024 14:46:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 461B36B0096 for ; Tue, 13 Feb 2024 14:46:09 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DD36C802D9 for ; Tue, 13 Feb 2024 19:46:08 +0000 (UTC) X-FDA: 81787811616.30.C06A1C7 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) by imf06.hostedemail.com (Postfix) with ESMTP id 2F2E818001C for ; Tue, 13 Feb 2024 19:46:06 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=FdhVOZwn; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf06.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707853567; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UNSsOHXwwYF6F5NmG9Is3Y+QRkHZnX9jcK1XI1d7oCg=; b=FyopfXrPKNIfXb4zG9FP/FhY8nR802WCKI11q5QzeUuLUnoVVO5l81kvpaURgXHf70t8E7 Ec82iaHY+dUhfU2Q46DSU10xfaU9WdcklG7tkiteOmT+LVUDKgUUZQwrE75FzH6yX8UnO9 VIa8lEmJ5kYZTHIhtZ3AV06DfI1k7uM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=FdhVOZwn; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf06.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707853567; a=rsa-sha256; cv=none; b=8VEBLbM/xpcv4zrgyThvkDfy2nk4REqfVWy2TN5tBJvi49nEyrZttLqNIK833lVyN2m9no 7iuSCBpb7GRVHBGvNWuo39TAlYChwEYJre2FHDKLXsxMcc13pocBpi8ztq8PRlOjK6N2TU udzMOGWHW+EZLLPO11oxUmzBCndUnCI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1707853565; bh=91fMcwc23t/9Ue36JL2amNbWqAs6AjesdadtoLuKu0M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FdhVOZwnEphOvwoVCm/OLjFElpH0U2cr0/fOq2wMSCpthaCO33T56W6XQ4mQiOUhe SX2qxP+8yLW9KYYxyqxWi2J5VQv5bfpYrsWxwzfnaWwWiEDDvXarA+Z3spkl8GOhfv gAZmKFyTk31OtlM/cGs+Z7j1P4Xl3jrfRgoxV6XSbAucQ1qdmLAqfJqL9h7n2igwRv /lv+D8Nm6bI+wjjfL4io04GN7Lo4fU8FOJ2Lo2uJXk2jSd5rRT+vE8/aZlO2nbuffk az9OgSu5jDtvYnxfk832jOr2vqOKLTK/ZQQ/Zqpmopd4D0XQTwtqTOtI41nj3XlSFR Sj1mzC+AAMlZQ== Received: from [172.16.0.134] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4TZBdn2yXnzYPf; Tue, 13 Feb 2024 14:46:05 -0500 (EST) Message-ID: Date: Tue, 13 Feb 2024 14:46:05 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 5/8] virtio: Treat alloc_dax() -EOPNOTSUPP failure as non-fatal Content-Language: en-US To: Lukas Wunner , Greg Kroah-Hartman Cc: Dan Williams , Arnd Bergmann , Dave Chinner , linux-kernel@vger.kernel.org, Andrew Morton , Linus Torvalds , Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, dm-devel@lists.linux.dev, nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Mikulas Patocka References: <20240212163101.19614-1-mathieu.desnoyers@efficios.com> <20240212163101.19614-6-mathieu.desnoyers@efficios.com> <20240213062559.GA27364@wunner.de> From: Mathieu Desnoyers In-Reply-To: <20240213062559.GA27364@wunner.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2F2E818001C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: bdjgjuayng585az81yjsyqyh54ha9gfq X-HE-Tag: 1707853566-70298 X-HE-Meta: U2FsdGVkX196FZ6mH/Y9Omu6JFkO++/lOVCd0hTOzPkUdurtc0jybvIdMkU5BwJJF/Jgo0skp/SiKVAUXGyEVlrAf1CflYLVQMXs4BDSM5TiBdDvkExeVyJNiXu/bu8Lp8Dyfl7wR7ppYdrLqbDwLrAlneudkfD7Oy+rajkfbfO0TQeZrdnjud4aqfaQq1ifsOShOvvQ849GvtH/DW+78Of7K1fMUKA3fl84anaasziTOB/C+Njw6lCjXH55by/U/cCPKqDSKm0rsBoc+e50SCZLBadgy+rXJx4C3EcnWpJiKkYcwHglsqi4Y8XeU0ZjDlcvVs61ZHxfkcCHh6gJuhWidYJeYxBnmd1WGj8tB8+IZ7wVgdmd8WxYLne37WsgBj12fLiYjElEh+F80IATE2sm6CF83/W6KxDSZcSYzjx9iUH0WCCj9PKXztMTc2S250rWk7v1vMFifdk/ChTkCUrMqwRsEKfKgxQu4eOoZObTymqgchesn6zT1jmgcW0ehj7jS56cN6xwdIbyLzk5pj5Lgdnd/pdsRfKOuGI12s7OmQ3OJAyOXk40pzIk/1QDVjB5aKUyUz0HOcBK7/b31gvs8vXW6ELFzFenB4BAcipH6/L/KMCsxNvzmb3xxfgU5rIu7g4JpF2mkRDuDnx3KSL4bRwej9ZkeLR42HuBJhaUF4fxFuJTgCAE0dCleT3o70zNEy7Wx2hgNx+gJ7Jmxj7sG9h+NE4qnrVTL3EfPAONYHgTSmR63ARP9zi4QZCSUcIy9DE5tBOD6stidGW2G4xDCt6Owl6kdRuN2u2Ik7dKJkWr/+4/rhv+FJ5bsqvY/Gk3y6UZxUh++/ns4shY5mxg47wJvhlW6r7eO9bjziBeOFJceB1mNKuZSCCieRaMmNUL25hr+ORMo1FlnatCjyXiNgBHVaY6N2lvKkGNvpZFN79KzmcFqT6jwoW5qKcllB+WU5uiF9F832Wcjtb uu/BYh0y KxG9CLalJuyM9LfQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-02-13 01:25, Lukas Wunner wrote: > On Mon, Feb 12, 2024 at 11:30:58AM -0500, Mathieu Desnoyers wrote: >> In preparation for checking whether the architecture has data cache >> aliasing within alloc_dax(), modify the error handling of virtio >> virtio_fs_setup_dax() to treat alloc_dax() -EOPNOTSUPP failure as >> non-fatal. >> >> Co-developed-by: Dan Williams >> Signed-off-by: Dan Williams >> Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches") > > That's a v4.0 commit, yet this patch uses DEFINE_FREE() which is > only available in v6.6 but not any earlier stable kernels. I asked this question to Greg KH before creating this patch, and his answer was to implement my fix for master, and stable kernels would take care of backporting all the required dependencies. Now if I look at latest 6.1, 5.15, 5.10, 5.4, 4.19 stable kernels, none seem to have include/linux/cleanup.h today. But I suspect that sooner or later relevant master branch fixes will require stable kernels to backport cleanup.h, so why not do it now ? Thanks, Mathieu > > So the Fixes tag feels a bit weird. > > Apart from that, > Reviewed-by: Lukas Wunner -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com