From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F9CEC19F2D for ; Tue, 9 Aug 2022 20:20:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AD868E0006; Tue, 9 Aug 2022 16:20:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 85A798E0001; Tue, 9 Aug 2022 16:20:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FC808E0006; Tue, 9 Aug 2022 16:20:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5DED48E0001 for ; Tue, 9 Aug 2022 16:20:27 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 310881C68B2 for ; Tue, 9 Aug 2022 20:20:27 +0000 (UTC) X-FDA: 79781171694.30.5F6E695 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 8DD51160186 for ; Tue, 9 Aug 2022 20:20:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660076426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WcR+xwROcY1mQWTajdWclph8yvOYoZAKRICeYRXiSjg=; b=GxJZZ9/Fj9+4iO0v1HPTq/Upb9oBlBk9AS/TZEVFhZJZh2+A/RO0B6mP6/xYPlKsT8qXTH lfLdR1+TrNP6B6/xb8yX5dOIa+UD0mFcodoEoYY8tH7bLUKJJuVB6JHrykTGZF7oeaDHSj w8PTRu4MMMeurPTqlw2p4AtaEBoBh3E= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-556-p9wmThXFN7-TOuVbVK4HJw-1; Tue, 09 Aug 2022 16:20:25 -0400 X-MC-Unique: p9wmThXFN7-TOuVbVK4HJw-1 Received: by mail-wm1-f69.google.com with SMTP id n30-20020a05600c501e00b003a3264465ebso953262wmr.1 for ; Tue, 09 Aug 2022 13:20:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=WcR+xwROcY1mQWTajdWclph8yvOYoZAKRICeYRXiSjg=; b=6wNYYzS/XT1aNxwGdhSNXXJ7SNjdO0M8VGgDwO4JhPe8mj5rzNZQo3kzenBDsuOscY Tyo9ow1x1yPAMV1b1TwyXdFECTLiYklhJkRwpzfGv5I1k+H4fk9Hc2+L5flInk8gLIxQ 8Q9XURljU/NjUnq5q97QvnaoNMTqQpxFRJFAc6vZlWUf+yAeM4Aiz9xRK8r3OzILq703 wL1uyYdm2xl4rTHUR5B8MQTiT9YvarStPQjBQMKjjjMT6/YVxQ1L+2pmswTvarKeM04Q sJ6EdR4dxf7upNk6l6t3fUCU6Aan9iQnHtK1FLojK0N0v3ghO9O5AGc+Vlrmp85hOHEj mHsA== X-Gm-Message-State: ACgBeo3KTJLrwTtazEdK+/jXiIwr+pPAbOx1/oyW2gVvCo6H6rzKQXBn F6hzayZu83trsejzIrZHJaDOkEVux/I7fVNBzPDAS9k8vJL41mbY39+RJ8X5hwls79mwnqLdNxC TPaF6P9lzCWQ= X-Received: by 2002:a05:6000:1f08:b0:21f:bbe:252c with SMTP id bv8-20020a0560001f0800b0021f0bbe252cmr15069293wrb.340.1660076423834; Tue, 09 Aug 2022 13:20:23 -0700 (PDT) X-Google-Smtp-Source: AA6agR7Zk/2i2sQWeAOcXQyBbElluR5dmTZ3mGZC6uzovtHrJmIzwfvv+RsxeehU4XAEb3CDzxc9Ew== X-Received: by 2002:a05:6000:1f08:b0:21f:bbe:252c with SMTP id bv8-20020a0560001f0800b0021f0bbe252cmr15069286wrb.340.1660076423561; Tue, 09 Aug 2022 13:20:23 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:3700:aed2:a0f8:c270:7f30? (p200300cbc7053700aed2a0f8c2707f30.dip0.t-ipconnect.de. [2003:cb:c705:3700:aed2:a0f8:c270:7f30]) by smtp.gmail.com with ESMTPSA id k12-20020adfb34c000000b002205df9ce16sm14294415wrd.97.2022.08.09.13.20.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Aug 2022 13:20:23 -0700 (PDT) Message-ID: Date: Tue, 9 Aug 2022 22:20:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1] mm/gup: fix FOLL_FORCE COW security issue and remove FOLL_COW To: Linus Torvalds Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, Andrew Morton , Greg Kroah-Hartman , Axel Rasmussen , Peter Xu , Hugh Dickins , Andrea Arcangeli , Matthew Wilcox , Vlastimil Babka , John Hubbard , Jason Gunthorpe References: <20220808073232.8808-1-david@redhat.com> <91e18a2f-c93d-00b8-7c1b-6d8493c3b2d5@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660076426; a=rsa-sha256; cv=none; b=XAymSaPwUNMq+JEyOso5dGAQklUyT87yBEwl/ZeZA1iNrOCmIAhmrU3aOfaNLG7agRug1J V6YnMAhgMwNloSTV5/kNDZ6oqibdqHuptWBmsO3W9tXjgR05Nzj8V7b/1ur/nfnGk6ysNb s1MHr2vMH/KdmMOV75mLQhe37ejnPZ0= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="GxJZZ9/F"; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660076426; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WcR+xwROcY1mQWTajdWclph8yvOYoZAKRICeYRXiSjg=; b=NP0NO6GrGVqUs3rNycAPVzxXd2U+XdKZixUcJ3bJYAsbKSfWaHWjlKSSGBVg57YAIF15jS ON9ihYJnlZeL/MJ5GCTVWDu1LcsfI0H8a8xypl859PTzlg+AeAOMm0T+w5tsmsB9DULXG6 J0v5LM5YDoZGPEZkQ41tyx1UV8YITtI= X-Rspamd-Server: rspam06 X-Rspam-User: X-Stat-Signature: t5ddzxkmoofi5f6crw9smpj58ufxm7tc X-Rspamd-Queue-Id: 8DD51160186 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="GxJZZ9/F"; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1660076426-851810 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.08.22 22:14, Linus Torvalds wrote: > On Tue, Aug 9, 2022 at 1:07 PM David Hildenbrand wrote: >> >>> /* But FOLL_FORCE has no effect on shared mappings */ >>> if (vma->vm_flags & MAP_SHARED) >>> return false; >> >> I'd actually rather check for MAP_MAYSHARE here, which is even stronger. >> Thoughts? > > Hmm. Adding the test for both is basically free (all those vm_flags > checks end up being a bit mask and compare), so no objections. > > For some reason I though VM_SHARED and VM_MAYSHARE end up always being > the same bits, and it was a mistake to make them two bits in the first > place (unlike the read/write/exec bits that can are about mprotect), > > But as there are two bits, I'm sure somebody ends up touching one and > not the other. > > So yeah, I don't see any downside to just checking both bits. > > [ That said, is_cow_mapping() only checks VM_SHARED, so if they are > ever different, that's a potential source of confusion ] IIUC VM_MAYSHARE is always set in a MAP_SHARED mapping, but for file mappings we only set VM_SHARED if the file allows for writes (and we can set VM_MAYWRITE or even VM_WRITE). [don't ask me why, it's a steady source of confusion] That's why is_cow_mapping() works even due to the weird MAP_SHARED vs. VM_MAYSHARE logic. I'd actually only check for VM_MAYSHARE here, which implies MAP_SHARED. If someone would ever mess that up, I guess we'd be in bigger trouble. But whatever you prefer. -- Thanks, David / dhildenb