From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6D71EB64DB for ; Thu, 22 Jun 2023 13:57:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6647E8D0002; Thu, 22 Jun 2023 09:57:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 614BB8D0001; Thu, 22 Jun 2023 09:57:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B6B18D0002; Thu, 22 Jun 2023 09:57:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 380F38D0001 for ; Thu, 22 Jun 2023 09:57:52 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 11C511A0960 for ; Thu, 22 Jun 2023 13:57:52 +0000 (UTC) X-FDA: 80930537184.21.1DA48F6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id BDC5480024 for ; Thu, 22 Jun 2023 13:57:49 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GrfeDB98; spf=pass (imf02.hostedemail.com: domain of ypodemsk@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=ypodemsk@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687442269; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9GM+KaVBTG0d2ZoawOpQPP3iTozMv6kRahCWZiyW/ao=; b=B57F/wLOVT0ZZ1VaJNTWffOo9IsRjR76yqvySkbnUvMmHFUQNnDrNv2ci2FdxMohBARJVv ac9TybLvpHHziBFVgvOwLY1poexkS54365WC0S2V1NbW7JJAtgmO0fPFqlprLSkTrf6GHT wTlyEezy9yWrTIiZ8L/P0A7V1g54jt0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687442269; a=rsa-sha256; cv=none; b=QcqkypckH8PjNQ0Iz0Jk5vuRheLs2ndSPb0zG1WarO/0Te6qTjHO3nI6saPuSAhuPdm+oF fPq5SHsqJ1fX1fleK5SdOHSb9vPSaqcEmHIsKT3ZqMSS7X8mllV6uKsdgAPoJ25y+PxhYF Y0OKJFiuxlkADoLprTBxNDBxsIfrlZk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GrfeDB98; spf=pass (imf02.hostedemail.com: domain of ypodemsk@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=ypodemsk@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687442268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9GM+KaVBTG0d2ZoawOpQPP3iTozMv6kRahCWZiyW/ao=; b=GrfeDB98M8TK97Sd0g+1ywWvMWfuwud30XctJbaESIHqgZ54L1rpcfiRveyp8AoUeDNO+I K5zalzRDXWMO32F3kJWPIcK9MTHwMPC8MADpmZKjbf8WyNpcAmscbIwEcfi05tBYUHgDEl G/S1E3xbYfFWAL0R+57twA7j9S+yUgs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-675-7zzdebM7MkCL3x7syAQqnA-1; Thu, 22 Jun 2023 09:57:47 -0400 X-MC-Unique: 7zzdebM7MkCL3x7syAQqnA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f8fe1f1199so27179635e9.0 for ; Thu, 22 Jun 2023 06:57:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687442263; x=1690034263; h=content-transfer-encoding:mime-version:references:in-reply-to:date :cc:to:from:subject:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9GM+KaVBTG0d2ZoawOpQPP3iTozMv6kRahCWZiyW/ao=; b=AV6NwNVN/B0I+8PpsjSIsjyCtggkaLtaJQ1N+d0HpP5q2D9J2qmZYxVgQxlYi6TpXt Nx9l/HL22vOyvuTu1o1gSyURMFO+XxPUo7nxyt2YBDOGOo3EYpXwMAr3uAAIA6Lt225k 4rT4AXs5sWUh+EYqQ35fvpLlPsqN7AMtrVm9g5NoZck7WQ+IuZKJH8Q3qcsRYfGy72AJ uY9qcayaANFv5qmD1LFs5aR/QAmEJ6F7hD8j2GqqV7u5NdW8fAaCdncpE9cYbs7OAR18 rBbe7GL2P8gh/vMalQBGZmOsHq6nwUV/txtbJZH3HBtGBCOC5Q0zzWwYJnu2GyAeYgGB GxDg== X-Gm-Message-State: AC+VfDxicMpsItLgmQihObWHvrdV+J0+XS6SRnRHGqKdNcE0kYjfOcZT cmFm5MZ/xVvA3EdDYoH6quHxfNbbXHet+g51aOsVQ30iITGptZ33SsMGTfaPvOAvafBrCfZk2Hq rmTzVrzxtyhc= X-Received: by 2002:a05:600c:2942:b0:3f7:5d:4a06 with SMTP id n2-20020a05600c294200b003f7005d4a06mr1531939wmd.1.1687442263393; Thu, 22 Jun 2023 06:57:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5p9/Up90QSZ1DAdrQMEuugJHQR/5D9norGZu6r3B4czFVgo4n6RIoxrIJViM7m10t9Bv6d/Q== X-Received: by 2002:a05:600c:2942:b0:3f7:5d:4a06 with SMTP id n2-20020a05600c294200b003f7005d4a06mr1531890wmd.1.1687442263118; Thu, 22 Jun 2023 06:57:43 -0700 (PDT) Received: from ypodemsk.tlv.csb (IGLD-84-229-250-192.inter.net.il. [84.229.250.192]) by smtp.gmail.com with ESMTPSA id n6-20020a7bcbc6000000b003f7e4d143cfsm7832711wmi.15.2023.06.22.06.57.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 06:57:42 -0700 (PDT) Message-ID: Subject: Re: [PATCH v2 2/2] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to MM CPUs From: ypodemsk@redhat.com To: Nadav Amit Cc: mtosatti@redhat.com, ppandit@redhat.com, David Hildenbrand , "Russell King (Oracle)" , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Heiko Carstens , gor@linux.ibm.com, agordeev@linux.ibm.com, Christian Borntraeger , svens@linux.ibm.com, "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Kees Cook , "Paul E. McKenney" , frederic@kernel.org, Will Deacon , Peter Zijlstra , ardb@kernel.org, samitolvanen@google.com, juerg.haefliger@canonical.com, Arnd Bergmann , rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, linus.walleij@linaro.org, Andrew Morton , sebastian.reichel@collabora.com, Mike Rapoport , aneesh.kumar@linux.ibm.com, the arch/x86 maintainers , linux-arm-kernel@lists.infradead.org, linuxppc-dev , linux-s390 , sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm , linux-kernel@vger.kernel.org Date: Thu, 22 Jun 2023 16:57:39 +0300 In-Reply-To: <10050BB1-15A4-4E84-B900-B21500B2079B@gmail.com> References: <20230620144618.125703-1-ypodemsk@redhat.com> <20230620144618.125703-3-ypodemsk@redhat.com> <10050BB1-15A4-4E84-B900-B21500B2079B@gmail.com> X-Mailer: Evolution 3.28.5 (3.28.5-22.el8) Mime-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Stat-Signature: e9bytsjn1p9ck83qzhyphp571uqk6o3t X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BDC5480024 X-Rspam-User: X-HE-Tag: 1687442269-562042 X-HE-Meta: U2FsdGVkX18T1gUuBInnoOK4uwvjZfcPs1HBUCiaCIbzV9QQAe9s9x6+zG3qCGt8b5L7M1HEn/o6cZZfYMJch6/q4o3Dhuin+kSIKWH+96QyqvMELSGfJ9570cHYQDUW4Z6EbD4QHtaFmvrIGxjvzc9mTm4hxzs7m4ZGo/UgK58u9/vghwMkW7hTiHaPNvFo1mO1ih6yu3HgCcZvXM3CfUkvkLt8WGxOvGjpsGHLV018QppnEHY2ubE8uFTDCw91t8gRSxuMJHWD2X3WZUPwsocGebMUlov1T/BsXUXeXVJorvO9ZSh2sFstBqz216c27hk3JBPQ5q75OvF3GMX1ywPs8m8kFHEhFrZAx8FCLVLxYxUjVsV7yae5f4edXUhJ6MTKMgQxDY2i/1eI1qEy0PX2/doFXkRWeO71RUsHXaKEKtkpVykTAUgjuKSKXdyipWDy2LJo8suVAF+iRsAcZuT3714WYG0/HP3NoAG8sVJkMo48w5F2ApZHyhKrxJfbim2KFLQ/69xbnVNKjlHSDBjaGCTng9Mjn9UstFpSKwW74djV1DVMdVisiFa8JM1CfUYRmo5XLEy+uf+LKRhwc9o37V8ryouT1oncEIBeXuuKABtW6fdFThsOmVE3Xy3eoKEm7D/krcnSLpKMUeqOvv8YdeykOZjb58Qnu7tfsnX/aY95vPnGfvckskNrop/6eJuCA6ateRebYro1qHAHWXEIN0i7teab+Jn/4BMpPyQquRJdCyD6GQfHQftmWP7DcSWzrBItIsTOfxqSPE+mgm55D3jmjHI8yHfmZxYPMM1Ezd/ot+3W4DU3lVF1HclqrC4APywdAybB1uw9a7KvsLg6FroyXTV5Vi4FVUL80ScEHTTwR8yyCo4T4M+I4NwNtl7EZgcJqRA9z8UImQOZMtSSn664IgE0x8gXYZR/2EI0VAlCV/sbLI1aE2We+rUaOmY1vR2OfDTanFDPf/1 TEd1LTUH MAzrIrHuukeng7hhWfAN0PIoqlEH9k6/E9rLuw4MKO0TZgcaUPspZyg3VSttXAph9Xk8RtznullXTvBWOlGvWGTPD5aUV5jsIyEIefo975g+eAwG3H7oV5Xh8C5o9bKLScDdbq8XY2NPMJD65NAmCk/cctqpH5+KHvXbLPF8DOSTyuSAnAzUyQbyoupRRDTXiP1BfPWy13XpBlGyXa3VqyxRxfD64UtOqtr8V8FsVgQyvcZM4RIDZuX+vCOIXQnO8XRhBTZsa4rUzIhMmZDS0SuGuKqQLSQYZVRbgI8Uh7dOR5DpZ9VvqvS++Q0zAhB/zcBFx6NJGPQ4sWBrv5+sxlWIPoXAdy1SIgR9eoO+/3MTbNjReEUGl99KkdWxHhSBSfqmtgW8v6yCacd2Mb94tutDEDvCjIbSCaSV2Dul6qCFvv0Xf2YykB73U1jSJh0cVvnv5+qsQ6ZhAuyMtl16qtuiQ/8UM1C2tdQsnzkW3+Z+YDN7KKR9BFPMYsfLvIvUFSU42+RLpt8Gcbktn7zs7MUN/FyKO3QxurjGSq86j/qEF4s4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2023-06-21 at 11:02 -0700, Nadav Amit wrote: > > On Jun 20, 2023, at 7:46 AM, Yair Podemsky > > wrote: > > > > @@ -1525,7 +1525,7 @@ static void collapse_and_free_pmd(struct > > mm_struct *mm, struct vm_area_struct *v > > addr + HPAGE_PMD_SIZE); > > mmu_notifier_invalidate_range_start(&range); > > pmd = pmdp_collapse_flush(vma, addr, pmdp); > > - tlb_remove_table_sync_one(); > > + tlb_remove_table_sync_one(mm); > > Can’t pmdp_collapse_flush() have one additional argument > “freed_tables” > that it would propagate, for instance on x86 to flush_tlb_mm_range() > ? > Then you would not need tlb_remove_table_sync_one() to issue an > additional > IPI, no? > > It just seems that you might still have 2 IPIs in many cases instead > of > one, and unless I am missing something, I don’t see why. > Hi Nadav, Thanks for your comment. I think you are right and in some configurations 2 IPIs might occur. However I a am not really dealing with the thp code at the moment, This patch is about the mmu_gatherer and mostly dealing with IPIs sent via the other code path. Thanks, Yair