From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BD8EC77B7D for ; Mon, 15 May 2023 02:15:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46634900003; Sun, 14 May 2023 22:15:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EDE6900002; Sun, 14 May 2023 22:15:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 219C4900003; Sun, 14 May 2023 22:15:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0DDC4900002 for ; Sun, 14 May 2023 22:15:12 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CC27B14100F for ; Mon, 15 May 2023 02:15:11 +0000 (UTC) X-FDA: 80790872022.07.B26EB45 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf16.hostedemail.com (Postfix) with ESMTP id BF4D018000A for ; Mon, 15 May 2023 02:15:07 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hN6zF7Su; spf=pass (imf16.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684116908; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NelkYfx8YH+UUK6PTp6fhYfNuWF+sQF/12GFZqYM5HQ=; b=Ayro+AhNqtra4Ec3jZf/HUYA2tAkPgdYfH94RwyDW12bUyyJh64hThAHtjv39IUvsLDDUt beVbde2KLUN77vCV/23f4Vy4QgyvGDenKpohRThY4KOmX4HaphASEhmrVSuQ/Z2zkkl6V6 +Tw3GU295Z8STluijbdIVkdlCbbhVD8= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1684116908; a=rsa-sha256; cv=fail; b=xxTdCdjNINNrfa0gl5HL9sA6tKSQJGuVXojol7xNzgsuQOdrcQ8EZt9AGGxKRSUkc62b9t oCXjjobEozG/+Y9CV+oM2CXy2thTbSs3PgOyDo8c6GnJokQiTgS9Gh4g840vny9GmmRrLj PN0OGs/PtFThDS7JN6niBx4DYXCKT5w= ARC-Authentication-Results: i=2; imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hN6zF7Su; spf=pass (imf16.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684116907; x=1715652907; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=eY/EU/O9CNobEIQOdCwSdrNUdwOXDsnDJPO02qGqFsA=; b=hN6zF7SuGzS81jzFt5+4619lUDN86on7ydWUhz8vNKPL0xwN5QRLLdD5 /GdlNXgxi3XRvLAl4MOwjq05B+Zoacze9apy8PYn8sxiQRlbBd2u9w3Qv o4tRfkQkS9h0ucrAUUZRfKiAXH+aitgqnpjI5El75CIl7t7PpEsCshPKb /5n26TZKYgN8g6r26hPAx9h1WA+VVH9PTBt0+TrgnCV6TEVcneiNXvUBa ywEh9AQ0TGA8t5n0IfQbXrmYXA1WL/lGrr+5DBPM0CB/1Vfl16OFaP4Ts ei/THiY3LxitN5amjGYVbQT83iPCEmaB8cDMuULEdzTqTG+PJEU8srNEO A==; X-IronPort-AV: E=McAfee;i="6600,9927,10710"; a="335624519" X-IronPort-AV: E=Sophos;i="5.99,275,1677571200"; d="scan'208";a="335624519" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2023 19:15:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10710"; a="765764061" X-IronPort-AV: E=Sophos;i="5.99,275,1677571200"; d="scan'208";a="765764061" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga008.fm.intel.com with ESMTP; 14 May 2023 19:15:03 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 14 May 2023 19:15:03 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sun, 14 May 2023 19:15:03 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.43) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sun, 14 May 2023 19:15:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bpDvS1D5vexeZFrw1uPKe/hyDhSysNUpNhdCnh7ujX8taterehFgoCaiCapGz3I1fuE95WnLCz46eDGiLfgen01ugTntrsgYMDK7N7MJ3gWICPqNQ48yCTpk4CMrjodGX9s9tIjIHsSRTuKLY/QEQ8/Rz8gY9Rcomgn0bd/JD/mpe4Yfwk3Zz1uLoSz0vEJgbt1KvcJFd2xUsgA7a+W9GkksWBhaY5Z9Tyx0DhpOz3OtH0dgM2cS02HA5n2svuK4j8+PVlrkfnrBzBWxE8Se7aWWtQ0l1GWg6BVIkb6J4U9uVs8USt2A1WL5gLRiN/7AsYfQ0l3mSpEQNWizJggcUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NelkYfx8YH+UUK6PTp6fhYfNuWF+sQF/12GFZqYM5HQ=; b=BCedMW5glwxqEknuSToWf0sDRaV0RH57Axn0nyveh5NRmJhr+SkTiTi91kDgS0WNvfR9fQ1YEPkpaaLJW91q54XY+64sue+FmM4SQmEKTIQUeHRaIpoLf57N0UkIL8MKQryxZTnGbO7h3U2and5W0UM4Mlxm5rvZFHbqOVKl+Rj8LCkKua6C2uVOUAu5aVrdrILObGgZWWYmpf2+5mHB5U4EOAKsGYQwX+ayCkTPHpeOkehh7QMDBtGIt8JbWG8hjd8G9/IaYSkRQGMQebXdGaDR2YfnFtwCRZ3Ya5sRKbHPdkY9p/3k4TtxYbaeqXJbyhTNs/W7Ie41M5MJZTg2cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by IA1PR11MB6515.namprd11.prod.outlook.com (2603:10b6:208:3a1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Mon, 15 May 2023 02:15:00 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::50b7:677e:7f81:1cae]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::50b7:677e:7f81:1cae%6]) with mapi id 15.20.6387.030; Mon, 15 May 2023 02:15:00 +0000 Message-ID: Date: Mon, 15 May 2023 10:14:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.11.0 Subject: Re: [PATCH v3 2/2] lru: allow large batched add large folio to lru list From: "Yin, Fengwei" To: Matthew Wilcox CC: , , , , , References: <20230429082759.1600796-1-fengwei.yin@intel.com> <20230429082759.1600796-3-fengwei.yin@intel.com> <8d4f938e-4f0a-bb97-3890-910b5838d6f5@intel.com> Content-Language: en-US In-Reply-To: <8d4f938e-4f0a-bb97-3890-910b5838d6f5@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR03CA0113.apcprd03.prod.outlook.com (2603:1096:4:91::17) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|IA1PR11MB6515:EE_ X-MS-Office365-Filtering-Correlation-Id: d0bcbcde-81c6-4a0b-a57f-08db54ea2f9c X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fCdNzJmUNWXIOJ2B4cA3DyoPKQ0WjMp0yKWwEMV5InrIvcvY0hCtTqCi9ZgmRxYxwmZn+1tNG4e35Oa0IQZw58BfxrUfzSK2gJ6lYIBVege2n0HrO/qgzk2ThulIQV+oLdpAJMU37IxgGDN1GjP7UoJTrxW3K8tovnEMbTlwpT68c4UAwSatz54/8J6woZWoenR8mfpWsgCNOccbwGr1rfk09NOePV9iBfiJIOCmnMTMb3EjkBYFf6ucA2+TK8ZWJaVbKG4j23iqSQBIlfQbIH2HGsRiqA1f6Gdz/gRVGmbxvcxnbkDc//Nvuv+7yiJzIwtC/cRdTV5LTRaKPc4kkJJFJswvonnOlzKD5VX3xtSDc9tqiPVFyerb2Anm/uKGv3CQ4QNhBNbmL9tNN1sDaXbetsxmgLes1bXdhGY3XiRK6eK5w/4RcABJNHHXytk3MV2WwN/S35OoMiEx/TbHVgIMqsIqPqjAAlbxdC46yug8v8jg1bR/s9oYIgTZ4IUM+h7xqRYk+wSfenTIc3ELzm/Mfw30u6FANeaq2Eg5OnkCNbw7mF2VBq6pxL4WCpuj4c8CPhOde76He1fzd+wuaCPPV5HaL8nqvXyML1pRvexsLbTdijdVG6qp6T9HldTFx8ZbD1U+PAGjl2RBb3nPsw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(39860400002)(366004)(136003)(346002)(396003)(451199021)(86362001)(2906002)(31696002)(66946007)(66556008)(66476007)(316002)(4326008)(6916009)(38100700002)(6486002)(6666004)(36756003)(478600001)(83380400001)(53546011)(31686004)(107886003)(26005)(186003)(8936002)(8676002)(6506007)(6512007)(2616005)(41300700001)(82960400001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkxJdmMvcWJsaXhQNVFMTGlKelhibmF6N2VqVUlFdGhvamF0YVdtMzg1cWRO?= =?utf-8?B?ZHZMZDRUcGI4U1o1dmNhVk1qREUzMDQ1OG44c0JmY2NibE5KWEdEWXRpMUlv?= =?utf-8?B?eGdIWHZma0prZ0RnbGlSbnJCYnVyTDVRd3F6TmdpUktRTXViR1dQY01pZlkr?= =?utf-8?B?TkNDTHZYYngzTDFpM2F2SklueGR4L0o2KytUUndCZHZ6T0FrT2tkM3JsTnhX?= =?utf-8?B?ZHRRTVRKZzI3N0tZd0o3V2NNQVdNZFk5anhWVVFxSllBVjcvbFB3QW1iekpD?= =?utf-8?B?b1RyOEdkY1ozYWQwVFkvaWx3Y2Q5RUZKQzd2VWNlajNESEhZanhzNEZudHNa?= =?utf-8?B?c1RCWE5RWklHSGFoYmJyd28rV2wwZ0VzNmpFQ3BXQ0tUc3pGcW5jbE8yQzNn?= =?utf-8?B?bG1xWWd3d0dseDFjQWtvWlN6dzhpaUFZZjZ5QSttL3AyUjBDWkNMVFU4b1dn?= =?utf-8?B?NW5iQnFHVzZvVVZsaStkSkxveEE0VUtxSHpEZW9aRzkrT3k2QkJIOU1WbFY2?= =?utf-8?B?TVJqZ2Jobm5zZUJyNUZGd29qTDlCdWxVa1JaakpMY0REYlZhS2F3THlSczNJ?= =?utf-8?B?K3FkL1VpRXhGSlVkUW0vbHYyUHc1MGRQeGV4TVBKbGJLeVNBN3pQRXJJZExY?= =?utf-8?B?MWc0dmsyQXZRbWJsNmVBMHhYZlJXOVdMSStiT1N1dExZam5NcUlONnR0ZFFW?= =?utf-8?B?V3dwait1RGJwSDFYMHc0dmljR09OZFY1TmlOWFd3Tmx4OE9obXVZWlIxMjNS?= =?utf-8?B?YksveUFsVXBEUUxXTVNRV3dwQUp0THJHdW02TGh4YUx6WWlNWFdOb0hvOC9L?= =?utf-8?B?dXkxYnl6ZnN6WWZjMzlGcmJYM2V2WGUxMDFIM0JlbW15T2NPMVJGM0o4bGJF?= =?utf-8?B?VlFOTlYvRm1rZnBISEVqMmJxVW9SNmhpcmZ1bDhYQnpaeXFNdll6UkFRd0Na?= =?utf-8?B?aUlDVThqckwxeWdhcHVhazNQWWd4UVlwT3dnNmZaRkRxUEFKcWQ1OUh3ZzR3?= =?utf-8?B?bUdyQzEvVFdIMzlncktqcXhjZW9kWnhYMHVNdFVaaVdHcG9SbHN4MlhmSURo?= =?utf-8?B?bUUzYmhCWCtGcFdKcFhwSDhqdmhEd01Dd0JQNDI3YUJUYmQ5bEp3elVpcUQr?= =?utf-8?B?OWN3V25UNW81VXpQTUFIZlJKSGFodFZGTWlJNE9yWGk5a0FwcjJ6M1M3SnhO?= =?utf-8?B?M01YSDM4ZHdPYkN3SFZTTThSMEZFRHFBdGpoVVVmdnFmSWJaQlJpaTN4MmNz?= =?utf-8?B?UFJiaDNYWnZyTHZSMlR6UEZUbDNiOE5zQ0ljdFIrd3BYYWx1c25pSEhVQjhl?= =?utf-8?B?NTdvOW5qRDlIVklqTWJ2R01idkl3TnJ6WEltbENZcitTQjBWL1VqTy9zckQv?= =?utf-8?B?dDhHcmJndlpqbXQ1M2tLUWhsbFJkQnZPZzVObi9Uc0pyN01MRTl0bkEzdmFM?= =?utf-8?B?TGg1WVVqaWVzTjBpMEcwRkdSZURqK3pQMHJPSGFVMC8wZmczTGFKU21oWTcv?= =?utf-8?B?TjJkeWhQU2thRXlWemZSbzdMNllicXIxRng1akJBVFFWY3BBL0s1UXh6RlNk?= =?utf-8?B?UlExS21FbWo1OFozcUpmQk8zb3d4KzNoNG9vRVBka0hOTThkcmJLRW0yVDhF?= =?utf-8?B?dENONG0rUW53b2xnUUxBRFNFUFhZYzNxak13UEQrK09SemNjNDYreEt2OEZG?= =?utf-8?B?UTdlNlJMSGJVek1FMnlJTkI0S0x6QjI3SXVKbmUzc3F5ZWl6dHN2NjNDMkRF?= =?utf-8?B?SGlpdnNtV3EvdkR2bktVbTN1Z3pqSzNoR05JZXZUYnFSeEJsOXM1YmlRV0tP?= =?utf-8?B?Nmg2alc1Y2k5WE5QdkhjbzIweG5mMzBMQ2VKUEZ2cGxwVUtLOWQ3c29qK1pi?= =?utf-8?B?b0FPeHJ6ZzRobHdjaHMyN3EvUzZXTVA2eVRHRlFQeU5qUG80S2xXaDRuUkpM?= =?utf-8?B?OE1qYkREbXhQNUcydVJNbkJCODUwVVVNT2NPWDQxTng0YmVkZTVWR21ISmVO?= =?utf-8?B?WGNmTjBWdTUrTkdHVkRJNHFYSG13K2w5d0RYSFZCNmlCYzJhS3BTZ01aeVli?= =?utf-8?B?UkozTXZnYVYxck9nWCs3NTdrVUZ2YVc5WkVDQ21nNG9rSU9HdDJPM2YxMmRs?= =?utf-8?Q?MR62sf+WU978lUv0UKIzj+riQ?= X-MS-Exchange-CrossTenant-Network-Message-Id: d0bcbcde-81c6-4a0b-a57f-08db54ea2f9c X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2023 02:15:00.4871 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ae022Qio1/2aa34/+mOGZAINerg9QYc9FwUhpLIco+pVk6dVFUly1uROtj8aTB7OKbYkUgCg2m8UYY8Oo2sftw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6515 X-OriginatorOrg: intel.com X-Stat-Signature: yus9ikmnd1r9p9dw8nhs8epsd3j9rab9 X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: BF4D018000A X-HE-Tag: 1684116907-576132 X-HE-Meta: U2FsdGVkX19BcUHWZKxJF54zDNSpO/DUNLZ5hXjQDKI4tA00bFuv3663jJittrG1MdvEaK+jtdxckksC/Ys3lojTXXkAxcGHj7nfnI7MeuBQela80Ir/8QMEjcfnKHq2Ymn9okdQNgvwzaP0MmMmN4Pu35QXLiqu5OlLgZE4V+vgYg647j0zWHhxS6UP3Br1lUJUFCf8rKgfoirPZhDkdTrRRXlqZ5xCITKAaLO2fDhCGKY3DX9zXroQrwEzanL6cswqht0qpp/hV5bgAvHb+WXkcIVHM76K1UGKOalID7SKkaB8V7kuH8Uj2U6z4AgpilNHzIgpMu3jVWmmd6JYR5QmozRamuKt3kcLYdRa5WJ7M+BKShioPwFmaqYmJqfy/jMJKxzayAF71yLJ2RvIZRgd50pJXwF8DRJaOgvCjxUWDbTi6X4lCdC+F6oEP+Jak7haBcyCJ4vlK5bty3ABc+gZ+ZT7b4Bk4xzK+Udg/fzRFqYA1iTKRpC8kadoCfGJgp0QuvXT6LJucf9erfLawYCfLXNMBy8TbM9PIdnO9AIkeStPmtoVnyZkhZThFEwvBP4CZ1PkUDP/2LpgVjOM9dfrroVjdswqeEUtz4mAuQavepkO+DTvEHUTwitKsEPPUiHQ2Vb+PZby0pago1CvtvDHq66Auqeh+I8PvQnchKVI6HcJbHQsHp1QXVl268+2q5ELCzImnEaaSxbhnzKI4vff0E4U2e5uB699aMMvtdzAN/Ycar6myCiHMOs+cSU8SuNtI0PcbyBaU9XWuAchrVGZdxnxSvFI+HIZ63ndb38yRGdQ99KEPsttYv9mTLk2SLdbe0TqsMwPXAAwUrltVIbLYuiV/Bgkn2uERzqMqWQbMAuhEUnd01Nou1nDyi8jjwlPt3f0Y1tXt/mgwhZ9xAiG1rMrXqkST0P0DzxGSpLru8tyFxNOmVs5ctJKWCdMYFU6BhxdPyfWK3y12D7 793bCiBu 4bRNSdwhTGWfcTx9oq+QzoAuMaeo+MRU6DKemYAUoAiNM3pAOIy3Godu2KviZYfTamYpTBwOB+glo7PTRZiU/tKcH3w02qEJPtnzCY+ER676PuI5Da6HtTVvDBNJfzJJccq3WX2ahXpCn7XqZvUmj+lL/4uHXW1lsKt/sajeV+fol6zQD5OLPrujRG80T+bfkyXE4PYHoucT5mcF+jEGP1ORy9k0pdxNjqCZhUQsM1XANkXICLienZEfkZxCr9SofGYvKtWv6N7Uq7aLg3s1TPYLQPQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Matthew, On 5/5/2023 1:51 PM, Yin, Fengwei wrote: > Hi Matthew, > > On 4/30/2023 6:35 AM, Matthew Wilcox wrote: >> On Sat, Apr 29, 2023 at 04:27:59PM +0800, Yin Fengwei wrote: >>> @@ -22,6 +23,7 @@ struct address_space; >>> struct pagevec { >>> unsigned char nr; >>> bool percpu_pvec_drained; >>> + unsigned short nr_pages; >> >> I still don't like storing nr_pages in the pagevec/folio_batch. >> > > What about the change like following: Soft ping. Regards Yin, Fengwei > > diff --git a/mm/swap.c b/mm/swap.c > index 57cb01b042f6..5e7e9c0734ab 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -228,8 +228,10 @@ static void folio_batch_move_lru(struct folio_batch *fbatch, move_fn_t move_fn) > static void folio_batch_add_and_move(struct folio_batch *fbatch, > struct folio *folio, move_fn_t move_fn) > { > - if (folio_batch_add(fbatch, folio) && !folio_test_large(folio) && > - !lru_cache_disabled()) > + int nr_pages = folio_nr_pages(folio); > + > + if (folio_batch_add(fbatch, folio) && !lru_cache_disabled() && > + (!folio_test_large(folio) || (nr_pages <= (PAGEVEC_SIZE + 1)))) > return; > folio_batch_move_lru(fbatch, move_fn); > } > > > I did testing about the lru lock contention with different folio size > with will-it-scale + deferred queue lock contention mitigated: > - If large folio size is 16K (order 2), the lru lock takes 64.31% cpu runtime > - If large folio size is 64K (order 4), the lru lock takes 24.24% cpu runtime > This is as our expectation: The larger size of folio, the less lru lock > contention. > > It's acceptable to not batched operate on large folio which is large > enough. PAGEVEC_SIZE + 1 is chosen here based on following reasons: > - acceptable max memory size per batch: 15 x 16 x 4096 = 983040 bytes > - the folios with size larger than it will not apply batched operation. > But the lru lock contention is not high already. > > > I collected data with lru contention when run will-it-scale.page_fault1: > > folio with order 2: > Without the change: > - 64.31% 0.23% page_fault1_pro [kernel.kallsyms] [k] folio_lruvec_lock_irqsave > + 64.07% folio_lruvec_lock_irqsave > > With the change: > - 21.55% 0.21% page_fault1_pro [kernel.kallsyms] [k] folio_lruvec_lock_irqsave > + 21.34% folio_lruvec_lock_irqsave > > folio with order 4: > Without the change: > - 24.24% 0.15% page_fault1_pro [kernel.kallsyms] [k] folio_lruvec_lock_irqsave > + 24.09% folio_lruvec_lock_irqsave > > With the change: > - 2.20% 0.09% page_fault1_pro [kernel.kallsyms] [k] folio_lruvec_lock_irqsave > + 2.11% folio_lruvec_lock_irqsave > > folio with order 5: > - 8.21% 0.16% page_fault1_pro [kernel.kallsyms] [k] folio_lruvec_lock_irqsave > + 8.05% folio_lruvec_lock_irqsave > > > Regards > Yin, Fengwei >