From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFD7DC3DA4A for ; Fri, 9 Aug 2024 09:22:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 574C66B008A; Fri, 9 Aug 2024 05:22:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 525436B0092; Fri, 9 Aug 2024 05:22:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39E816B0095; Fri, 9 Aug 2024 05:22:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1AEE06B008A for ; Fri, 9 Aug 2024 05:22:40 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A6F43120B55 for ; Fri, 9 Aug 2024 09:22:39 +0000 (UTC) X-FDA: 82432166838.28.B6644E4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 606B380019 for ; Fri, 9 Aug 2024 09:22:37 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XRP4BhPW; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723195291; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BDv163H6Bi3O1k6DViCc+myNqZR4ExwgVShUmudZIdU=; b=ePd9w6jGMW1kNwKtrN+/wiz5THWV9rKNCc5yeUjwP46vAVY1W+FhF/lNd8aY2Esh/ab7HU edQ9vC2Q62Ag6c7I8ToXwB65Y85kg3w4W/S37D50IAbmalmm8Dzu9Lp4WSUZDiOStY2+iz ifsuUhjMGI1IWPTW13/X6dCyNpMxwXs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723195291; a=rsa-sha256; cv=none; b=5oCsWGqK7GD2n2Ij+9tovw8frDBYhuTJZBrvEIQPJDc909KvAnYJyEiwjv96EMYM3aiG/X VSBmgs8EKXzGDeOF3P6iU3Np99s6VcI4WGMxZojYr9lzqRbFo5e1pHaxui6WnM9nTEQru7 0SPvS4GGFRHWU8q8R/Y5UJzXi8dSZTQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XRP4BhPW; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723195356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BDv163H6Bi3O1k6DViCc+myNqZR4ExwgVShUmudZIdU=; b=XRP4BhPWB/gmOu4y+or3ZxoIEFPqDgolbVWA7HlGPegPOrISS2uAgCNUsHTPTp5HEkYc3O 6ZJuJzXgW0YTqtAZVzXNr3pT+FgOd5twkAh7e8MyKwkP6hgiUCWwNVbCyGRz+nb7cu3wYI 52VVp+fnWMUZiBmIjqhqd63zcU8nQbQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-UVKyHC7KO3-MDqx0Y9uHTQ-1; Fri, 09 Aug 2024 05:22:35 -0400 X-MC-Unique: UVKyHC7KO3-MDqx0Y9uHTQ-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-42817980766so13180595e9.3 for ; Fri, 09 Aug 2024 02:22:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723195354; x=1723800154; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BDv163H6Bi3O1k6DViCc+myNqZR4ExwgVShUmudZIdU=; b=hB+ExGFrU8+yH8flzUMa+tY/6ER6AMmIiRj3Xi2V+LFPkYWnaqRTkvBqE7LIOu55ux ufP+KgheEh5nb595qw+i6sFBM6jnNsIBI1+MZLpSYRd1C+2IsliNiZzPNm1FF1ymnAk2 lO9EZYWW5bz0RT0CKHfw63YbS4ahTlj1i495TpKQjm6qc//Flp5REKA3SPcDZV0SswjG BRP6jNmye4/VDYmwytsQtpTgXc/E6jtrmG35UsJydIi+hiwj+X019Z3KiicZGlIWNABS BI6iSkMS7bWCnGB3BQHrTFIJRJwR3ADOPqJtK6VhsNh+5TaPI9KlmOYKLYPFU9TulX9/ YQ5w== X-Forwarded-Encrypted: i=1; AJvYcCX5EuIvUke/Y7AEqnoQoF9ZZJc8+9O/odWoyVLqnJm/TZmgE2nOM54zMc7of3VdHPsY1VvcIhTX7/6Z/8tyq0m5+7E= X-Gm-Message-State: AOJu0YyaIG5/4iQhGn6tVRmdXIOsIRmrKEbMv+ntclO0eShCBvkbQ4Ve HW+UvgsjRU60vu41XJS/ECfY7rIdMfdxLW2hO+pOQn6ZndPeqP3OQHBsrweH0Hd/jS7szvkdlcd z0AUHT3xYgLFKnShobrOt2F8+OZoU9gBQhOsdG9VSHUSLv69/ X-Received: by 2002:a7b:ce07:0:b0:429:994:41ae with SMTP id 5b1f17b1804b1-429c3a17a22mr6800445e9.2.1723195353638; Fri, 09 Aug 2024 02:22:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjQV/rdx8PUo9vUQyfaTjez+THFqUPuYqAd3V1sDHGnyKOutxuvkeX2zQH9nqEVdP3Eeh70w== X-Received: by 2002:a7b:ce07:0:b0:429:994:41ae with SMTP id 5b1f17b1804b1-429c3a17a22mr6800245e9.2.1723195353063; Fri, 09 Aug 2024 02:22:33 -0700 (PDT) Received: from ?IPV6:2003:cb:c71c:4e00:b097:7075:f6ba:300a? (p200300cbc71c4e00b0977075f6ba300a.dip0.t-ipconnect.de. [2003:cb:c71c:4e00:b097:7075:f6ba:300a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4290c72d551sm67614045e9.2.2024.08.09.02.22.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Aug 2024 02:22:32 -0700 (PDT) Message-ID: Date: Fri, 9 Aug 2024 11:22:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 1/2] mm: collect the number of anon large folios To: Ryan Roberts , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: chrisl@kernel.org, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, ioworker0@gmail.com, baolin.wang@linux.alibaba.com, ziy@nvidia.com, hanchuanhua@oppo.com, Barry Song References: <20240808010457.228753-1-21cnbao@gmail.com> <20240808010457.228753-2-21cnbao@gmail.com> <1222cd76-e732-4238-9413-61843249c1e8@arm.com> <4465afdc-23e9-4844-a0a0-519f49b1229c@redhat.com> <616401ea-289d-4ae2-acde-6704b0fa9c46@redhat.com> <9f8ba5c8-5bc3-4af2-96d2-2f52ee923ef5@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <9f8ba5c8-5bc3-4af2-96d2-2f52ee923ef5@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: fff5uu64in8hzg4fxzd957qnqkz6a3yw X-Rspamd-Queue-Id: 606B380019 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1723195357-924585 X-HE-Meta: U2FsdGVkX18L1goI0BQFULR/mIJVsst82h1+1PXs0jGGuYU2JtFpQ6f+ArLdl/+/M21Xws8w/cO1rmsmyR3JhtmfXdIg47bnOZwYoFbw3S7DLQJBfaYmWczM9wQM/BFgnQbZ0UfgMr0m06X3g/NkRrIFTYN0yFBIkGs5dLkVaDJmND1aU72EhPNUSLi3XMSlUPJ1ITY17NYP22T7CYZe7yXj180xCKU9pBuMNfgZU3ODaSZwWdPWtNlV5w5S2WyKE6eHAWd4y1ArQnreVf94lc1KmSmjEzpQpmYv1ANU/AMWWrRUMCYAveIWkWDM+y8kV4QVYCm+6aE7WClzaIgGxNdUMgs6pdli5rm4hVTY14YO7qBv8S6cr65R9m4mamk5gfUemc32SaCufvL8101tc+Sjyt82nRZpihopCalyFmzCWyU/Ukce2UwPcBz+In6MlZj2qdQo/aX4G9Ams+C5bnpDTjSI4TTS75oDVKaCzBDbRZAMCjnpIkMRYvt+ygBK8jJ7Z5KuIBTSEivtElqr3Ewdfy5iKSS21+Ki/gtod9kpZfVVjNZa4TzD2pSMQjNV20RnvNC3j17M67ZpSyxlp+RyCoRjSJDioA8W1JzFaX78bBYyf7Nz/6gQrRKnCy1juyVdnGdZk5rCO7uJ8vnK4oboG/wyOE9bPOned60Qc3ZLuFQSX72orcRMBPQJ06Mz3RIbkyoz4yIf/dkPpT6BdIB1QBKIXARhtIIb69WCFythef0h1etQQGWgj3TVRJ6+7ydN1UT/5V2VxNnGQGPzEwwCQHH7b8JYqvbZEB6D9HbXTGcP5UYwBoyAwI6zjK2UWY9SHpB04OyBdRy0Ch0Z1SUk2LOg8DywabeI2uIpb6NV/wJrWlGmDbJ+i9A8kj454VBoycPmZMDEdwnjomjnl5iQ9ocJbC5SUxTKE9vgek0hbAUOTYETV/NOMiWMZAmRnl3GDHy14ztdlekg6fK fzccKwea kT3unM+KTeUnQrsMUvtS4qnRFczs7uX63a9+u+kRdnSgXGc479IctNAKOlelGYLjbyrg/gWX9tCA8/DxyWswBiTeWEhsG9c9Rq7FUvLVVrpbzJ0gqQwaaM9IMsP9u4wXFPeP99AYmFJqOyRgpkjXe1n79AscDd5PAkBaVuhp60fgKLpet4UIb5nTXYiJ9uHNiTkM0ewRUDGoxEdmpJ7HxuuZ8kQJ+TYmgrslFz21Eco/zIPjkBNkRnKpKJBkEWpqYU1RjI4nHtxEhrmLL+qFk9k1zP22EQIgUInjnf3yQOB4HF047fLpN4bIGN/hl3MVG1T3lWg9RLXpNM5+ZqEi3s0IMGp1CevyCdgKVGRH2VdQgf+yK08F1FJcjwA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.08.24 11:05, Ryan Roberts wrote: > On 09/08/2024 09:58, David Hildenbrand wrote: >> On 09.08.24 10:42, David Hildenbrand wrote: >>>>> Not sure I fully understand why David prefers to do the unaccounting at >>>>> free-time though? It feels unbalanced to me to increment when first mapped but >>>>> decrement when freed. Surely its safer to either use alloc/free or use first >>>>> map/last map? >>>>> >>>>> If using alloc/free isn't there a THP constructor/destructor that prepares the >>>>> deferred list? (My memory may be failing me). Could we use that? >>>> >>>> Additionally, if we wanted to extend (eventually) to track the number of shmem >>>> and file mthps in additional counters, could we also account using similar folio >>>> free-time hooks? If not, it might be an argument to account in rmap_unmap to be >>>> consistent for all? >>> >>> Again, see NR_FILE_THPS handling. No rmap over-complication please. >> >> ... not to mention that it is non-sensical to only count pageache folios that >> are mapped to user space ;) > > Yes, good point. I'll get back in my box. :) Well, it was a valuable discussion! anon folios in the swapcache are interesting: they are only "anon" after we first mapped them (harder to change, but would be possible by using a NULL mapping maybe, if really worth it; with memdesc that might turn out interesting). But once they are anon, they will stay anon until actually reclaimed -> freed. -- Cheers, David / dhildenb