From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47B4CC433F5 for ; Thu, 20 Jan 2022 12:23:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D97966B00A1; Thu, 20 Jan 2022 07:23:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D20F26B00A2; Thu, 20 Jan 2022 07:23:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC0D86B00A4; Thu, 20 Jan 2022 07:23:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0125.hostedemail.com [216.40.44.125]) by kanga.kvack.org (Postfix) with ESMTP id AD7EE6B00A1 for ; Thu, 20 Jan 2022 07:23:33 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7483F8F840 for ; Thu, 20 Jan 2022 12:23:33 +0000 (UTC) X-FDA: 79050581106.06.2CC5781 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf08.hostedemail.com (Postfix) with ESMTP id ADFEF160009 for ; Thu, 20 Jan 2022 12:23:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5A18A1F76B; Thu, 20 Jan 2022 12:23:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1642681411; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aAqWepW1sim3fFWmWCAhrRaH9v8z2bH1DSUyDF5D4cw=; b=Sc30tvY6t5HsQ1xrgT7MlE4INw7MuoZFcL007skkYzXOeq4sB5DTHl1k11FDdXBuajLdGO kRqh6CygtAd3DpqfDPJdhPFN3PZOnbGtiBFqtBAbJfSmEsgKMbJtdDsTU6kpIf8nQAbWqe rt6VGSHdZpcnR66qFikzWaDTipEom/k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1642681411; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aAqWepW1sim3fFWmWCAhrRaH9v8z2bH1DSUyDF5D4cw=; b=a4Vh9fhZuoEW1hXDZKhJO1MNIKklof6wLFwmn7G238WJOFH5esiE4fe6DwtAQSXaxk83LE /DR/XjO9fwZ9GxCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 19F5813E9E; Thu, 20 Jan 2022 12:23:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QKKIBUNU6WHnXAAAMHmgww (envelope-from ); Thu, 20 Jan 2022 12:23:31 +0000 Message-ID: Date: Thu, 20 Jan 2022 13:23:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4 57/66] mm/mprotect: Use maple tree navigation instead of vma linked list Content-Language: en-US To: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Cc: Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Rik van Riel , Peter Zijlstra , Michel Lespinasse , Jerome Glisse , Minchan Kim , Joel Fernandes , Rom Lemarchand References: <20211201142918.921493-1-Liam.Howlett@oracle.com> <20211201142918.921493-58-Liam.Howlett@oracle.com> From: Vlastimil Babka In-Reply-To: <20211201142918.921493-58-Liam.Howlett@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Sc30tvY6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=a4Vh9fhZ; dmarc=none; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Stat-Signature: wytpdeb8ndo9srkx37qgky4nywi6krgs X-Rspamd-Queue-Id: ADFEF160009 X-Rspamd-Server: rspam12 X-HE-Tag: 1642681412-925149 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/1/21 15:30, Liam Howlett wrote: > From: "Liam R. Howlett" > > Signed-off-by: Liam R. Howlett Acked-by: Vlastimil Babka > --- > mm/mprotect.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/mprotect.c b/mm/mprotect.c > index e552f5e0ccbd..7af58fd467c6 100644 > --- a/mm/mprotect.c > +++ b/mm/mprotect.c > @@ -528,6 +528,7 @@ static int do_mprotect_pkey(unsigned long start, size_t len, > const int grows = prot & (PROT_GROWSDOWN|PROT_GROWSUP); > const bool rier = (current->personality & READ_IMPLIES_EXEC) && > (prot & PROT_READ); > + MA_STATE(mas, ¤t->mm->mm_mt, start, start); > > start = untagged_addr(start); > > @@ -559,7 +560,7 @@ static int do_mprotect_pkey(unsigned long start, size_t len, > if ((pkey != -1) && !mm_pkey_is_allocated(current->mm, pkey)) > goto out; > > - vma = find_vma(current->mm, start); > + vma = mas_find(&mas, ULONG_MAX); > error = -ENOMEM; > if (!vma) > goto out; > @@ -585,7 +586,7 @@ static int do_mprotect_pkey(unsigned long start, size_t len, > if (start > vma->vm_start) > prev = vma; > else > - prev = vma->vm_prev; > + prev = mas_prev(&mas, 0); > > for (nstart = start ; ; ) { > unsigned long mask_off_old_flags; > @@ -647,7 +648,7 @@ static int do_mprotect_pkey(unsigned long start, size_t len, > if (nstart >= end) > goto out; > > - vma = prev->vm_next; > + vma = find_vma(current->mm, prev->vm_end); > if (!vma || vma->vm_start != nstart) { > error = -ENOMEM; > goto out;