From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C33F4C5AD49 for ; Mon, 2 Jun 2025 19:18:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D9CD6B0314; Mon, 2 Jun 2025 15:18:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B1356B0316; Mon, 2 Jun 2025 15:18:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4520F6B0317; Mon, 2 Jun 2025 15:18:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 282576B0314 for ; Mon, 2 Jun 2025 15:18:12 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D6F148111A for ; Mon, 2 Jun 2025 19:18:11 +0000 (UTC) X-FDA: 83511421182.17.37F8E52 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) by imf13.hostedemail.com (Postfix) with ESMTP id 221F320005 for ; Mon, 2 Jun 2025 19:18:09 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="vQO/FZZq"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of 38Pg9aAsKCCM9BJDQKDXSMFFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--ackerleytng.bounces.google.com designates 209.85.210.201 as permitted sender) smtp.mailfrom=38Pg9aAsKCCM9BJDQKDXSMFFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--ackerleytng.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748891890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gC27xGN+OZxYxd8x3HPELSRtz95EF1fMjoET+WlkV5U=; b=zNS0yihEPyv+OOchbfITyjugqr2k1rw3+aRxdY9n8DNtBnhl7Uui5K/fwc9stY6iVOEZ7i P2RynnHcPscWZbFpOUNC6okmsAmuB2cTACsfmMfmVnH8l8nXq4ZvHI+kseeXp3DUjXTw7f wgIde3eIJ5gbXyEpdDLfUNdxq5Rj99E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748891890; a=rsa-sha256; cv=none; b=nn2Tb3L3lBM+mRRpnRMKrjbJJLFTpeNsXt0SCVDZXE99TjHiRsN46J7hRBfCFBo5zJzt80 HdGLgjbav0iKQHbXXQ2WVkRoTYWdpPizPNqNzWnM7RNNkRrECmlidwZRN3gIoN4jFVHiPD 5mqqOfz8l7JWjkK6I/JhnAiIk+LRib0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="vQO/FZZq"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of 38Pg9aAsKCCM9BJDQKDXSMFFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--ackerleytng.bounces.google.com designates 209.85.210.201 as permitted sender) smtp.mailfrom=38Pg9aAsKCCM9BJDQKDXSMFFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--ackerleytng.bounces.google.com Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-7398d70abbfso6748063b3a.2 for ; Mon, 02 Jun 2025 12:18:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748891889; x=1749496689; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=gC27xGN+OZxYxd8x3HPELSRtz95EF1fMjoET+WlkV5U=; b=vQO/FZZqpAbyHMkKCRysZ9ON76UUTVmJTaFJcPpsAa4XEjfdAlChojo4PUdf4aLqEc Gew82JVM3ayWeizpvVosPJivq/IrZ7AnPmkZpc/ovoq1hfiJWVZSDPIcxtt2/bqaTKt5 vkNpMN9Ycm8D34kAwDXxFMHd1z5GoQOtXn67bUPtpLHp1nUX5A7aeEmphaB3ifEMrKd3 yNzVXWpXivtAENlPJrHs2FVVahzT2aXSWPjq7RKfk0RjcsLpY6aPEOrWgr0+DxuyoZm5 0HPL53XsmCVaYVCmQghwrSpTE/YLdfvzJNBlAo7WS8EwT06MdWdJ4pvepOdzjRBvAndV ZnHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748891889; x=1749496689; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gC27xGN+OZxYxd8x3HPELSRtz95EF1fMjoET+WlkV5U=; b=AjE5SkyIHlQP6G2hYUsdtPJEWtqG6SYoDD2AvIxAtCVg3x2ZhOUtmn6+Eety9cnOqu h1Jgo+kVCvj9NNs5IZ3fMrdymbRlrJIi0vpk0xJJ4HE1cuNlOYW+8vaQQJ4OvT8LCBpJ Je0+wlcTNxHsDsyHZjK7opQl5RZYSEZIu/uMZma3wqoeH7M1MnhL/O7EmlsaeZYIgyfU ugQZye0eiSf4pEGopcWbevvZ4pqEurw/n+1C8cmfGWE9quL75ASc059Yj5eKV/TG8MnF A5UzuNkne+CHMbsrDYn0jlNuSTn0ZsNsELYEMiPC1BfgLMLIqOEX5rKO224NV7l+RLsF BV1A== X-Forwarded-Encrypted: i=1; AJvYcCWI50erFxNUHxD+NzXoFPzvStSe7uqQwMvPCKvv88UizgCATBD0G5XW+u4IW2JS5i85aYkuXg+WrA==@kvack.org X-Gm-Message-State: AOJu0Yxo5j7g7oiqxAzEyvIdbsinKS76Rwz3Kv2eCV6vXnjUSSN7DebU fPEVYOE3KG4hVSHtXJzTIhYqgCYLRxhc9sjCcfneB2/BsLgW6eg+8njjMPQi8RS9Y+YkFLo7aTb FF2OsEpuQ9m6QX2Qr9ccwdeYe3A== X-Google-Smtp-Source: AGHT+IEZUo9EMXuhRCwoaNc5hwobX/60MfpH4lGs/P6VHbaKIkRHWpm212b2a7KnBe+VwVfAYZRtTQUZPJL+sgEDqQ== X-Received: from pfblu7.prod.google.com ([2002:a05:6a00:7487:b0:747:a97f:513f]) (user=ackerleytng job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:3cc5:b0:740:595a:f9bf with SMTP id d2e1a72fcca58-747bd9510fbmr21737179b3a.3.1748891888859; Mon, 02 Jun 2025 12:18:08 -0700 (PDT) Date: Mon, 2 Jun 2025 12:17:54 -0700 In-Reply-To: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.49.0.1204.g71687c7c1d-goog Message-ID: Subject: [PATCH 1/2] fs: Provide function that allocates a secure anonymous inode From: Ackerley Tng To: kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-fsdevel@vger.kernel.org Cc: ackerleytng@google.com, aik@amd.com, ajones@ventanamicro.com, akpm@linux-foundation.org, amoorthy@google.com, anthony.yznaga@oracle.com, anup@brainfault.org, aou@eecs.berkeley.edu, bfoster@redhat.com, binbin.wu@linux.intel.com, brauner@kernel.org, catalin.marinas@arm.com, chao.p.peng@intel.com, chenhuacai@kernel.org, dave.hansen@intel.com, david@redhat.com, dmatlack@google.com, dwmw@amazon.co.uk, erdemaktas@google.com, fan.du@intel.com, fvdl@google.com, graf@amazon.com, haibo1.xu@intel.com, hch@infradead.org, hughd@google.com, ira.weiny@intel.com, isaku.yamahata@intel.com, jack@suse.cz, james.morse@arm.com, jarkko@kernel.org, jgg@ziepe.ca, jgowans@amazon.com, jhubbard@nvidia.com, jroedel@suse.de, jthoughton@google.com, jun.miao@intel.com, kai.huang@intel.com, keirf@google.com, kent.overstreet@linux.dev, kirill.shutemov@intel.com, liam.merwick@oracle.com, maciej.wieczor-retman@intel.com, mail@maciej.szmigiero.name, maz@kernel.org, mic@digikod.net, michael.roth@amd.com, mpe@ellerman.id.au, muchun.song@linux.dev, nikunj@amd.com, nsaenz@amazon.es, oliver.upton@linux.dev, palmer@dabbelt.com, pankaj.gupta@amd.com, paul.walmsley@sifive.com, pbonzini@redhat.com, pdurrant@amazon.co.uk, peterx@redhat.com, pgonda@google.com, pvorel@suse.cz, qperret@google.com, quic_cvanscha@quicinc.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, quic_svaddagi@quicinc.com, quic_tsoni@quicinc.com, richard.weiyang@gmail.com, rick.p.edgecombe@intel.com, rientjes@google.com, roypat@amazon.co.uk, rppt@kernel.org, seanjc@google.com, shuah@kernel.org, steven.price@arm.com, steven.sistare@oracle.com, suzuki.poulose@arm.com, tabba@google.com, thomas.lendacky@amd.com, vannapurve@google.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, vkuznets@redhat.com, wei.w.wang@intel.com, will@kernel.org, willy@infradead.org, xiaoyao.li@intel.com, yan.y.zhao@intel.com, yilun.xu@intel.com, yuzenghui@huawei.com, zhiquan1.li@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 221F320005 X-Stat-Signature: g3mg13tff5id7mtej7pnomdbz1ta3uen X-Rspam-User: X-HE-Tag: 1748891889-575086 X-HE-Meta: U2FsdGVkX18AGihAvbRy/kf+tN4x1XSsF0zixydULwpYVjtZbmFs0aH13XoL3aGnI12+mMEWdtNp6DLsHnXZYxtDfhfJ/03uRu0V8Pp6s7y41XKxH800nj3/j6sK6PNRWVKgRqNUrhIND3B7kwNu+t6QZMKpxtq+3slH52Xi4YJaawgjzpuBCKDZB0ojpmHdBk1KL0Qw/jE3/0PpT0cQCibfC8QD5Eyqej3nHYqdDY3xwnHV+2Hp8GKXs9z9SH8YgouRYt7s9Ji6K/8Z0dtTef22W1xHI5jBt4nEXc4KYeJ0kXXN5XRX/BdFUj87bgYMJo2YLWeaL5sfqNVIneSU5fTTC5W3T1FtHc2+AsM1olzim4/oSF/LAgtXFkxYpAi+eXtPkDm93RXthKjhdSusi1Wt3q49r7JRLvx6+QpPhaJMV+W/VrXI1/RTogyjF4JJHkzUO7cLQFisVVvAavZ2rr+oFrfclq0QpWoxzbmEvpHP/SjF770yaUlBTpxnSpD1Hx3nTk3gECxlCyiuqHhZw5cogdiN3Uz54d4xiK1n+RW6AlIPtqexNdxePenV+AYm3GI8cCdsbU0VRe06AF1Xbd868rMxgo066bOfFklSHo9QCOVPixFIpeLDyV6ns6QFAiXUDUJbbAafff45HumJdGDnCnno/el7uKxqmDPXG5uDVlZdtnBx17DrcVeQsq79CLJMuXBZQ4hh8SlcUQupTV//n9E43G+BA9FhVwiVGspPYJSaoWEJqMtTzSiKE6AkWWwp+WSflGkn+SEh3FrD5/k7I0GC2GAlm/X5YSrJtVuO3VKQk54Uz15kvWFz7xIYAzRG08JdYqJUOkM/5D0MtiJQy1pLV89hpq88cHa72jAzUVjJONBZxzW8l7J99GO7V+UnVV4lWchuFQ6pUQvINsfpXJDNpRW2YbP5Ml8uXqVsOWLnJmWwhTvd6XVPHXVoJcsW8dU80HgDg+mygt/ vTQgvUOr UM5ibIUz4IHSduNkFJo/6tSkMyCTn6tS3iDGt1fKJECQ+6vzwzSer62utLVgEp79NhhO2cFD5lIqdaEqz3ifYfO1sscgAPZC2jl9g5z7hgiiSqxx9JtaiiDnWrUjKpXIvfU+owdZ8BnRjL7vAUFSG790G0ldmZNeZnBVYvCMOkLuxWpNce0kZR/7GYOCC1iYFPiFcG3GxfaFSDZThg+8IP1EPpf1ypqzi7PhSl5Q3SI7L9lEkG5oX+QEQdQ4kVYylC8x0HC6uzuqWk0E5KrmnDf8ltGAkUh201YgsSYflctJWOOa6r96+nqdVIaDy1XqpDR3boLm4Ob+5py5h904PjqI41UMal2eqaYLPvHQmuWm6f1BSXTXTYMBXmus0KaEGOVWD/JXe405u64sXvXRf/o8HYgFkOSzUNHYlt+UP3lUmU1tp05EEQGrZhvJ8iYHdeVSIW0IOabbFnpZKlK5HCcdMIBCbwevNXeWeWjSdDv/wIilVmYQeTxPNVCzEVpTYrOAmjuM5qbMazf4PA0aFrunxUVTzJ1rD5Jz6ataYveekMXcnS/T81T78nOX0qPxI9wYezB0PeWnZKtqKHgNtp3buvA8VDgCfi+yXCDamJ5vDbMJh/PqBnnsLclqxfG69GZX1U4fjuvMOG9SbzSxvDQOoQmAdL3vCl9ycUYu1i/MOIUs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The new function, alloc_anon_secure_inode(), returns an inode after running checks in security_inode_init_security_anon(). Also refactor secretmem's file creation process to use the new function. Suggested-by: David Hildenbrand Signed-off-by: Ackerley Tng --- fs/anon_inodes.c | 22 ++++++++++++++++------ include/linux/fs.h | 1 + mm/secretmem.c | 9 +-------- 3 files changed, 18 insertions(+), 14 deletions(-) diff --git a/fs/anon_inodes.c b/fs/anon_inodes.c index 583ac81669c2..4c3110378647 100644 --- a/fs/anon_inodes.c +++ b/fs/anon_inodes.c @@ -55,17 +55,20 @@ static struct file_system_type anon_inode_fs_type = { .kill_sb = kill_anon_super, }; -static struct inode *anon_inode_make_secure_inode( - const char *name, - const struct inode *context_inode) +static struct inode *anon_inode_make_secure_inode(struct super_block *s, + const char *name, const struct inode *context_inode, + bool fs_internal) { struct inode *inode; int error; - inode = alloc_anon_inode(anon_inode_mnt->mnt_sb); + inode = alloc_anon_inode(s); if (IS_ERR(inode)) return inode; - inode->i_flags &= ~S_PRIVATE; + + if (!fs_internal) + inode->i_flags &= ~S_PRIVATE; + error = security_inode_init_security_anon(inode, &QSTR(name), context_inode); if (error) { @@ -75,6 +78,12 @@ static struct inode *anon_inode_make_secure_inode( return inode; } +struct inode *alloc_anon_secure_inode(struct super_block *s, const char *name) +{ + return anon_inode_make_secure_inode(s, name, NULL, true); +} +EXPORT_SYMBOL_GPL(alloc_anon_secure_inode); + static struct file *__anon_inode_getfile(const char *name, const struct file_operations *fops, void *priv, int flags, @@ -88,7 +97,8 @@ static struct file *__anon_inode_getfile(const char *name, return ERR_PTR(-ENOENT); if (make_inode) { - inode = anon_inode_make_secure_inode(name, context_inode); + inode = anon_inode_make_secure_inode(anon_inode_mnt->mnt_sb, + name, context_inode, false); if (IS_ERR(inode)) { file = ERR_CAST(inode); goto err; diff --git a/include/linux/fs.h b/include/linux/fs.h index 016b0fe1536e..0fded2e3c661 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -3550,6 +3550,7 @@ extern int simple_write_begin(struct file *file, struct address_space *mapping, extern const struct address_space_operations ram_aops; extern int always_delete_dentry(const struct dentry *); extern struct inode *alloc_anon_inode(struct super_block *); +extern struct inode *alloc_anon_secure_inode(struct super_block *, const char *); extern int simple_nosetlease(struct file *, int, struct file_lease **, void **); extern const struct dentry_operations simple_dentry_operations; diff --git a/mm/secretmem.c b/mm/secretmem.c index 1b0a214ee558..c0e459e58cb6 100644 --- a/mm/secretmem.c +++ b/mm/secretmem.c @@ -195,18 +195,11 @@ static struct file *secretmem_file_create(unsigned long flags) struct file *file; struct inode *inode; const char *anon_name = "[secretmem]"; - int err; - inode = alloc_anon_inode(secretmem_mnt->mnt_sb); + inode = alloc_anon_secure_inode(secretmem_mnt->mnt_sb, anon_name); if (IS_ERR(inode)) return ERR_CAST(inode); - err = security_inode_init_security_anon(inode, &QSTR(anon_name), NULL); - if (err) { - file = ERR_PTR(err); - goto err_free_inode; - } - file = alloc_file_pseudo(inode, secretmem_mnt, "secretmem", O_RDWR, &secretmem_fops); if (IS_ERR(file)) -- 2.49.0.1204.g71687c7c1d-goog