From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4386C35FF1 for ; Wed, 19 Mar 2025 06:27:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D518280003; Wed, 19 Mar 2025 02:27:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 783A0280001; Wed, 19 Mar 2025 02:27:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64BDA280003; Wed, 19 Mar 2025 02:27:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 48065280001 for ; Wed, 19 Mar 2025 02:27:57 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AD9B381A59 for ; Wed, 19 Mar 2025 06:27:58 +0000 (UTC) X-FDA: 83237320236.19.EFE20E5 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf29.hostedemail.com (Postfix) with ESMTP id 836CE120006 for ; Wed, 19 Mar 2025 06:27:55 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf29.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742365676; a=rsa-sha256; cv=none; b=4kVVbi7EHixO0H6i6UoLShjq8wGidpcOcpnye9rMDiJW+/515JUx4OZa9OyNPDB2QPJpMK XKDX91glleVtq1ZtI7RqlnQahUG1Z3rEwqNZ+J1q5pKOGokr6w4AY21kp98Lhsi5HG6eyv h8A3kRMskvfYr33aaMF+PszCICe+Huw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf29.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742365676; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fGFibTXr/Zi7Dt7d1CZRQuFeIqeyXgBREFCeA4xD/m8=; b=jMfu4441/4sTN8FnP0iMlTUQawqUJjuUPqFD4wg8dec91GBcji2iHODKWZ/XxDpl12Gzt/ OhQh/U0tgEv+5J6vT+d82+EVCvbINGJEsAeNd/DPYu1XusT8znBjXedRLyMG8wEeOgFS9A gt7Nr+MyqEByzspU/Ekmmoek669GeB4= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B499712FC; Tue, 18 Mar 2025 23:28:02 -0700 (PDT) Received: from [10.162.16.153] (a077893.blr.arm.com [10.162.16.153]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BC4133F694; Tue, 18 Mar 2025 23:27:52 -0700 (PDT) Message-ID: Date: Wed, 19 Mar 2025 11:57:49 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/hugetlb: move hugetlb_sysctl_init() to the __init section To: marc.herbert@linux.intel.com Cc: Muchun Song , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250319060041.2737320-1-marc.herbert@linux.intel.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250319060041.2737320-1-marc.herbert@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 836CE120006 X-Rspamd-Server: rspam05 X-Stat-Signature: n5fqcjdjyepmwa1zi7hnpz4bnpi6mtex X-HE-Tag: 1742365675-903985 X-HE-Meta: U2FsdGVkX180YA7AVutmekmEeX2q/gtFWmUDGv0tEtDPIouMNdKxHsrct0O28HnzDU5CoGiKVTw0GKpZtCQVz3EG4VVAjaXaAORvBwt4EU+Bnih0GCTiaAgku2xMa741D0R4oD6pSi2A5HgFeHlgheTBCKVI02lU/ynKUcO8BnRmX3xZh531LTq+4AZBJhGmRpC+kIUnWOGhri4OmQbpecvGnlqQxp8g2r/NWwmokScFQlNi+/3lhqBk/wYSY2hWUqBFmVkgXvf3QJv95yE1Ll2yMql4yVN2OdQ5Jij2U+nKBq+wMgoLfIFAm56cZGbigHKqYLpDmu/jBh/w7aBa57lBN+HqoxJ4DmLtAu8HgNrMOPZ2fGOzGbJMdZHEJkxdethfR2gcP6Qc/1DXL19wzuGJy7q49UXxhFU4khH6g9ZJ4I9fCwjtcBgMlq/ADMjsSNeupTO7RYIHvicfQvyGP9ZHm/rEOCsHvoprqx78zS66Et+mVakS05iFwJNgiTu+I7XS2FzxnDtbW1020CRvdUVKOHDltdBQ6jOi9utyX8/frUJmFh0u5RlbfsqzgDcsxs0F8sWqq29VgMzB5dh+N0Zn9pRxsv4CxbtFLzg4se42NGf0Soxn3V8cti7JIfv1+FOSkAcyyUoob+Wv+nU58MIBB7iz5KuTSH/ouYr/A7TR3beBmMBBKORoCiax52mPDD3KyLWGovrc1XXcFMict/cXtdYkU3a4KuA6Z8zP/19J/iy6PNcgS1NuX9zufBcXJAOnEMeOnmpu1e56CzwYqNXt89aIOSzWwke7jy0brp3IC7cCjoobiWN7iWhAyaEo+E2fTPNpc5h/8Ie1bY5Ys4JBI3YEM5RYD/cEgWsJmzeunPdE6vouEcZ7zOHYIYBgID0vAeEeY3FMBH/Bq428cepf4FCDrhvJyGlaOGZA+MSV6C95LH3KCKvFY+iixe5LEYSyIkQC9T8k49h1JpU vjmbr49N phbRn9zmEsLdVv+/7DY8mquTpmrNffX4xAsgByoYO7FN+I5OBqBuH5LPejhUH6eXX2MHDaiS1HLJdkMLiEFeEtD76EGCi8Dp7b3ERLeMtE2EIIL9QAmxUJH/vj8SA8Aik2yRt93hkHgRxonYK5WHh+HrrnvR1LbfmZyNFf/ESaQ6R+8EO4+H86XkgjBI7dIZq1ceREnoNHXBjp2z9BNVoQPK11e5iZ3gDxpdNgXxTgLyaeUamVrXLqjZWznFHnxLIQbNtRxtQq7a4Sa4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/19/25 11:30, marc.herbert@linux.intel.com wrote: > From: Marc Herbert > > hugetlb_sysctl_init() is only invoked once by an __init function and is > merely a wrapper around another __init function so there is not reason > to keep it. > > Fixes the following warning when toning down some GCC inline options: > > WARNING: modpost: vmlinux: section mismatch in reference: > hugetlb_sysctl_init+0x1b (section: .text) -> > __register_sysctl_init (section: .init.text) > > Signed-off-by: Marc Herbert > --- > mm/hugetlb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 65068671e460..a2850b26aed9 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -4900,7 +4900,7 @@ static const struct ctl_table hugetlb_table[] = { > }, > }; > > -static void hugetlb_sysctl_init(void) > +static void __init hugetlb_sysctl_init(void) > { > register_sysctl_init("vm", hugetlb_table); > } LGTM Reviewed-by: Anshuman Khandual