From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59A3EC4332F for ; Sun, 6 Nov 2022 18:04:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 680D780008; Sun, 6 Nov 2022 13:04:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 630D980007; Sun, 6 Nov 2022 13:04:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51F7F80008; Sun, 6 Nov 2022 13:04:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 42EBB80007 for ; Sun, 6 Nov 2022 13:04:38 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A7E8AC05FA for ; Sun, 6 Nov 2022 18:04:37 +0000 (UTC) X-FDA: 80103792594.21.42ADDF6 Received: from relay.hostedemail.com (unirelay03 [10.200.18.66]) by imf01.hostedemail.com (Postfix) with ESMTP id BBDF440002 for ; Sun, 6 Nov 2022 18:04:35 +0000 (UTC) Received: from omf18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 224DBA01AD; Sun, 6 Nov 2022 18:04:33 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf18.hostedemail.com (Postfix) with ESMTPA id 76E7230; Sun, 6 Nov 2022 18:04:06 +0000 (UTC) Message-ID: Subject: Re: [RFC v2 3/3] mm, printk: introduce new format %pGt for page_type From: Joe Perches To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org Cc: Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Vlastimil Babka , Naoya Horiguchi , Miaohe Lin , Matthew Wilcox , Minchan Kim , Mel Gorman , Andrea Arcangeli , Dan Williams , Hugh Dickins , Muchun Song , David Hildenbrand , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 06 Nov 2022 10:04:25 -0800 In-Reply-To: <20221106140355.294845-4-42.hyeyoo@gmail.com> References: <20221106140355.294845-1-42.hyeyoo@gmail.com> <20221106140355.294845-4-42.hyeyoo@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/TDiNWGzwXgd/sBaXkZIB0ArMrI/YeeY0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667757875; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9P8GQkK7vjFwd63Zt+F7BJPAgpplqqLENI81jFyd5/g=; b=JIUFOGDF7/hPn1s6PROz+SGGMdCuvWqPMyXDcmoIAeGhdE5VvSW1tqgH4YU+ybzY2J9TW7 5mnMW9HgLR6BhpHL+Hi2Poc/rlh/tcf9L1H/s7NgUzHopdHgI8HEeau6APT2FDmGVbT5Ls jsbal91f+2Q0XvWV8XX0YkF+IXFNnyc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667757875; a=rsa-sha256; cv=none; b=JnmQzXGg9268248YcvYqhCFhLpA6Q+Nc8J+z/yd/Ww8J7LhXt+/oI5S5WHSJ3KTmoD4uRk MKiHWVVyiG+DyBdMaVlPUUKl62cm3geUHWLY9KA6IJwqBVPzld/1XtFAfQBOhxFluyvh4u yjsHIIDQkhantf4sFMlwZ5AawlbAzRE= X-Rspamd-Queue-Id: BBDF440002 X-Rspam-User: X-HE-Tag-Orig: 1667757846-282636 X-Rspamd-Server: rspam08 Authentication-Results: imf01.hostedemail.com; none X-Stat-Signature: btrbetsb33g9g991fgia9znt4oaqtubf X-HE-Tag: 1667757875-180100 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 2022-11-06 at 23:03 +0900, Hyeonggon Yoo wrote: > dump_page() uses %pGp format to print 'flags' field of struct page. > As some page flags (e.g. PG_buddy, see page-flags.h for more details) > are set in page_type field, introduce %pGt format which provides > human readable output of page_type. And use it in dump_page(). [] > diff --git a/lib/vsprintf.c b/lib/vsprintf.c [] > @@ -2056,6 +2056,28 @@ char *format_page_flags(char *buf, char *end, unsi= gned long flags) > return buf; > } > =20 > +static noinline_for_stack ? > +char *format_page_type(char *buf, char *end, unsigned int page_type) > +{ > + if (!(page_type & PAGE_TYPE_BASE)) > + return string(buf, end, "no type for user-mapped page", default_str_sp= ec); Might be better with something like '%pGt: no type..."