From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9662DC3F2D1 for ; Wed, 4 Mar 2020 06:49:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 562C5215A4 for ; Wed, 4 Mar 2020 06:49:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="TjnV6xMQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 562C5215A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 03C896B0003; Wed, 4 Mar 2020 01:49:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 012CA6B0005; Wed, 4 Mar 2020 01:49:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E92C86B0006; Wed, 4 Mar 2020 01:49:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217]) by kanga.kvack.org (Postfix) with ESMTP id D03D16B0003 for ; Wed, 4 Mar 2020 01:49:05 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id AD4C8AF78 for ; Wed, 4 Mar 2020 06:49:05 +0000 (UTC) X-FDA: 76556752650.11.hate41_4f3ce7db7e35e X-HE-Tag: hate41_4f3ce7db7e35e X-Filterd-Recvd-Size: 4994 Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Mar 2020 06:49:04 +0000 (UTC) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 48XPcF5vVkz9v0st; Wed, 4 Mar 2020 07:49:01 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=TjnV6xMQ; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id dW39OVxTZgd8; Wed, 4 Mar 2020 07:49:01 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 48XPcF4ZcKz9v0ss; Wed, 4 Mar 2020 07:49:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1583304541; bh=wrQNL9rvesEDlWoNS4tGcfPvGhYnLZNAbgZHq9fGbnE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=TjnV6xMQKz2IO1bGDE4HAZJMFDjYTtnjTtNNjZEsh1GJH/DNUiegOPbfzQzRdUJdq mfbcsqR6vxFcKaMgtar20QBjEJl5cDZGZqEWM5VabMwt/qfmG0b/5ARzKJJU0pQlpP HX98Thi1AQonukArlC4ShOrxhDCLgoABIqbXgKFo= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 784788B826; Wed, 4 Mar 2020 07:49:02 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id oPUcSMTN_Vcy; Wed, 4 Mar 2020 07:49:02 +0100 (CET) Received: from [172.25.230.100] (po15451.idsi0.si.c-s.fr [172.25.230.100]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 2A1098B820; Wed, 4 Mar 2020 07:49:02 +0100 (CET) Subject: Re: [PATCH V14] mm/debug: Add tests validating architecture page table helpers To: Qian Cai , Anshuman Khandual Cc: Linux Memory Management List , Andrew Morton , Mike Rapoport , Vineet Gupta , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "Kirill A . Shutemov" , Paul Walmsley , Palmer Dabbelt , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev , linux-s390@vger.kernel.org, linux-riscv@lists.infradead.org, the arch/x86 maintainers , linux-arch@vger.kernel.org, LKML , "Aneesh Kumar K.V" References: <1581909460-19148-1-git-send-email-anshuman.khandual@arm.com> <1582726182.7365.123.camel@lca.pw> <7c707b7f-ce3d-993b-8042-44fdc1ed28bf@c-s.fr> <1582732318.7365.129.camel@lca.pw> <1583178042.7365.146.camel@lca.pw> <12260F9A-695D-40F8-932F-61D86D77D441@lca.pw> From: Christophe Leroy Message-ID: Date: Wed, 4 Mar 2020 07:48:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <12260F9A-695D-40F8-932F-61D86D77D441@lca.pw> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 04/03/2020 =C3=A0 02:39, Qian Cai a =C3=A9crit=C2=A0: >=20 >> Below is slightly modified version of your change above and should sti= ll >> prevent the bug on powerpc. Will it be possible for you to re-test thi= s >> ? Once confirmed, will send a patch enabling this test on powerpc64 >> keeping your authorship. Thank you. >=20 > This works fine on radix MMU but I decided to go a bit future to test h= ash > MMU. The kernel will stuck here below. I did confirm that pte_alloc_map= _lock() > was successful, so I don=E2=80=99t understand hash MMU well enough to t= ell why > it could still take an interrupt at pte_clear_tests() even before we ca= lls > pte_unmap_unlock()? AFAIU, you are not taking an interrupt here. You are stuck in the=20 pte_update(), most likely due to nested locks. Try with LOCKDEP ? Christophe >=20 > [ 33.881515][ T1] ok 8 - property-entry > [ 33.883653][ T1] debug_vm_pgtable: debug_vm_pgtable: Validating > architecture page table helpers > [ 60.418885][ C8] watchdog: BUG: soft lockup - CPU#8 stuck for 23s= ! > [swapper/0:1]