From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 680EEC83F1B for ; Thu, 17 Jul 2025 08:27:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AC9A8D0003; Thu, 17 Jul 2025 04:27:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 084AF8D0001; Thu, 17 Jul 2025 04:27:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8E5F8D0003; Thu, 17 Jul 2025 04:27:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D5DA28D0001 for ; Thu, 17 Jul 2025 04:27:46 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 638601DA92F for ; Thu, 17 Jul 2025 08:27:46 +0000 (UTC) X-FDA: 83673078132.21.E896421 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 030B820002 for ; Thu, 17 Jul 2025 08:27:43 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NntHrveg; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752740864; a=rsa-sha256; cv=none; b=L7iYng3yzyHpFyk+TfAibhwyE76Q0yhrYUA0SoR38aBejTvyLvwkOyRDtxrpr8ySZujNvt ZsbLzZH8Uk2ktAqB69TYf2dcJo154pjDVgjv0NxWGNurhGNINo6kerouMH5XifYzjkMOdj i3LttMgmTviFoCI8dUFQrMfBHjiNCDo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NntHrveg; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752740864; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fMxBTbmTm+nsAm9ulfXMiVPt2oVkhzxG1TkZvroTfME=; b=R3swbycSWL15q9bJdS8jacfaMQWqnjePI6sGNjZuLDqZOGO0gQxqgnunhnn8/MXleItA1O aLfSvGVunWr7TJ4X6o4BkU7sBMNZS8KGfBJ/NPBPaU0GCOMvdqKzaBGON7Ej5AaVq5jZAF myTS1qPq+p5RQeK9BVmriCDkbXdPL9A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752740863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fMxBTbmTm+nsAm9ulfXMiVPt2oVkhzxG1TkZvroTfME=; b=NntHrvegWgYdXs8W8eTzj6FZ29vPav143wfIHGVxtWWOCsVXTd3eb2Ehz9oJTUkeh0ADqj iHIXC/ceGuE8gqQfbt2ZRvj7BnkLtJQs5A1gCDHYUHL7+q3KZY2ke3qv1bhSt/+9yCCrgd 5rgw0FpfMkxCUftMcY4HphcwZyTlL1g= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-Kj3Dt8T4MUGmO0aWyepDsg-1; Thu, 17 Jul 2025 04:27:41 -0400 X-MC-Unique: Kj3Dt8T4MUGmO0aWyepDsg-1 X-Mimecast-MFC-AGG-ID: Kj3Dt8T4MUGmO0aWyepDsg_1752740860 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3b39cc43f15so319037f8f.2 for ; Thu, 17 Jul 2025 01:27:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752740860; x=1753345660; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=fMxBTbmTm+nsAm9ulfXMiVPt2oVkhzxG1TkZvroTfME=; b=ZK31+wIP9Jo9hwReLUmYjlXjWdYKfF17cj1aZgLiFgCYVH28tX9ZJFJ4xvNqtY5SUj ZlPPGwoOQqHG3r/KuWDH2F49AZwGmq08KGnWykckKeBLqEuvtR/QAJl/23dtD/QlhM9i BR+tyutKnju4Tf1xSOY8jM4oMjzfVEqJw6TorhIPmEdYQRAhKds5st7DhFXyELRDwe0q tHZEpzCQO/37Jm5xPSYc76ClmGpQs6e8BxUM9sSmAFsyXvvI3TGUmwJGlgDXrQoQRZ8X 9NYxDaWS/WchS1d0XjY73Jg0pN+Ogq/J0l7GzvKJD7SHUBlpWnhSTejOIBne1hgi0ae9 8YHQ== X-Forwarded-Encrypted: i=1; AJvYcCVJE3HX1Rnchi80ADnldDr9PmBaxkhL7ghgR6s5MeYwCZQ/a5WTLiMawLuFblSjWqTCj8j4FESP0w==@kvack.org X-Gm-Message-State: AOJu0YzPCK50tol9TMFVtlJdVeKmTFO8IbidTDJfvrtBIRAjHh0QQVvR /tABxuev7nr/lLNBxF9Cz9lMZk8pfnTZHeC0gUBj3/GtYoR7Y3EhSD9LxyhqPlogvH+9ZV3a5T7 I/ehGJ3HQuQDP5I0x8l5cYVXXa5gixaI0NAxnlGrqlX8Nr7UM1R9X X-Gm-Gg: ASbGncsSXUt96m1nEtd74kyvHzE7lrKRw/QyKgnAL3o0nu4WxolphEJM9Z8cZYVfxIy Jhwnc5kIelc4A6tIGk7BaZG76U00WbG6NJCZuMy/NrpqIg3cqyvGwj6NVr/i97HOwdFOLJxhYdp I7BrO1GRSnm8GD4ozD1TPCRfWcyjZKFy+OMBbGUiHN2NHH9Jv7LlopeCtVwYZX0d7H8W9dhLprP A4CzD1fGEscYEq7U2hzf/AuqF/Eb+PTcDq2NxfJzlydmhbMscdClv8ISR8kVSNe6iKHR6ZnOjTY MYMOBLB5GQfBlrRIFEtu8gh/Aim53KSX1foaBhp57BDyZGlv8++aEw15pqIoa463bouoVI1kqpU ZRmgXxxFrT710Fqh+9bCgqF0cgkfpIPZ/7buihE68q3ufbKgQw3kjBwrlnO6hEggC X-Received: by 2002:a05:6000:658:b0:3b6:13a1:8861 with SMTP id ffacd0b85a97d-3b613a188a1mr1658874f8f.38.1752740860498; Thu, 17 Jul 2025 01:27:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFEZnkSQyPg0S420Ez5uONkNV9NvN0V8gkmQOMk6tZMiMZJlca+eGjM58U18YY1iu/yF9s2Kw== X-Received: by 2002:a05:6000:658:b0:3b6:13a1:8861 with SMTP id ffacd0b85a97d-3b613a188a1mr1658849f8f.38.1752740860118; Thu, 17 Jul 2025 01:27:40 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1f:3600:dc8:26ee:9aa9:fdc7? (p200300d82f1f36000dc826ee9aa9fdc7.dip0.t-ipconnect.de. [2003:d8:2f1f:3600:dc8:26ee:9aa9:fdc7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4562e8ab642sm42968125e9.36.2025.07.17.01.27.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jul 2025 01:27:39 -0700 (PDT) Message-ID: Date: Thu, 17 Jul 2025 10:27:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] selftests/mm: check a valid fd with negative value To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, Lorenzo Stoakes , Rik van Riel , "Liam R . Howlett" , Vlastimil Babka , Harry Yoo References: <20250716082710.2801-1-richard.weiyang@gmail.com> <20250716082710.2801-2-richard.weiyang@gmail.com> <20250717011829.yhzeq32f4pgzrfmj@master> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <20250717011829.yhzeq32f4pgzrfmj@master> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Z7JsJzT_UE6mrgiDJiHArFSkTUJny826EbBryezW0oA_1752740860 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 030B820002 X-Stat-Signature: rqg6o7gbkhs93gxsqbkzr691kqkofchx X-Rspam-User: X-HE-Tag: 1752740863-161777 X-HE-Meta: U2FsdGVkX18Jhv45TT5bItRG74Nq7ZZZVKeDv/ors68jl2bwp//5ufV710Mko6Of7EV4m83yvP7xIRSXBZ39RX1xwpjwtu6fzRgShcpwKECeY5WkmHRN1yLej5XdTuRvcBnZz3or8l9gBP3qmGS+kFr2Xyi0z9TLlMzeXNgYpY9xcpE/I4VmsOsbwIbqsRtYSkRY7sihwVV9CKjQ0fKLDYGraxBTo6xUQhNS217T+xT6gqQ4DekQaYI+7ctrJmZtBFXMRURLEUmZ38fillGqvq47tOf1IcmkQbiBx0GLaHfsz/n7LiMeo8mulV/u3jpiizl/047d6kIIhmEgKuiNS55ojafxdfkEcj6jaWtsTqRvTBojMR1vguozj4pmiZ0kpMqjj0MDlyconJWUGtihOKKZgzbLNeuc8MJYeF3zwaLarN1ji72Gt6MabFef4tjKtF7PgCzPwA7MN89DLG6xZTm7SOqFULnUjtmF9ybRQDurkrH+aN/nzwUYFWLJciipBmmWy7BK2gp/5ouXxAjqhAiYmEvsF9MYfw0QZWkJ1FxVDdeRh+91ctPlsjfyiKwtvZ7WWHjX4CFfCitJqH5HGycIKPFC154ITfbUk93NPzsZr1WjBdXZ9lhF2tkqOWGlqdRsxrJfUmKa3m9hwQncdxZtExlmw2JJfLaiQVPaPbDdDI3XbHaMvdp5l1CYxTfBpkdgwMuZ1KBbATvtEfaSt54mYJNBGh7F6nKvfsegDLz5VfQvjUhwqY2KqgfYiEyhCaHGiCoK40SNjleBCvZVsAUmsp5MjiggIV8kUo5jTKJORP/pwApfARpuoin7zi6TARMrdU7SUZx0xZDWYeoDPYhxnfSIJMxuOPHDcsn69FgAf3ni/J33+hlNJakIJ3eCbcEA6KA+vSUkigjHgOMaVhAaU2N5BFQhYQuUYXPj5nAwfJ4ay/3yfgF65WlFkV2vAL3VIZpybfyW1ITMY2l bb5DIe7B w8eeypPnU1ppxn8laGTd+ZFc2O5a2USdOIKSnokmqhUnrnjHDrn801Ggw0SYpe04a63DGAq7olpGLdvzEB0T4xjhF/lHROPzfNqXk2FTRHLTOIk2LCqochLuLjEbUAdl0cNtG4PzqnAjFrCl8yjyyNbgkVrRisPiL6kpmFk9HmWXvPaTbML3zLTTndGTiZ+B9C3Oi0jVvr6Ym1akk22SD4Dd2sPu5sNtX9nJ41xnLZrp8UfgEoVP8+wIcyAR2tJIGzc/LksdZRbWPNmCVHmp6+fxvoWpQMLQCPNsvcEmc52cKAE7Q0RhZrjDT4QI8cUdJU9Akqph0lOjn7Hduy9pytf77haSb6Q60wUYNSovVBjPci4Iy3nPB/nwBlXVJQFoPYrfC+cbtaaV7Ox7btw9a1BADsy2wm/3TqLyZ8oXJLew55Qdd4c19zDgmRYNZ452+pF4jh5Zkdfoi5ZZsAtXSWrQVQ0RQ4U5baVDhxXX8JIMZs0XqhVOtFT7bkBz7rSK/xRYrliwV6N6cfTT7SjOYvTyauW2UQvgOhT2TvfD1hdciCf2ZHe+ZXVihav8jOKPfzPncgv1rrq8FvWan4q6o9w2+LlZCzeddGZ8t4K5APFfcWVBPFfS1daVtSA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.07.25 03:18, Wei Yang wrote: > On Wed, Jul 16, 2025 at 10:52:21AM +0200, David Hildenbrand wrote: >> On 16.07.25 10:27, Wei Yang wrote: >>> fd 0 is usually occupied by stdin, which is not expected to be returned >>> by open(). But 0 is still a valid fd. >>> >>> Check the valid fd with negative value like other places. >>> >>> Signed-off-by: Wei Yang >>> Cc: David Hildenbrand >>> Cc: Lorenzo Stoakes >>> Cc: Rik van Riel >>> Cc: Liam R. Howlett >>> Cc: Vlastimil Babka >>> Cc: Harry Yoo >>> --- >>> tools/testing/selftests/mm/ksm_functional_tests.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/mm/ksm_functional_tests.c b/tools/testing/selftests/mm/ksm_functional_tests.c >>> index d8bd1911dfc0..6da5c3340e10 100644 >>> --- a/tools/testing/selftests/mm/ksm_functional_tests.c >>> +++ b/tools/testing/selftests/mm/ksm_functional_tests.c >>> @@ -81,7 +81,7 @@ static long get_my_ksm_zero_pages(void) >>> ssize_t read_size; >>> unsigned long my_ksm_zero_pages; >>> - if (!proc_self_ksm_stat_fd) >>> + if (proc_self_ksm_stat_fd < 0) >>> return 0; >> >> Only test_unmerge_zero_pages() calls get_my_ksm_zero_pages(). And there, we >> have >> >> if (proc_self_ksm_stat_fd < 0) { >> ksft_test_result_skip("open(\"/proc/self/ksm_stat\") failed\n"); >> return; >> } >> >> As the fd is opened after others, we should never get fd=0. >> > > You are right. > >> So probably, this should just be handled as part of factoring it out, no need >> for this change upfront AFAIKS. >> > > My intention of this change is, we plan to move get_my_ksm_zero_pages() into a > standalone helper and will open and check the fd there. To make following > change consistent, I split it out. > > If you think it is not necessary, will drop this. IMHO, just cleaning it up while factoring out is better. -- Cheers, David / dhildenb