From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69039E810AD for ; Wed, 27 Sep 2023 09:57:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D21C96B0197; Wed, 27 Sep 2023 05:57:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD2C36B0198; Wed, 27 Sep 2023 05:57:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC1C96B0199; Wed, 27 Sep 2023 05:57:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AD9AA6B0197 for ; Wed, 27 Sep 2023 05:57:41 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 79FC1C09B9 for ; Wed, 27 Sep 2023 09:57:41 +0000 (UTC) X-FDA: 81281925522.29.084C7BD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 3DE86160015 for ; Wed, 27 Sep 2023 09:57:39 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Kv+rO9aT; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695808659; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q/ZTPYNPtH4SrQY4cVAUZ68m0I2/9+u1DlsmjX24JFE=; b=q/RQWzdU2aiXkiLOC8e0kiZhaXqYzPEjXdJSMdven2mag9qV/DNlOMhAogwQpltiedtknr 5u3XnuZk2iyyZpmEy80kkMw6ZQPd9rVC44/8qf2FXdZl1oMwS3shnY7hYopwdV3YDnl90R dJVX3G9wkp99z/IfUZ/DagVH2U+eswI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695808659; a=rsa-sha256; cv=none; b=AAttdgJO57q3TckAlz2IOmmZMlhkGoop3FOEGTIEM7emhE6Bs9+ARcXeKAgjQTHQlO5ckK IvH1h02ucZOWnXMuFrragJ84nPpp5C/yg0A6IeSYndOQEpyPVBla1xHnpXNQJJP5q8ybdK wzbYVEUZ8VsLIbKWIdwATozaoFIIwUE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Kv+rO9aT; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695808658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q/ZTPYNPtH4SrQY4cVAUZ68m0I2/9+u1DlsmjX24JFE=; b=Kv+rO9aTmZ0kMfkFTXnhbSJumu2fEjBYuObJzrWJBFdMr7aspGm557TRAkEExBAooJ7Td6 Rqt2ZSj6L9o4zjRyxqeyE5G1eNy7FuZJ2g3ii/5hj8jiEioDmWw9/zupbfS8/tBOfoVY2Y /swpGxyQpOghkWEX8kh7LiehyG//Wms= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-286-YvCNTmK2MzWpfHKpwwW1nQ-1; Wed, 27 Sep 2023 05:57:37 -0400 X-MC-Unique: YvCNTmK2MzWpfHKpwwW1nQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-31f3cfe7269so8218995f8f.2 for ; Wed, 27 Sep 2023 02:57:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695808656; x=1696413456; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q/ZTPYNPtH4SrQY4cVAUZ68m0I2/9+u1DlsmjX24JFE=; b=oCGHVo/mGk9te+x0LY2qS8ff8/pH3weXfXQRcFX/UihBfPvJ4Ra7vPGranh65dtyCC iQJc8WBrx/N15dZUSmFU4LAB5nkYZDLH6W2hjaRLHQ0cjy2rgq7gOZHaVBgl3ZO39IvX 4ORXrqPpGeslLYJwyPgPRaok+4pYmh+YVE3v6BI4AkWsqMQrd5OilRPcUbeLExjFyx18 dyAefe0GlN53XzE4f/z1yz1esw0EbowzaahmfkN2bo6ijkOBxZt4rkN3XAghX4tSr6sx VPkrgd4VJa6sMggw+FMVo8VcY3aAxZhv5IludNlDPKWF3Kioun1lnGWitJBWHKFU32Zx UUxw== X-Gm-Message-State: AOJu0YxWa6AdTJC/kYDFZck/ire2XKHvJQjOEA2rhRk/Zk9984i8EXIG hqkzvx/Hpzy3/87hhFhfMAQh7qi0NQyH3WsOOG0uPOnnYsE+B2dhWpyGbvRIjxPMPj+grO03jCD jPzqvkw5jF3o= X-Received: by 2002:adf:fc0a:0:b0:31c:7001:3873 with SMTP id i10-20020adffc0a000000b0031c70013873mr1222266wrr.60.1695808655809; Wed, 27 Sep 2023 02:57:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEiEiCGjZgVFCBi5nd5OAcMtl7WucZUl1jiAmCKPQ4qCeM7T9w14Pb8rIF5sMSX8FMD8yn4WQ== X-Received: by 2002:adf:fc0a:0:b0:31c:7001:3873 with SMTP id i10-20020adffc0a000000b0031c70013873mr1222248wrr.60.1695808655379; Wed, 27 Sep 2023 02:57:35 -0700 (PDT) Received: from ?IPV6:2003:cb:c749:6900:3a06:bd5:2f7b:e6eb? (p200300cbc74969003a060bd52f7be6eb.dip0.t-ipconnect.de. [2003:cb:c749:6900:3a06:bd5:2f7b:e6eb]) by smtp.gmail.com with ESMTPSA id m4-20020adff384000000b00321673de0d7sm1385747wro.25.2023.09.27.02.57.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Sep 2023 02:57:34 -0700 (PDT) Message-ID: Date: Wed, 27 Sep 2023 11:57:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v3 1/4] mm/ksm: add "smart" page scanning mode To: Stefan Roesch , Andrew Morton Cc: kernel-team@fb.com, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20230926040939.516161-1-shr@devkernel.io> <20230926040939.516161-2-shr@devkernel.io> <20230926140955.8b2627711116339af80731f2@linux-foundation.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: udsgdhbrc7w9e9fnzm6ar86g8og6h6zg X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3DE86160015 X-Rspam-User: X-HE-Tag: 1695808659-757344 X-HE-Meta: U2FsdGVkX19x0WXdjZFZr8zWuSeGyDWo+k2FIYugrz5simJJ6zK5ms2jNE5I0V2dnZ5q+Tv4VVcMs09C2iTWmGUzbzf9jHrrNy2hjHjXpIc6/8GAIKwXtkQrymTwMsoa8zNqO9uJkk3ALEGfnsdHuwD1hdUe+Rjyvaf6qmOreeNfD/2vIMuu+JBnyxQsWbTHBZlM8dUc7OKS+iWmTcOgZ7Ai5fDoV2/paxBuUf7+R3OvDT5YVn6BDvwcfLwUIIwpPlGZsqrm/DK14TAY/qbsyUceuTpDaUl55dcfL8bMkQ6D1xtj2pZVEvZD0XOsn6wh1fD4gvyR0wQN2OEGf1pIlTp1MnpP8/gT7sVJktkPf6Fx4SCsPcP2SoAMjkLOoadX4DdNh2EmOU3Kz+0gK2yHmU2sk0tYO0apDj+MJAjSAXISWg4Ou78glyH65Q2F3TOQkzuFJDbI/6nxOypqgWGfwmD9KG81+4h00lP30y/jax2/BPtwGvi+VCsbR+VxuRm7JTmuh/Ftf361rkERakyqtkzVOO8fyxmVAGHbgH4MYoPxIEvRaoqTNdRqoBiLdGuJ6vWyzgAu9gOPKlhztn8pIhe6yzhZajOpRkjAhJCQxOAvisBsquOA/bPjKGjXaJg4yRFNPPQcKHlJ9wUgBpPgv982biXKVZRbYFMrxV7E67L4wTBXPZp5odsITfCaTfc/l583AsgOGel1vgHVnWl8btgoz088meuYiy601UnKmq4Co5pKDQCkgqTThZ10bIoWnmH9KEzrGTNF+pRihux5wJ+eFimmdq0XgHVcZW5i4U1ttYhQWcxqos/n3Hneuh8gBPgrRwINUWclXkfxIyuUN6BFlhA8NS2xvgo72OlKqDomq9du/f/Gqw7AT7LswvyWKmkrHOLjYdKpTFO01Ob7kd1MEWfv4cuik+SHEUFSI+KqUX1YRRcZY1TvI5SqXVYWzz7mlNnC0Hd2zW1Use0 LtMvHdtT SBqI4XvSYbLG41kOTEplDLfPvO/qMGgBxnJ42k76J6xoybdXvJbfCmMzo1hJywpox2y0tDC8sqe5fVm/zGvke8ex/rx8QMyNDrXza+b/uPdG7Yu/lixdBfGnpWyG3oZCi9vfMVe6dulJnrN2VYJwAx5OuMjoRW/ILUCfmDAxE5i/YYUm8tJfFHHqph/5tL/fBjrk31eynnyfVeysMNZ4yusrh/sF8xtpTU8YbsMDcqvLGs5J9WMmj4qDZu2+5dY5TJ4tY7DSdPzbWRd8v9vZp97wgo1rBk7fRFLFbcsyyIb3HNQKbB0rwuR7wMVvESPvlSWq6bj/ACzgSb18w87RlaTiDkCfBuyFo+9HO+vcLs3azF0p1fdep+W1uJKyJYtBrctq2rfsf61u+9WIK0RY5WIUS2TLKssHFfUMCM+GT0xmC20bjFcjeBtMiNbUh0o1j6BmqSLzvRoMQPZ+4f/t3L/d2oQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000523, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27.09.23 02:39, Stefan Roesch wrote: > > Andrew Morton writes: > >> On Tue, 26 Sep 2023 09:13:31 -0700 Stefan Roesch wrote: >> >>>> Thinking about it, what are the cons of just enabling this always and not >>>> exposing new toggles? Alternatively, we could make this a compile-time option. >>>> >>>> In general, LGTM, just curious if we really have to make this configurable. >>>> >>> >>> The only downside I can see is that it might take a longer time for some >>> pages to be de-duplicated (a new candidate page is added, but its >>> duplicate is skipped in this round). So it will take longer to >>> de-duplicate this page. >>> >>> I tested with more than one workload, but it might be useful to get some >>> data with additional workloads. I was thinking of enabling it after one or >>> two releases. >> >> We could keep the tunable and make it default "on"? > > Sounds good to me > +1 Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb