From: David Hildenbrand <david@redhat.com>
To: Stefan Roesch <shr@devkernel.io>,
Andrew Morton <akpm@linux-foundation.org>
Cc: kernel-team@fb.com, hannes@cmpxchg.org, riel@surriel.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3 1/4] mm/ksm: add "smart" page scanning mode
Date: Wed, 27 Sep 2023 11:57:34 +0200 [thread overview]
Message-ID: <c00f0fd8-fb46-8008-95c5-5454474d4fff@redhat.com> (raw)
In-Reply-To: <qvqw5y3w30w4.fsf@devbig1114.prn1.facebook.com>
On 27.09.23 02:39, Stefan Roesch wrote:
>
> Andrew Morton <akpm@linux-foundation.org> writes:
>
>> On Tue, 26 Sep 2023 09:13:31 -0700 Stefan Roesch <shr@devkernel.io> wrote:
>>
>>>> Thinking about it, what are the cons of just enabling this always and not
>>>> exposing new toggles? Alternatively, we could make this a compile-time option.
>>>>
>>>> In general, LGTM, just curious if we really have to make this configurable.
>>>>
>>>
>>> The only downside I can see is that it might take a longer time for some
>>> pages to be de-duplicated (a new candidate page is added, but its
>>> duplicate is skipped in this round). So it will take longer to
>>> de-duplicate this page.
>>>
>>> I tested with more than one workload, but it might be useful to get some
>>> data with additional workloads. I was thinking of enabling it after one or
>>> two releases.
>>
>> We could keep the tunable and make it default "on"?
>
> Sounds good to me
>
+1
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-09-27 9:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 4:09 [PATCH v3 0/4] Smart scanning mode for KSM Stefan Roesch
2023-09-26 4:09 ` [PATCH v3 1/4] mm/ksm: add "smart" page scanning mode Stefan Roesch
2023-09-26 7:41 ` David Hildenbrand
2023-09-26 16:13 ` Stefan Roesch
2023-09-26 21:09 ` Andrew Morton
2023-09-27 0:39 ` Stefan Roesch
2023-09-27 9:57 ` David Hildenbrand [this message]
2023-09-26 4:09 ` [PATCH v3 2/4] mm/ksm: add pages_skipped metric Stefan Roesch
2023-09-26 4:09 ` [PATCH v3 3/4] mm/ksm: document smart scan mode Stefan Roesch
2023-09-26 4:09 ` [PATCH v3 4/4] mm/ksm: document pages_skipped sysfs knob Stefan Roesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c00f0fd8-fb46-8008-95c5-5454474d4fff@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@surriel.com \
--cc=shr@devkernel.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox