From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D572C5478C for ; Fri, 1 Mar 2024 06:28:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06CE06B0089; Fri, 1 Mar 2024 01:28:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 01D776B008C; Fri, 1 Mar 2024 01:28:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E26D56B0092; Fri, 1 Mar 2024 01:28:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CEBB36B0089 for ; Fri, 1 Mar 2024 01:28:26 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7E42CC04D4 for ; Fri, 1 Mar 2024 06:28:26 +0000 (UTC) X-FDA: 81847491012.27.7EC23D8 Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by imf10.hostedemail.com (Postfix) with ESMTP id 1C96EC0005 for ; Fri, 1 Mar 2024 06:28:21 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf10.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709274504; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e40jhvwJb+BIK96bQuMy6QMH06l3bpSBMyumy3i+8GM=; b=EylAP1XaJKVo61zxvFXHkaSwltM/XXPs8YDN5GW/e+u6mx6oiCczC/tZB7mF5wWuRXnA0Z 7kgojMnMqWCnnjST6K5Dw1JmiSg6Lrtxsuo1JmIGLc/x78WSHsfO2iwfCcPGi44fQqBdd+ xe8AfjJmDo+KHixs2kgB3oCvXpgc1bI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf10.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709274504; a=rsa-sha256; cv=none; b=zEfMFXAeqt2+1c/FF+NUXaZCL/RwDAIvoLbSojSC8CTWGJYfhHj3JcOChgsnc7ifPqER3y ZUffg51sl44L+E6q/5r62H3MIEyUcUTlQSO8zkRH2TDwhzXVKYMNON729vd+twN8dZyT6g +LEz0nvC18d1hK34oVo7yy7/EglGYcY= Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4TmJ6g4JXZzqjkH; Fri, 1 Mar 2024 14:27:39 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 939A014037B; Fri, 1 Mar 2024 14:28:17 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 1 Mar 2024 14:28:17 +0800 Subject: Re: [PATCH 0/8] Some cleanups for memory-failure To: "Matthew Wilcox (Oracle)" CC: , Naoya Horiguchi , Andrew Morton References: <20240229212036.2160900-1-willy@infradead.org> From: Miaohe Lin Message-ID: Date: Fri, 1 Mar 2024 14:28:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240229212036.2160900-1-willy@infradead.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1C96EC0005 X-Stat-Signature: hpe5nidb5xzcecu9eh8f47ucubr54u7j X-HE-Tag: 1709274501-435852 X-HE-Meta: U2FsdGVkX1+37qUw4VBgyF0/4ZTMPWOD/eEkqzTfafYegt7l3uVlwBwiAzmqORKZkMEF+JKYrWZ7G6v+DOTNBi20f7ffsJRi4qFFt3FZIPt1fMlL9kHAxEZL1WFpQrQrWv83na/bMVt8m3/nfDd6rpv//Gm8c0RVI/RQp7CygLJvgUgdZqZM9U+zgQ/lrWmf2Lpild2JgPXbDSbJFYtwr0nQA1jxBi9YwHRh2EHO08VC6EtVXHQRmd0TausMpeGLOvagvrm7xWvudY7fN6piaGpMFJG0AiqeNweOC1Izr1Ob/yCLCL8UfvO9A/YVDUWPCiSsPd0puGrfHt/0QHWPMsD0khrwa9F8s0jlLg2S6gNvnk1QLrBL008e85PLDNu6dh0cSyAVoxqM+P2yn/TCnMHTbP7/HjzZbFTneDyJh/g31B1qRStZ/m1Mp7M5paM0zg2Ek6bKBEwc06V8wIJrMrGiueSENnvXlNE7qib8YlhDGyxyxti1Q/NG0sEOZbuWa5R8cMaiwFeXGQaloSpb7t2cAezaNR6QwJYSRh0vLnu24PAPzojbaH6KWOwoBXDEfwluau19gUNzRP43S4UP/LvMHTP4ta5qbItJx2ZhcuIFaa9dSu7u5iWXaCdySBZsRWBpp1wEJ1KfSWgTW+LO9KhZjNxFY4yGJcaKhvRiPPkZvecX0RAsLnoSvef6PdpLSsuFK5zX3aLCr3AQpJewSrU7RqSX5OSnQR4KZ57mwv3XszxYaBHhhDpMKIocgkVlxdkfi4QjQaEyA4PGPvdFlQRkB/vlMCgMRE98xQ40o+3h5rv/pE+S6pWG5Huelhkyh2sOMAKsN7o/kr4igH/O5K484dr1PaQGrYngs4IHdzGzHAv/ezeWCbZlYc31yYpn6hp9SN3v6GFyZvM0NHqPU9/tn17YAeKwSp7nmz1p01w+/qUHyecpckCjQQ6Ystx0erzyhs+G8It7GnCCDoJ yNG5kUOk /OdUhpRNNzE6RFkXPE62+1SYg7OqyPmteNk0m7XbH2gM/TahURXfv/SGwoSu/QtirNH18IXuKI6ZPAbVRJauukawfwERqbNS9qbdQQ605NCR9n6lzmDNBbMWqwSfZd+EDG214fVMO1Llr5MMkMsaAECYuTQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/3/1 5:20, Matthew Wilcox (Oracle) wrote: > This isn't my complete collection of patches to memory-failure, but > they're the ones I have the most confidence in. I haven't done any real > testing of this beyond compiling & running on a system without trying to > do any memory failure injections. Is there a good test-suite I should > run before submitting these kinds of patches? mm_regression[1] should be a good alternative test-suite to run. It's written by Naoya Horiguchi and available at https://github.com/nhoriguchi/mm_regression. > > Matthew Wilcox (Oracle) (8): > mm/memory-failure: Remove fsdax_pgoff argument from __add_to_kill > mm/memory-failure: Pass addr to __add_to_kill() > mm: Return the address from page_mapped_in_vma() > mm/memory-failure: Convert shake_page() to shake_folio() > mm: Convert hugetlb_page_mapping_lock_write to folio > mm/memory-failure: Convert memory_failure() to use a folio > mm/memory-failure: Convert hwpoison_user_mappings to take a folio > mm/memory-failure: Add some folio conversions to unpoison_memory Thanks for your patches. I will review them as soon as possible. > > include/linux/hugetlb.h | 6 +- > include/linux/mm.h | 1 - > include/linux/rmap.h | 2 +- > mm/hugetlb.c | 6 +- > mm/hwpoison-inject.c | 11 +-- > mm/internal.h | 1 + > mm/memory-failure.c | 144 +++++++++++++++++++++------------------- > mm/migrate.c | 2 +- > mm/page_vma_mapped.c | 14 ++-- > 9 files changed, 97 insertions(+), 90 deletions(-) >