From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33ACDC4338F for ; Wed, 18 Aug 2021 07:55:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C1B286109E for ; Wed, 18 Aug 2021 07:55:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C1B286109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3A8606B006C; Wed, 18 Aug 2021 03:55:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 358848D0001; Wed, 18 Aug 2021 03:55:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21F6A6B0073; Wed, 18 Aug 2021 03:55:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id 060F36B006C for ; Wed, 18 Aug 2021 03:55:28 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id AB5148249980 for ; Wed, 18 Aug 2021 07:55:27 +0000 (UTC) X-FDA: 78487441494.13.51AC14F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 564FFB007B18 for ; Wed, 18 Aug 2021 07:55:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629273326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BYRAiIatE3uIXVhGsrzHYNlVabGLMIXPtsHVU4zwers=; b=RM8dQVkP1XsKFCIfkhlsUJIh/Fx3eYQUnKMo8PZOVXIjRnMCnuLzC35y4/L5MvuWcuNwT4 3ll+GFakHo03yLz5IfWZ4aGB17u+LkKEYDz8WpilGYGrzAYrDs43bVNAlYPwNwWkmOJU8F ps9fBdWwrahyFJQFIEQi8HEl7hoOWCY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-484-O-bjA77-PMK2Ppre-L8dvg-1; Wed, 18 Aug 2021 03:55:25 -0400 X-MC-Unique: O-bjA77-PMK2Ppre-L8dvg-1 Received: by mail-wr1-f69.google.com with SMTP id m2-20020a0560000082b0290154f6e2e51fso311999wrx.12 for ; Wed, 18 Aug 2021 00:55:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=BYRAiIatE3uIXVhGsrzHYNlVabGLMIXPtsHVU4zwers=; b=ZVLqYT1UC3pjYP7DIDhdWEz/FwPFb/fdzIn1FeVuw5uf8C8JIFElSUtuBEdt6PEM4C jV8doMNApQWZVjWt/eKtG6OWHDsJalp7lmabdf14qUZ0K04LBiCmg8zQnrBZ1avM++1x Q482OPUq4r5p0T0GBGf1xmI8FPoIMO1LeS4b1VWb0NZr2V0Vry+pHsPrakk3OvACwYbT 5s3j3Qhpab4OMhvEMtGCFDcNKYuuhi3w225mpN42iS/7RXYZ7RLacGtzkm5rAauWTHYA mz8Fyn/mArGHCgW7y/GqwsR0XiEa0YWUQvnLCls+CWMImm+8Opgt4W+sH3fL54jXu1bC Abng== X-Gm-Message-State: AOAM533bVpPgbdvzUSKU9CXBigpFY4g8QfeK8dia7z8UKQ0v4LHgmLd4 LMhnJiz3WVK4OrTaSmF84dtsnT4lZVWtuVGCe7Skw9c1svdnbe5G6YifpCF9tfk2t0V9sGR/7+/ 468qOzjiukSA= X-Received: by 2002:a05:600c:4f13:: with SMTP id l19mr6960274wmq.171.1629273324112; Wed, 18 Aug 2021 00:55:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykaIJUh3V6bo2I6EXx8+Adkp+WDStWpE1etNSQpAJhhF9uRfYxFYFKYgNeDxWvPw4aK9wI0g== X-Received: by 2002:a05:600c:4f13:: with SMTP id l19mr6960251wmq.171.1629273323924; Wed, 18 Aug 2021 00:55:23 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6417.dip0.t-ipconnect.de. [91.12.100.23]) by smtp.gmail.com with ESMTPSA id c9sm5018941wrm.43.2021.08.18.00.55.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Aug 2021 00:55:23 -0700 (PDT) Subject: Re: [PATCH 1/2] mm: hwpoison: don't drop slab caches for offlining non-LRU page To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= Cc: Naoya Horiguchi , Yang Shi , "osalvador@suse.de" , "tdmackey@twitter.com" , "akpm@linux-foundation.org" , "corbet@lwn.net" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" References: <20210816180909.3603-1-shy828301@gmail.com> <20210818063042.GA2310427@u2004> <20210818075316.GB501393@hori.linux.bs1.fc.nec.co.jp> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Wed, 18 Aug 2021 09:55:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210818075316.GB501393@hori.linux.bs1.fc.nec.co.jp> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RM8dQVkP; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf24.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: dn96tumt1tpjjiex13qp3ph4wjwnk4ci X-Rspamd-Queue-Id: 564FFB007B18 X-Rspamd-Server: rspam05 X-HE-Tag: 1629273327-350601 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18.08.21 09:53, HORIGUCHI NAOYA(=E5=A0=80=E5=8F=A3 =E7=9B=B4=E4=B9=9F)= wrote: > On Wed, Aug 18, 2021 at 09:24:01AM +0200, David Hildenbrand wrote: > ... >> >> Might we want to add a TODO in the code? We have a similar one in >> mm/page_isolation.c:set_migratetype_isolate() and it's certainly a rem= inder >> that something of value is missing. >=20 > Yes, that will be helpful. The below's what's in my mind, but if someo= ne > has better idea, that's fine. >=20 > @@ -296,11 +296,9 @@ void shake_page(struct page *p, int access) > } > =09 > /* > - * Only call shrink_node_slabs here (which would also shrink > - * other caches) if access is not potentially fatal. > + * TODO: Could shrink slab caches here if a lightweight range-based > + * shrinker will be available. > */ > - if (access) > - drop_slab_node(page_to_nid(p)); > } > EXPORT_SYMBOL_GPL(shake_page); Just what I had in mind, thanks! --=20 Thanks, David / dhildenb