From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF5B2D3A661 for ; Tue, 29 Oct 2024 15:48:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C8936B009A; Tue, 29 Oct 2024 11:48:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 678656B009B; Tue, 29 Oct 2024 11:48:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 540976B009C; Tue, 29 Oct 2024 11:48:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 36D206B009A for ; Tue, 29 Oct 2024 11:48:00 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0364A1A1588 for ; Tue, 29 Oct 2024 15:47:59 +0000 (UTC) X-FDA: 82727070090.15.19C095D Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by imf16.hostedemail.com (Postfix) with ESMTP id 2A33118001D for ; Tue, 29 Oct 2024 15:47:32 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ShhgXxb5; spf=pass (imf16.hostedemail.com: domain of dave.jiang@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=dave.jiang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730216718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8eV/JvOFKtPOw5Op+Ssd88qA17xTbxnKv+1tr1xZauc=; b=QEtD7dYSk3nilXb6qTBDT4JBaFFKP1dL2H7kQRg6Bt+f2dXm7HO5+xrArm2JiXUH0MXwHs DDFiknZ4lgu3F9ssGLgljB28KjYBCNSBlCpIXrmuJ21eZYcjWWRO9O2fKGu+gsYCSJKKQj v1L5R6vKZ6N4uHJ3XiRApDlMMa2farw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730216718; a=rsa-sha256; cv=none; b=w9fgtwEd2S5tCNFLOTQ4ZtAsB6LxWVF5BqS49OPkSSJqVkTIgPymnsnU9gOKACzooiqtLH a0WA3Y+irBWcMA2vwxPPGMPFf9hQBqTp+g1CBDAF9zokTFqxwVX9/3sMiZCC1QCK1i9lvO LWfaD9ZirISOTB5qHl+jCcQpxWXNRNI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ShhgXxb5; spf=pass (imf16.hostedemail.com: domain of dave.jiang@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=dave.jiang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730216878; x=1761752878; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=1r7A7ww7pBafTuQhRqV8UGyD9vtwIwKAIJ+slSK3Huo=; b=ShhgXxb5IIh/RK8qeR2xyTXstvMk/0jM/61kr9zGuRKTzgV4podLjo6b Q2mh4wnxKDxPJ39Cgu6Zza+04icExvGN5bfnt43055B70YSEecvmmgeR0 a6MWvcqt7sKwfOLMORl+tdac30X/K+QmYg/ZXkk++MvjafVqBnl2ROYRD AD2SMMG223kMKTYCITSWy9VW1Rx/Qi9wvSpORcfOV9fAsJjg4mZmHQT6T Ns7SNIPXwYjjGyysbjBCx4KZp7W+/XedvnBmQkEjBPmwLwqxFqcJV3w4T 06WY3ZhmX/GEKNS7QQCWU3EfYkp7rLoqjPh0Yk2p/vgYHoM2HOSGssCIq w==; X-CSE-ConnectionGUID: k0T2w6IlSFu9DLVUrbnwnQ== X-CSE-MsgGUID: lTpV7vJjQy2kgAiW770dmg== X-IronPort-AV: E=McAfee;i="6700,10204,11240"; a="55271708" X-IronPort-AV: E=Sophos;i="6.11,241,1725346800"; d="scan'208";a="55271708" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2024 08:47:56 -0700 X-CSE-ConnectionGUID: V5pPOSHlTGSDjrkfWJdvXQ== X-CSE-MsgGUID: A3P6Yq5GSUSlKa7JmZm7uQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,241,1725346800"; d="scan'208";a="112817297" Received: from rfrazer-mobl3.amr.corp.intel.com (HELO [10.125.108.71]) ([10.125.108.71]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2024 08:47:53 -0700 Message-ID: Date: Tue, 29 Oct 2024 08:47:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 05/14] cxl/mbox: Add GET_FEATURE mailbox command To: shiju.jose@huawei.com, linux-edac@vger.kernel.org, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: bp@alien8.de, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, gregkh@linuxfoundation.org, sudeep.holla@arm.com, jassisinghbrar@gmail.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com References: <20241025171356.1377-1-shiju.jose@huawei.com> <20241025171356.1377-6-shiju.jose@huawei.com> Content-Language: en-US From: Dave Jiang In-Reply-To: <20241025171356.1377-6-shiju.jose@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: prqapqj9zz9bbbgkdjeub4xmsjsroa41 X-Rspamd-Queue-Id: 2A33118001D X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1730216852-75764 X-HE-Meta: U2FsdGVkX18LfounzUFD++EglMAasfR3tLE3BY0PNRyZTWOTCnsMuJqzTy9tB7rAKUUUl8lnoBcRPexSOQAUxogMM7NPA4hSVDGsu7vm4V5v7F0VkuLkU9dStqKgDvTMY5CGcqjgknl0NUJOJmEBTx5usqCXtK2JlGfnVSAm5OSjc6E56iWBNtdXTGBSxKwa86sv6JaFjTWyKo7HsGwg9uIKPFwRaUHhywmnbyLVk07SE+6Dvur5A3smW+otVarnMClhugLiGyjsafGB65SsKzVA7ReERNWZNfr2S57CXcn0MAJ4VTf3/KMQOcJ6kiNgybkcJRck8ckVdoeoIQs9LAY4iyJE9u5SBWIdyKLXfbuh6EAc7vbabbvDF2bRv6c8/4Jt+lnDGjm49TgZu4AE1ur2u0brI/TCzcCPgqqz+MV+J8b0TkwLjicerp9Qcp/9arbhnydx1eVr/9vJ0XTdU8Oh/LuxyJF6dHWWhLzeB7UeBrEU1fJEx+hgMweNieaF4SUzO+Xz3R8L4wWz59qfQ/huPxXMhXk0R2MUDhEzkV5j0N+TSbAujwxtk6+0wA24knDfCTK94v6x03g+WAsewhxqI7oxSOSZaJgHoJhl097m2bTxKjGHSBdALHpdXvCxoi+9BqsZlVBJQLpY9E4b+f0upjJY/bRHC0Nf+BvGk1DAcWPLsKT81WSWD+forUPkAkf88cMIN/HH6V9QVFB8x8NRUJjP+KVQMZrvuyGU/vjfyCy17Xy36B1lzCkbnnN3/X9ZWKCs1NMBOZhHy12ePrvl7Df0M11FyrOu4FkUDOh13N5bn4cOuPME33U5ybmruyPXkjwzF6rJzf5/lvDc/OL6f/8DZT4RT22Dp/NdiB3Rkbt+QxL78w+wZyllPdOJLRoAxZKM0Hj6ztb8426EbAPXwZVw+jFNQNiSzD8B8RwxGOzVs0Ugy4fioAA/FpmKBaOQPmoMl/I5nhq7V8D Rlcd7A0S F4pXAU4cjQvhYlfoWxHg/ev3FRYqXgSeuOHrAn91Ik4KAVe6MX2DZGbNJEEBnCA1CsDQQ+wXCzyMZLo8FNFyDe9kQmqHIF3EV+/dXa5OhKgUC7OKGVRAagdO9c+aSkr9mdKx8A1wYHvUl+4cOMba9qYpwU83CEOXa48cm7sYGaBnFQeEHqSomy/zpO9IYNKhAxsZvdtKNin3bD6AQ6I2As4F5gEhbSqpewbisRlqEIkJH/tD8LNt4KEhDZMceAknEA491d2St+cuS4MH1Dkrpv693GbSre9SRV/43fVy4XbKp5J4EEUDOjzWJ39EST6RVRdCgPcEG4evY6iXvOyuWxzujtNBfif0JWhIs9iYWD+lh7bbVGTT0iTcc/xrUEWme44+PCC59YrimNKk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/25/24 10:13 AM, shiju.jose@huawei.com wrote: > From: Shiju Jose > > Add support for GET_FEATURE mailbox command. > > CXL spec 3.1 section 8.2.9.6 describes optional device specific features. > The settings of a feature can be retrieved using Get Feature command. > CXL spec 3.1 section 8.2.9.6.2 describes Get Feature command. > > Reviewed-by: Fan Ni > Reviewed-by: Jonathan Cameron > Signed-off-by: Shiju Jose Reviewed-by: Dave Jiang > --- > drivers/cxl/core/mbox.c | 41 +++++++++++++++++++++++++++++++++++++++++ > drivers/cxl/cxlmem.h | 26 ++++++++++++++++++++++++++ > 2 files changed, 67 insertions(+) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index 5045960e3bfe..3cd4bce2872d 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -970,6 +970,47 @@ int cxl_get_supported_feature_entry(struct cxl_memdev_state *mds, const uuid_t * > } > EXPORT_SYMBOL_NS_GPL(cxl_get_supported_feature_entry, CXL); > > +size_t cxl_get_feature(struct cxl_memdev_state *mds, const uuid_t feat_uuid, > + enum cxl_get_feat_selection selection, > + void *feat_out, size_t feat_out_size) > +{ > + struct cxl_mailbox *cxl_mbox = &mds->cxlds.cxl_mbox; > + size_t data_to_rd_size, size_out; > + struct cxl_mbox_get_feat_in pi; > + struct cxl_mbox_cmd mbox_cmd; > + size_t data_rcvd_size = 0; > + int rc; > + > + if (!feat_out || !feat_out_size) > + return 0; > + > + size_out = min(feat_out_size, cxl_mbox->payload_size); > + pi.uuid = feat_uuid; > + pi.selection = selection; > + do { > + data_to_rd_size = min(feat_out_size - data_rcvd_size, > + cxl_mbox->payload_size); > + pi.offset = cpu_to_le16(data_rcvd_size); > + pi.count = cpu_to_le16(data_to_rd_size); > + > + mbox_cmd = (struct cxl_mbox_cmd) { > + .opcode = CXL_MBOX_OP_GET_FEATURE, > + .size_in = sizeof(pi), > + .payload_in = &pi, > + .size_out = size_out, > + .payload_out = feat_out + data_rcvd_size, > + .min_out = data_to_rd_size, > + }; > + rc = cxl_internal_send_cmd(cxl_mbox, &mbox_cmd); > + if (rc < 0 || !mbox_cmd.size_out) > + return 0; > + data_rcvd_size += mbox_cmd.size_out; > + } while (data_rcvd_size < feat_out_size); > + > + return data_rcvd_size; > +} > +EXPORT_SYMBOL_NS_GPL(cxl_get_feature, CXL); > + > /** > * cxl_enumerate_cmds() - Enumerate commands for a device. > * @mds: The driver data for the operation > diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h > index f88b10188632..0c152719669a 100644 > --- a/drivers/cxl/cxlmem.h > +++ b/drivers/cxl/cxlmem.h > @@ -531,6 +531,7 @@ enum cxl_opcode { > CXL_MBOX_OP_CLEAR_LOG = 0x0403, > CXL_MBOX_OP_GET_SUP_LOG_SUBLIST = 0x0405, > CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, > + CXL_MBOX_OP_GET_FEATURE = 0x0501, > CXL_MBOX_OP_IDENTIFY = 0x4000, > CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, > CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, > @@ -856,6 +857,28 @@ struct cxl_mbox_get_sup_feats_out { > struct cxl_feat_entry ents[] __counted_by_le(supported_feats); > } __packed; > > +/* > + * Get Feature CXL 3.1 Spec 8.2.9.6.2 > + */ > + > +/* > + * Get Feature input payload > + * CXL rev 3.1 section 8.2.9.6.2 Table 8-99 > + */ > +enum cxl_get_feat_selection { > + CXL_GET_FEAT_SEL_CURRENT_VALUE, > + CXL_GET_FEAT_SEL_DEFAULT_VALUE, > + CXL_GET_FEAT_SEL_SAVED_VALUE, > + CXL_GET_FEAT_SEL_MAX > +}; > + > +struct cxl_mbox_get_feat_in { > + uuid_t uuid; > + __le16 offset; > + __le16 count; > + u8 selection; > +} __packed; > + > int cxl_internal_send_cmd(struct cxl_mailbox *cxl_mbox, > struct cxl_mbox_cmd *cmd); > int cxl_dev_state_identify(struct cxl_memdev_state *mds); > @@ -919,4 +942,7 @@ void cxl_dpa_debug(struct seq_file *file, struct cxl_dev_state *cxlds); > int cxl_get_supported_features(struct cxl_memdev_state *mds); > int cxl_get_supported_feature_entry(struct cxl_memdev_state *mds, const uuid_t *feat_uuid, > struct cxl_feat_entry *feat_entry_out); > +size_t cxl_get_feature(struct cxl_memdev_state *mds, const uuid_t feat_uuid, > + enum cxl_get_feat_selection selection, > + void *feat_out, size_t feat_out_size); > #endif /* __CXL_MEM_H__ */