linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: Elijah <me@elijahs.space>, "Elijah Wright" <git@elijahs.space>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
	"Vlastimil Babka" <vbabka@suse.cz>,
	"Uladzislau Rezki" <urezki@gmail.com>,
	linux-mm@kvack.org
Subject: Re: [PATCH] rust: slab: add basic slab module
Date: Thu, 25 Sep 2025 14:02:55 -0400	[thread overview]
Message-ID: <bypo74mzotejpsjdqd55sxygq3wjffnnimpm3vhm2xr5bddmen@lt6sr77ys73g> (raw)
In-Reply-To: <DD22FI7F2ZHT.32SL8PXFZZHV3@kernel.org>

* Danilo Krummrich <dakr@kernel.org> [250925 13:43]:
> On Thu Sep 25, 2025 at 7:20 PM CEST, Elijah wrote:
> 

...

> 
> > I was thinking of maybe creating something like KBox for kmem_cache but 
> > I didn't want to touch allocator code yet, I figured I would just create 
> > the groundwork for that to exist. rbtree.rs uses KBox now but I'm not 
> > sure it should, at least if it's going to scale to many nodes
> 
> Ok, so you want to support kmemcache for rbtree nodes. Ideally, you should also
> have a use-case for that, but given that we'll also need kmemcache in other
> drivers (such as Nova) anyways, I think that's fine.

This seems different than what exists on the C side, at least to me.
The rbtree is implemented by embedding the links to the prev/next into
the struct which is using the tree.

The above sounds like the nodes of the rbtree are allocated on its own
and not part of another allocation on the rust side?

That is, the kmemcache would allocate the struct that contains the
rbtree linkage (or nodes, I guess), but not the nodes alone.

Thanks,
Liam


  reply	other threads:[~2025-09-25 18:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250924193643.4001-1-git@elijahs.space>
2025-09-25  2:17 ` John Hubbard
2025-09-25  9:54 ` Danilo Krummrich
2025-09-25 17:20   ` Elijah
2025-09-25 17:43     ` Danilo Krummrich
2025-09-25 18:02       ` Liam R. Howlett [this message]
2025-09-25 18:08         ` Danilo Krummrich
2025-09-25 18:11         ` Boqun Feng
2025-09-25 18:05       ` Elijah
2025-09-25 18:15         ` Danilo Krummrich
2025-09-25 18:17           ` Danilo Krummrich
     [not found]           ` <74b3ef24-a307-4d3c-891a-8c5283448b20@elijahs.space>
2025-09-25 18:52             ` Elijah
2025-09-25 17:54   ` Alice Ryhl
2025-09-26 15:00   ` Vlastimil Babka
2025-09-26 15:33     ` Danilo Krummrich
2025-09-26 15:55       ` Danilo Krummrich
2025-09-26 16:32         ` Vlastimil Babka
2025-09-26 16:58           ` Danilo Krummrich
2025-09-26 17:11             ` Vlastimil Babka
2025-09-26 19:01               ` Danilo Krummrich
2025-09-28 14:47   ` Danilo Krummrich
2025-09-29  7:14     ` Vlastimil Babka
2025-09-29 14:11     ` Elijah
2025-09-29 20:32       ` Danilo Krummrich
2025-10-01  4:44 ` [PATCH v2] " Elijah Wright
2025-11-06  7:53   ` Alice Ryhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bypo74mzotejpsjdqd55sxygq3wjffnnimpm3vhm2xr5bddmen@lt6sr77ys73g \
    --to=liam.howlett@oracle.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=git@elijahs.space \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=lossin@kernel.org \
    --cc=me@elijahs.space \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=urezki@gmail.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox