From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EC95C4828F for ; Fri, 2 Feb 2024 19:47:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A7426B0085; Fri, 2 Feb 2024 14:47:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9579D6B0087; Fri, 2 Feb 2024 14:47:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81FF66B0088; Fri, 2 Feb 2024 14:47:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 701A96B0085 for ; Fri, 2 Feb 2024 14:47:01 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 15B3B1406DE for ; Fri, 2 Feb 2024 19:47:01 +0000 (UTC) X-FDA: 81747897042.25.A46F064 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf01.hostedemail.com (Postfix) with ESMTP id E608240011 for ; Fri, 2 Feb 2024 19:46:58 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=KZhG4cPm; dkim=pass header.d=suse.com header.s=susede1 header.b=KZhG4cPm; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf01.hostedemail.com: domain of mkoutny@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706903219; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/K/q1pAHfeWX2TgaZYj9FVR8OkRJYUi+zBTaXcCAwak=; b=7M2yYGtWEBYGO79FJcj9GbouSvO6e6ibmuSmNjzMwHIHOGnpBZYQIm630r6NMUqdpjflLX IsYBBkDaMhbhyccOfAamhotc98OMfA//1yqQNlHpIKhJyoinJRxJ8xBNaixW1ibx9GQKad L4TfUsWe9Oq/1DxC0xpWv4vItQ+MPSU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=KZhG4cPm; dkim=pass header.d=suse.com header.s=susede1 header.b=KZhG4cPm; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf01.hostedemail.com: domain of mkoutny@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706903219; a=rsa-sha256; cv=none; b=Cqif3CbvHVwRQmLVI7IK9T0c9qXiZIAde7MVnHzh4aXeX3r7j4DzPhh6qzvLJUuq2Uw/iY kE8q4DI3oizZT51CmrihDKFe+y1a++zOZNqjHbc02bpaV04e1trFS8sOLji9pSa3r63DfN /SrknO5LIuwVbC68GQVvFh/y1DI7eOw= Received: from blackpad (unknown [10.100.12.75]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 25C80220CA; Fri, 2 Feb 2024 19:46:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1706903217; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/K/q1pAHfeWX2TgaZYj9FVR8OkRJYUi+zBTaXcCAwak=; b=KZhG4cPm+x8iqhu3SDSqCd1O8OkNf4/Y9/+dkIVjBoo62GL+dcYLip/E0uO21QVnf2GR3H FiGOvWS20IQuzbXbQDUA4fVAKl0S4lWQh0IXWx2WpsTKiEBJjrbKJZW16ggJjWRASKc+NC 3R6Dp5uimqKb8VzZvtytrXR+B/OWCr0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1706903217; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/K/q1pAHfeWX2TgaZYj9FVR8OkRJYUi+zBTaXcCAwak=; b=KZhG4cPm+x8iqhu3SDSqCd1O8OkNf4/Y9/+dkIVjBoo62GL+dcYLip/E0uO21QVnf2GR3H FiGOvWS20IQuzbXbQDUA4fVAKl0S4lWQh0IXWx2WpsTKiEBJjrbKJZW16ggJjWRASKc+NC 3R6Dp5uimqKb8VzZvtytrXR+B/OWCr0= Date: Fri, 2 Feb 2024 20:46:56 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: "T.J. Mercier" Cc: Efly Young , hannes@cmpxchg.org, akpm@linux-foundation.org, android-mm@google.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, muchun.song@linux.dev, roman.gushchin@linux.dev, shakeelb@google.com, yuzhao@google.com Subject: Re: Re: Re: [PATCH] mm: memcg: Use larger chunks for proactive reclaim Message-ID: References: <20240201153428.GA307226@cmpxchg.org> <20240202050247.45167-1-yangyifei03@kuaishou.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gwdtcq3kwf5cetlv" Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E608240011 X-Stat-Signature: nmgkkpw6ng5tninmh7nsu1bop8fr45tf X-Rspam-User: X-HE-Tag: 1706903218-566581 X-HE-Meta: U2FsdGVkX1+YdZ8tb4yOO6OX/grPa29YoS/wfU6imygswGydhmAMNc8iVetlnOB59z06D9O6d2oPs3fBySp53ARRaoGYCShMO76URw39dlu9t8ZI66NIdlJi1MsM5qyNXtYijKcmJj5sh+ENVWtJrYq0CVCjSVI/IwByp7Zz0Nz+llIPk7SPa7+mLbDkTpQf4HWOpYXeUtoiggeZ67rrXvD4JC+PkyykSyTnzTQ8RS0J5PqH23/jC7Nip4qPLV8cJVrX4enYU4htpRbduuMuxWKq6wyp9vBeTzHjigg+NFbR0KZWHvKqBvUm6Gezmn4o0iOH0rMtQ6w14qh7nO//0upLN47vED+MuA7ddcQlL027y771bQ+HlvnmkrXyBUCNYd27jv0q7fARBDKfNQSLpUXyf/O7H2oSEw8KfX9MMZFf34mH9zutsjbCVfmV2PdjxTQoZzFKTJ1l9Ln7hja82B8ytySLz0OXHivmpZ73GE1gOEBHUSjhb4V9PSsJKk7nqvDlFKf3kgkMUkRuobqs1wV/fo+Mc21eQQ4VATacr60JiNytbp6gwHxZ9KxDBQbG4azIYWobF2QJiuv79SXedLJhHdf01zFlRzjJQSJY35Gqi8y6NLnidKLRjFT9K3RII6Ce4OvGXa1Zi8QVu9kJ8N/xqQddM/MLx7FZI5CjPRkkmh/WRcTk4KitRVUckYt9MYkwiJ+Jq5GZbAChB2oeidEUeT/9AN6AHHuU4PgGm5kEDs6OW2WDUg4cznqQT9Tae9+f226Jdp0PIRaqym0xWeMjEOr/zvPrZAZplstRXgpkB/tT0h0v6+91tIGF6510MRW8jlREVyOyC8nPxPLFIsPj8sLXAkBb+zyHrWDz2+a9KZLD1UYPFijICLiDkMC53cjuZd3s9r4ePG79e0zlT28S3OoGbAgsg1g4BjaZnkXbt3Lxlya4mg5Tv7BjtU3rNStny01HCgkkTaUeCae iyAzxlDG urBuk45q8WPBfqA7+2hXCxm7ClAGQNVF1T3jA9aDTI3a6zT4AiUhI7BIrUHtzroGekh7sv277wYMl3ILuVwAJPIKFB3CEnVQKWlAb4tDdSE8JTDCbQ9219KkfIO5GchZmGq3Kahv2FzUEmYwVAdCviC4TPkYXbwcz2uQNILqU0HV7T45jETOAHUgeYzL78Tr+HGIsEBXOs52kdQMtt/Nc8rdI5FZwtaAQQ4NeytFReT+uTAabDUmlnE7fQO6e2UvXCf+k1lTf/4Y2bC9WVpSb4YUjt5CwBjzoDYpqRwfgKZ5u3c1FrF8tfeNu/urPW17ZK0pj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000381, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --gwdtcq3kwf5cetlv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 02, 2024 at 10:22:34AM -0800, "T.J. Mercier" wrote: > So all of these should be more or less equivalent: > delta <=3D SWAP_CLUSTER_MAX ? delta : (delta + 3*SWAP_CLUSTER_MAX) / 4 > max((nr_to_reclaim - nr_reclaimed) / 4, (nr_to_reclaim - nr_reclaimed) % = 4) > (nr_to_reclaim - nr_reclaimed) / 4 + 4 > (nr_to_reclaim - nr_reclaimed) / 4 >=20 > I was just trying to avoid putting in a 0 for the request size with the m= od. The third variant would be simpler then. Modulo looks weird. Oh, and I just realized that try_to_free_mem_cgroup_pages() does max(nr_pages, SWAP_CLUSTER_MAX). Then I'd vote for the fourth variant + possible comment about harmless 0. (I'm sorry if this was discussed before.) Michal --gwdtcq3kwf5cetlv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZb1GrgAKCRAGvrMr/1gc jpaqAP9PQEKb5U00/7EvIWgO4mSe3xgJFzSEakWK6ZzZcedHxQD7Br+GIkc1yt7s uBEhvGPzYvygslFDhyZVTQXlOueoaAs= =ArmI -----END PGP SIGNATURE----- --gwdtcq3kwf5cetlv--