linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: akpm@linux-foundation.org, david@redhat.com,
	lorenzo.stoakes@oracle.com, rppt@kernel.org, surenb@google.com,
	mhocko@suse.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, jinnasujing@gmail.com
Subject: Re: [PATCH] mm/vmstat: Fix indentation in fold_diff function.
Date: Tue, 21 Oct 2025 12:10:14 -0400	[thread overview]
Message-ID: <bx5zarozwnlogznjai2242und55z5jxs4bpgliswuo7shezbma@ri2ocyj7n4q7> (raw)
In-Reply-To: <b0c6c6d7-843a-48e9-bafc-f2595b059d32@suse.cz>

* Vlastimil Babka <vbabka@suse.cz> [251021 05:03]:
> On 10/21/25 09:37, Jing Su wrote:
> > Adjust misaligned braces in the fold_diff function to improve
> > code readability and maintain consistent coding style.
> > 
> > Signed-off-by: Jing Su <jingsusu@didiglobal.com>
> > ---
> >  mm/vmstat.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/mm/vmstat.c b/mm/vmstat.c
> > index bb09c032eecf..63860c3d22e6 100644
> > --- a/mm/vmstat.c
> > +++ b/mm/vmstat.c
> > @@ -782,13 +782,13 @@ static int fold_diff(int *zone_diff, int *node_diff)
> >  		if (zone_diff[i]) {
> >  			atomic_long_add(zone_diff[i], &vm_zone_stat[i]);
> >  			changes++;
> > -	}
> > +		}
> >  
> >  	for (i = 0; i < NR_VM_NODE_STAT_ITEMS; i++)
> >  		if (node_diff[i]) {
> >  			atomic_long_add(node_diff[i], &vm_node_stat[i]);
> >  			changes++;
> > -	}
> > +		}
> >  	return changes;
> >  }
> 
> Thanks. IMHO it would be even more readable if the for () also had {
> }brackets.

Yes, I agree.  That's probably how this happened in the first place.




  reply	other threads:[~2025-10-21 16:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21  7:37 Jing Su
2025-10-21  7:57 ` David Hildenbrand
2025-10-21  9:03 ` Vlastimil Babka
2025-10-21 16:10   ` Liam R. Howlett [this message]
2025-10-21  9:19 ` Lorenzo Stoakes
2025-10-21  9:21 ` Donet Tom
2025-10-21 20:14 ` Vlastimil Babka
2025-10-22  3:56 ` Dev Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bx5zarozwnlogznjai2242und55z5jxs4bpgliswuo7shezbma@ri2ocyj7n4q7 \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=jinnasujing@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox