From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 173B8C02190 for ; Mon, 3 Feb 2025 04:57:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DAAB6B0085; Sun, 2 Feb 2025 23:57:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 98BE66B0088; Sun, 2 Feb 2025 23:57:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8555A280001; Sun, 2 Feb 2025 23:57:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 650C16B0085 for ; Sun, 2 Feb 2025 23:57:14 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DFFBA4C6A6 for ; Mon, 3 Feb 2025 04:57:13 +0000 (UTC) X-FDA: 83077424346.09.55BCB65 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf26.hostedemail.com (Postfix) with ESMTP id 04B4E140002 for ; Mon, 3 Feb 2025 04:57:11 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Q0SA6Sij; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf26.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738558632; a=rsa-sha256; cv=none; b=MZR96UOE9DTWuvLavZw7Jv7WHGtsP4c6H52oSmbbUMW9aDdhfCzsED4VxUjWaN6sKMM2Qq hetid+jb0ZW2w9P/EMdWRhZFkOOXNeuFUzWK4/bpieCRb0vy1a5x7vAOcJGBgF6RhXoCh4 aQG/4kBxyRI1U/cWXKdqVBddTWERW94= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Q0SA6Sij; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf26.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738558632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VJjq60zXnUHHajG0I4v7Z4ikwINYuM0Qsned8Y7REbc=; b=UvHtQ+ppwL6D8tSjxuFTF40VgWakzX7/A0/yc781odEEKlYHW8lsDkPjPSCUy2Pu5j9aXQ xrGHdntuuhi4sEZg3jHdnKyu7Ts10u2EQWIRyZZgDw6+7pdbdUdCSFWzmapJGMZIHOLhaz JIpLLwCdlZ4bT0S9NRufMcHf53NU++M= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2166f1e589cso98746345ad.3 for ; Sun, 02 Feb 2025 20:57:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1738558631; x=1739163431; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VJjq60zXnUHHajG0I4v7Z4ikwINYuM0Qsned8Y7REbc=; b=Q0SA6SijTb5n+nTyqrv61e18dCEBQpBQes7VwcmcFZ83dVq5ViRTIxGMihPumKpvR8 FDQ9rLVvLp15gsl7Ge8+MEJXDsvqMl7Ac/R085graV7FmtUgmQGKkNuHgc+TmapY8+Ji TZWQW1cHlRd3trPGKFbktfCRmZcP8rDB1/bss= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738558631; x=1739163431; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VJjq60zXnUHHajG0I4v7Z4ikwINYuM0Qsned8Y7REbc=; b=W3EJJPzjJ+EsOly423k793o91UbYfFy7u1Lt0f3Ry4JzSxJ0UWAyRTLQAr4WpqHZj7 O09mDslOpGDeucFURtBtHkLQblPdQVwn3NUbQBnWp6gazA4XsTocIB9W8BlVtuwSwsXT tKzMXrLhVaAnIeh+aVGQv/BKo7N6SblnVTjqvYWgwWnKMHRyio0YrbXuule3WGVC4jhr DNCtZarp8UQljyMsybxvNwJGmU9WE0acf+ywEC5kzIXEVVjKDk1KecY0ymxm20EbIuJ1 VhuNRx8RwZNqqSZfg29CR3gtVjHJM5gZ9zC8yROiUxfRnB0iH4ZX+FOHNUmNFqRBMNkt wPsg== X-Forwarded-Encrypted: i=1; AJvYcCXU+45O2Lx8A0tWIIe6e+B+1qiYvZOVIN87NC9i9jK95tqcVDTy6vAtcVsCFHw9vGkavwCYiWcF+A==@kvack.org X-Gm-Message-State: AOJu0YwdrCkpo6PT8B5FcLamGR9d+HO/Zqr6WH+SOEAZBxjgt0HiZ8HY /nFDur3g76aJiefCOwnQBtlW1ZCuT/3ptsCXki2/To3jS4doTWqbbEQfWXxLQw== X-Gm-Gg: ASbGncvPkhZKmN8YA8D3YEbwjMLXQsY3/RBOMS0eJZ1aEYiALzdQRrLGcolix/nhx4L KCh0ixiw2uMqMsHin+cnNFDhPWbWfczuerQHg719c9kyEe2YlrTfa3dAfj8mAIzK+P0skZqoW0Y NxEgMD0+WaH9BL7tUvGJHIEBih8HDsReaIJebdua8BZ6jajm1yJXyWDJVRKwQgTRwEiW+vup2mF Jf8JDEvzWZw3k97uLwnXRHGTNy76Hw5yyyduCvDTt7g0rfwDKZcExcVab1L/ZqHw3vINDU0tvJH 48uwy54ls1+diWWr X-Google-Smtp-Source: AGHT+IH9dd9ZAzS3baGwhKzff/ZE0OHYuRzYcLQN7WhWJZWpjKHAWQ9qIm7HZ6YPSjw2kbuJx7KEmA== X-Received: by 2002:a17:903:98c:b0:21a:8839:4f4d with SMTP id d9443c01a7336-21dd7c46868mr280232625ad.6.1738558630731; Sun, 02 Feb 2025 20:57:10 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:f3c0:b0:250f:9437]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21de3320ec8sm66544515ad.248.2025.02.02.20.57.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Feb 2025 20:57:10 -0800 (PST) Date: Mon, 3 Feb 2025 13:57:05 +0900 From: Sergey Senozhatsky To: Yosry Ahmed Cc: Sergey Senozhatsky , Andrew Morton , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 12/17] zsmalloc: factor out pool locking helpers Message-ID: References: <20250131090658.3386285-1-senozhatsky@chromium.org> <20250131090658.3386285-13-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 04B4E140002 X-Rspamd-Server: rspam10 X-Stat-Signature: pgunopg7z8icxoswid7qezqsjr9dn4y5 X-HE-Tag: 1738558631-577441 X-HE-Meta: U2FsdGVkX1/FzrbkkLyrZWUIS3fquUTLa5A9xJvu9SxqzPyO3698b3s8X8z9d5Wf9rZDkzm/LPQctGyryI20ayroaiDn8b/GMx14M72ehfmpnxP5rbXPTV6KJyyB5oRv8cV5QMS2aN8Am6cWIQOLgZ3H+PwUvalxYCqCloJFnTonuZUu4KosoA2lFlbdUggAKn7MMrbML6HS9+NB2anIotMyV1+6LKUwAkJUbml0EP4njFQL9pJ55GMnchmnGogJyf+3Sg197PFq2e24CluIVoPunYUyp/5mT9YprgQarc86GP9n6MNOAYtZX+PzSpLeCjI7cikrKwjvdgPpribrMCd7uniliO7iE14ENWSqJBIbUlE7LUxQJpAUj4+tTzmA0HBY79x65M/ynZLOtrCw9WvpUG/rlub2FDVUZh3JGTcSqr+4R3N+9wW+7px1DPWyHlbZ/E5J76DK5fL0VxsaJN+ywfXMX95IK4y4M2CbYjxcazpTrVLTAFbcdiZrbS972AfzGp8wAzKctXPdjoVlJTgmgRrTguUXQR8/JH97cCwc7gPRM1hAESZltFB4uKj2Wv0sbWTxWjaTpAm8SfQJapP+SdXu7DqUlYxUjVcr+vKAfCcFlSek0hTZx7oDXd/npAzdQTD6KHpX8g0gznbCR6281Ybqw+wVKshbhG3AcJWlDui7ksXb14Z3avaNageIwYOd+bNfVQoeJC98cru1k/TITLGv+NO2vmiaTB8ufmQR/iHwbqPgikZwrZxRa0ac3oHG+PJzA3yFVwwBWz8hXvop91S2ZweJ18AU553VTdDPG1Kq/tI7UIbpxuysqiJ/+m5NRqLHeszCFcgdDPpEAy9qOeK5fGwX6Oq30miwStcJcRGtPtAEAeREr/UZrVhQyHGqAs2sFu5M+L9Vs+D/w4CYPQIQJtBcxctBlWIAhE91NriSy80vzyQHM2f3MRSKE2QUtANxM1HXA4MPAy3 +1P6P7NQ ftAtQGT/spaa58uEF8zqCjyShQksXkPPs+Nkp/2GQHPvsAkTExRTYm3QQ1PnoemCx+dd28y5Wp30wfOT3AuGagNaFCjfy/jRbsurdcT5mwX5qMfOxmLknK6ZpgC4Vv4SRgzoOazcxP2iIlLAmyRGFQKEYurdNzNY3job0SXEtmhRl8/vfENY1LfKOvKDgMAVDozJ6nrPx+ohmVKkQa19gP7fclhtA5mJunht26zcrIceIsCuSyKllixMpkNZRUmBwg/DHYGgfOH59LzqOs0LLu1dgRMHZ1C+tL4jQA1Ihx/NPFWKE23Kt2sVi2EqSfpR+cdtqq1VMIRAczuyS1FEwj2jywNZWeGTIjcbQgpux/fEtZJo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002037, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/01/31 15:46), Yosry Ahmed wrote: > > +static void pool_write_unlock(struct zs_pool *pool) > > +{ > > + write_unlock(&pool->lock); > > +} > > + > > +static void pool_write_lock(struct zs_pool *pool) > > +{ > > + write_lock(&pool->lock); > > +} > > + > > +static void pool_read_unlock(struct zs_pool *pool) > > +{ > > + read_unlock(&pool->lock); > > +} > > + > > +static void pool_read_lock(struct zs_pool *pool) > > +{ > > + read_lock(&pool->lock); > > +} > > + > > +static bool pool_lock_is_contended(struct zs_pool *pool) > > +{ > > + return rwlock_is_contended(&pool->lock); > > +} > > + > > static inline void zpdesc_set_first(struct zpdesc *zpdesc) > > { > > SetPagePrivate(zpdesc_page(zpdesc)); > > @@ -290,7 +315,7 @@ static bool ZsHugePage(struct zspage *zspage) > > return zspage->huge; > > } > > > > -static void migrate_lock_init(struct zspage *zspage); > > +static void lock_init(struct zspage *zspage); > > Seems like this change slipped in here, with a s/migrate_lock/lock > replacement if I have to make a guess :P Look, it compiles! :P