From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 489A5C4828D for ; Wed, 7 Feb 2024 16:38:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83BF36B0071; Wed, 7 Feb 2024 11:38:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C3276B0072; Wed, 7 Feb 2024 11:38:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63D436B0074; Wed, 7 Feb 2024 11:38:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4F78F6B0071 for ; Wed, 7 Feb 2024 11:38:43 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 24828A2440 for ; Wed, 7 Feb 2024 16:38:43 +0000 (UTC) X-FDA: 81765566526.05.AA8A307 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id EA7E4160002 for ; Wed, 7 Feb 2024 16:38:40 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="iMghq/rH"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of jsnitsel@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jsnitsel@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707323921; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q3J41sYakbr7nCpsD0r1AspXJMKiAGuYob6ug5klcDE=; b=2Z7ASt/ci+7j2ln2O8RVWrck7WJCMFxbGoFSoVOoedh6uXamqvPQymSbZf6EP6jUIf07nQ 4bU0GCRpE9xKzDYon3z+KEtfJEoZF3kOid9UBB0DjyEb0aCUiiFOhgV29IvH61CYV4vyE+ slFx8ymIIwXZfVdS5lVlPv1ggp8o/i4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="iMghq/rH"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of jsnitsel@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jsnitsel@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707323921; a=rsa-sha256; cv=none; b=2dLrygxijHR0H3nY62hm/V9x1rCU7kYJbVHKtQp59NXMDcd08yyUsFSLsgHn/YSD5ijYNn L1KolTDmoB1FN61Pe18fTEybAVXFSB0bLMZOOLJUFnAQN5fyZ9+R3xXzBFG0VsuvnIvk1q gAclr5T3YYOAKIvdck+3aTIvWUtJclU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707323920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q3J41sYakbr7nCpsD0r1AspXJMKiAGuYob6ug5klcDE=; b=iMghq/rHUGC5sOFPB8Hi9E7u5n5848J1z4rqtN654xuw8w7jDb0O6sRna4KaDHOvFUH1Lu 0eG28+WHkAvlmUuQWdP+MkLxjzNtDHCZayPYgjttBPaasgrVUCGl4gzsloWJvISdmELXks zLEfe6ehcfzBM5mZ/lRR/sxnIIXe1I0= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-477-hVzthx-zN5ub-8OvEM5F5w-1; Wed, 07 Feb 2024 11:38:39 -0500 X-MC-Unique: hVzthx-zN5ub-8OvEM5F5w-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7853d5e398dso102250785a.3 for ; Wed, 07 Feb 2024 08:38:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707323918; x=1707928718; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q3J41sYakbr7nCpsD0r1AspXJMKiAGuYob6ug5klcDE=; b=MBRVgOv0v/KbOkSXCa3mAH3YPOtHFqMDLS6FsEj8oecBQ/eK/yZkDlwnKQaGouOz/o tRzRXLxzkPfQThXAUC84ciiZS1vt6hKic07xGiM5ng5HyHeiX8T+l8c4CKxp8162l1m2 gu6rhzzFarHXEJNpHOPOS9Cmadme1+U6TlzXYXhMUxv8VwKgSNI3g+QW1jMcpVWU/drk 6N+ky3Ii2jN2VQ/pP/RN3l8fUaEP81HY5aTaoc5DlJN1e+mcb6PdqhUK19O4873/C+ir 1t9qx92icWAjJmDorEls5dHEW4xIskq9gIhK6zq9CWBY+jUkXdTzZDSRV8B88VYRL38j Z0tg== X-Gm-Message-State: AOJu0YzQ1tec0xt0FwAFq0ew4KV2bcv6Jtsak20st7tmWH/EsKL79gVR Hu49QUyng/ElgsD6+81AL2FQh6QoPqWbAAO6c5n81UtAgZh01OmcyCMciYC8WfCz++YpdIfdUZG R0YrZeAKBdDbp+fAzPGDFa1TUb9NfAKHFMUC1Jwx5bT6zvoVs X-Received: by 2002:a05:620a:4620:b0:785:46d6:6453 with SMTP id br32-20020a05620a462000b0078546d66453mr8619129qkb.32.1707323918663; Wed, 07 Feb 2024 08:38:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiEbBDmZmhAUIBjpoTcJxQ/xfWi8GWUZO8r9kZQB4bZdUkJIFsHGgvQZ7LJqnB27/7UFJoFA== X-Received: by 2002:a05:620a:4620:b0:785:46d6:6453 with SMTP id br32-20020a05620a462000b0078546d66453mr8619102qkb.32.1707323918350; Wed, 07 Feb 2024 08:38:38 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXRlQ2kj5BCUsqdr5MMIndRdzdUBRc4MiqRznozuly6meVvpHGVfmkdbwYOUf94wUWuZrYm1uEJ9HtRqkUBtS5lZKBPN+R2DGN8vO6b59SWsRtYXgUKNLh0bU/9FJ3wzFW6urLaUjH2AGPo75FD0sBlLZonRd7lDrG0n3g4Q34FAWnM9ry2cxIemSn++NzGk2K6diNvTBS6UNh3+l3XbQwFJatQ5n651ju0MWDAxcY66G90/uaG4edgyJWxM6m958Bi4G1TL3tMZUvts2+fHxkYsdE6v6YuUiUqYDRdp/2x1SWhnzh/oUzO Received: from localhost (ip70-163-216-141.ph.ph.cox.net. [70.163.216.141]) by smtp.gmail.com with ESMTPSA id b3-20020a05620a088300b007832870e803sm658476qka.68.2024.02.07.08.38.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 08:38:37 -0800 (PST) Date: Wed, 7 Feb 2024 09:38:36 -0700 From: Jerry Snitselaar To: Robin Murphy Cc: joro@8bytes.org, will@kernel.org, pasha.tatashin@soleen.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, rientjes@google.com, yosryahmed@google.com, john.g.garry@oracle.com Subject: Re: [PATCH v3 1/3] iommu/iova: Tidy up iova_cache_get() failure Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: EA7E4160002 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 94eeqksqnm5it6537sk6fik5txbnmdpa X-HE-Tag: 1707323920-282832 X-HE-Meta: U2FsdGVkX1/Rgvy7wW+62zGBHjC6vJpUsd2pfWB4IdpRqfp+16y/g8DZFcxiuLr0z0E25DztmrH//JKbcvLSku+FvqrVyjIQdIVW1OfgZPhAqY6qHdyF3lPin1XjI5dvTCZysG41PZmi8iEiVkiZYNAguw5FG6+NVmUPTV19FvxbxKQxQk/n8xqXj2+3jam4L1hwpMmv+Axt0cLPtsOJlazJEC2cajS6haWH8c7I/yAvGDfb9SvV6b/Mbjglfc21wyd+8KX97lnM/JRXu4XlaCH759Ma334l0fQikOb+kacAG9TBGIumZIy+ehpfix7Kwh/AgmKLdlNTMNTudpGy3PYBawzFVnNFKeRgUgTvFeVaYzJC1gEgd40uLExeH/hfV3Kbb3pLnQ6DZg7hgQenHmPWf6em2qWwi47QWDD9GRFDgf8Y+o/n++M7sp5mouwUF9Xg/5wP8WLX7zkz+//NvDQ8Drbdp/OIFIZ0c8/02RQSp2ERkfSqAy0q1vxFWN+vkyyJACY5t1EB7MQpn9Q1jC07Kph3r9UnoQ2/lytnez9ezOCVlT6N+fPt7afBBIOrFXaLWVyWQfzE4oo9UDS/BWWMDCuzhI3d3zvoi79XlR4jru/UQpQmA+J9DYR/GSDKedzBNLGJre2VX9x/wwQvDKURnuUUVjq5jg97bWGZh+mfbhZlQ586teuYeVHSC9m5KJBn1Am7qIpZzCM8HU8QZBur8Hu54YwYMEJB9iCdyB/BYD+1YlS0izYBdKN64ozp5le96Dt5Ep7b6oBgDoZQmTV+3tN+s7joIPw03/71qisWWz6+t9egXA8rATEvc94UjE3U151IMOe+p8p8qgiJtYlf0XLGmeh7VmZQz7fnCu83ZebFTAFrj5faeTgszG18uGyCqh2LPGnlUQZK7IXS0+yR6BIQB7CY1qms5WC4q3+x9bLqtrovKUhkUCYrl3zWboOoHHwgZvGdejf6caK Z7IvX8Br IVGil9NXKPHPUoLCYeVvgTDGY4gU99xYG8DBBTkwA9NBQZtw+YaARI7O/rL7uybldLOdKqZ4jAEEO86EZtaE6sDaYjfbC1o4khgt4u5o47uB1Op+KNygInh/HH4Z0qGXPu9pj8faubShkJFlPXFUn8rvKjUz09IFySFV68X09Jel/POA0TqF7u2lCp80CJfq/4bDXMEFMnnrxSLpdZ81xX/yuuV4QUbWm/konp11tH/E+ZrppM7RfQluX2kCDexn51Q5CwlG34/2bApaZYhYgRCU4M/wUTdTjJysZpm5tWU9imMxBOvC+r/12/ZrchSxv7VtrNN0C/jmVKEFATgurOM20jaFDW5uaH/uQqvbz3eO36t9bDfuuQlMGaMmVUWbvSnT5goC5oHTM0dAJOWY4bu0fpizUIWWTmYAXVKJWsqX+li1bFBUPpnb1p+brbok5qqylncRCxg7NetwVrwlBxyesWUJkWwaI1vEXbac3mEKGJw8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000038, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 05, 2024 at 03:32:39PM +0000, Robin Murphy wrote: > Failure handling in iova_cache_get() is a little messy, and we'd like > to add some more to it, so let's tidy up a bit first. By leaving the > hotplug handler until last we can take advantage of kmem_cache_destroy() > being NULL-safe to have a single cleanup label. We can also improve the > error reporting, noting that kmem_cache_create() already screams if it > fails, so that one is redundant. > > Signed-off-by: Robin Murphy > --- > drivers/iommu/iova.c | 33 ++++++++++++++++----------------- > 1 file changed, 16 insertions(+), 17 deletions(-) > Reviewed-by: Jerry Snitselaar