From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA63DC36014 for ; Mon, 31 Mar 2025 20:42:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E49E280002; Mon, 31 Mar 2025 16:42:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 095A9280001; Mon, 31 Mar 2025 16:42:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9E3F280002; Mon, 31 Mar 2025 16:42:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CC951280001 for ; Mon, 31 Mar 2025 16:42:56 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 83085A9B71 for ; Mon, 31 Mar 2025 20:42:58 +0000 (UTC) X-FDA: 83283020436.15.8206D70 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf09.hostedemail.com (Postfix) with ESMTP id D98AB14000B for ; Mon, 31 Mar 2025 20:42:56 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hGjJvrV9; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of da.gomez@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=da.gomez@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743453777; a=rsa-sha256; cv=none; b=sipQ5nf2y+OR2zUNIiVGtxvGsoCJntLA09cAGf1ZZgip5wft9c+M+A6sO1azL2NuJdtTS1 LAuPXZuQ7ZbwrdDFbkEVNyH9PUYDAtjWtf2rlbM3xyPx9eQB+AZcuFy4YVLTkHunMOFd8g yZE1wSdHscik+7zUrUXsM9QV9K4eRyM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hGjJvrV9; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of da.gomez@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=da.gomez@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743453777; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/4+htaTdKlFsAr3WTK4pqeaWO1v7uODMfF3mnheG51g=; b=tT+CM7phOMoI/jduAADvDdc2dfj5FPckjWv0GOxE3WqnfQX72h2qnbm6r9rRURs8JS1kUX 29MyqJPV9788cYDX7TatK+3YAx3kPS5dqHCx8swSL0UqR3mngh+4WSpCLO+7E/WeB+4ewL N0Dz/4mSlVA7O0OdN1MHDWSDPzn3txo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 51558A43CB9; Mon, 31 Mar 2025 20:37:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A5A5C4CEE3; Mon, 31 Mar 2025 20:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743453775; bh=jSJC+SD8elUJmWLcQ2xoshtDP2nPAUcKaI9DFXFk+Wg=; h=Date:From:To:Subject:References:In-Reply-To:From; b=hGjJvrV91nnpijsdQ3R94h6G05j2Vm9VRnwRvOJMH8XVUPFQNg0WY1ymNTAPXb9n7 KjYEZr1JPrdj/pIGgMANzQCsaOGz7o9NXa/QpGzq16Ycg9zJeF30Z4LbDQCfT6TW63 Ez7lxQQtYjaC7SuoJXzmWVHyLilP5Sg82PcSWqlAMWWPM0B/kdnvLnZCTDsNAXoHoU wp/kjpDG2vtbeGKzeXlwjqU2DtTN+WpstWC5oBHy4NiMaKQeknIwBrEg1I3KyetXkc TCluz1vNguft1kxys0ZY9gjKkSIk/abThJclGLoRTESLWMMAcOCC3gLDWlTvVvEYQE DyjB61ZLTKLXw== Date: Mon, 31 Mar 2025 22:42:53 +0200 From: Daniel Gomez To: "Liam R. Howlett" , Peter Zijlstra , Ingo Molnar , Ravi Bangoria , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, gost.dev@samsung.com, Daniel Gomez , Luis Chamberlain , R@macos.kvack.org Subject: Re: [PATCH] radix-tree: add missing cleanup.h Message-ID: References: <20250321-fix-radix-tree-build-v1-1-838a1e6540e2@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D98AB14000B X-Stat-Signature: nrozrx6fj7qjucqpqtwrt7pt5ujr91i7 X-HE-Tag: 1743453776-243285 X-HE-Meta: U2FsdGVkX1/d7UEegiX42EHdl99dAXFQ0dQ02sQvkhoc5flPghfMc0RcLQKdCL5OAxZ1nuGZEKwmzMPbfNYLXOBjgsfWWQ8qjITgK9X+GRFDvwrojC1asojlEd0KM+jWeM4ZIJhvRgtZtlyIRB9kN14WDGFIu18gXNfgHm/xLbEPS/MtSS8eDOAb4leG6Xa6gd4nzqOWxztf5koU3QA0JsYx6BGyFOxkH0/3+Ue7TG+0ryAgrJWpiNy8vnIP8jvvuZe53nTdYWA43Xj5RTaE4bQxpfgl/w8Js/a0R2uhTAvxxdKvsG+3oV6n7L9ihM/LmTT73SgLCajkp6ZhT2yr1vfC11tZ+Ln3aYgYh2uEJ81TvhErC5k2OrlZpMeR7FQ16qo5n1xHWVNfTIQ3Vu2rJwPQ9njU46jaHmcYxODEqYiY+fs6DDXKSyp0E5ZcxzV4G97bZPMwZf5kHTngv/UvMRFSeOD7ASDe62Bd5ualCgs2sZVC6sOnkaxYhKwAR+L2nr0C2dVZdXmGQBM+t9x+2kzI30d8QzizPAr/UizJ8pfQEfrqGXwB51O6BgoquUhzJKNcwKFnL7U6Dv8j3AfEo+DW7Xuu/+9n8ZVpUmaRfNb5KKRQTMjxOu8M+b3OXzU4PtHwtMG95cDOQOobNPe4r6o21/xBpi6rMyE9AcA8HfKF64k7UKsvLPKWf5NhtieXsF1NSORxjb43nwYSptmaox87JDnd4R6IfabxRN/KogwGEwvFwP1VF475jxQKEW3L9UNX9XqqzqMw3ez5SqbC1BPuizrc9xeH9KlU8xrAThTrK4oPCefYIsR2SjUUqwBWPtiY5FmhRF/Sp2y0DqtmSGinLUzyoTlDgHUcPKAZ5nwNLRMoWaqRYVmlzRsoEFP5Xwu0FKjkFOFJ6DQ9tZMDg2tFvtqGstpyaqIesMWAu17SpMkvmSOOLPjyszIJObFFsX/bKYMA9gnsbMX6e5d zOJiVPi8 jdSvr7gUanCoq8Khh5jj7JEnHHQFkRHuw2+WPnnn5/kCqGHic06MhhNhVCQykowiKUyXIjBjvWIJFX6JKlfXIiZ53Zlquuv+GEqVPNLIZFKJmVQKvo8GpjGGkNXu1rzkhLvUaciK+7eoADhXdksQ5tF43PdsKie8YISxrRl8XRWQFx3ikB3tOFLGykVQQvWnk3koLCo4c9oKnoCAkjwcDpqKkOO7bh4MUXyAtnWeKPmS5jz7QDuzFH4JL3QgSxTebEOOws6QRE3j6ZM/hJE2a6T+Uj+D4896ZdaYn3cMc0TW3ZY/aBaEU0PnF6C/ZENfsQJdF5fsMfrtKlno0FldU4Q99B9JMTc1XkrJkIQ5oCa9owbgCvfex0WRpa9aRW4meDcYDllQIScCnr3eBCzQQuyjL5Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 31, 2025 at 02:20:32PM +0100, Liam R. Howlett wrote: > +Cc Luis, as he added this task to the kdevops build. > > Is this going through fsdevel or linux-mm? It's not entirely clear to > me. I assume fsdevel as akpm isn't in the email header? > > * Daniel Gomez [250321 16:25]: > > From: Daniel Gomez > > > > Add shared cleanup.h header for radix-tree testing tools. > > > > Fixes build error found with kdevops [1]: > > > > cc -I../shared -I. -I../../include -I../../../lib -g -Og -Wall > > -D_LGPL_SOURCE -fsanitize=address -fsanitize=undefined -c -o > > radix-tree.o radix-tree.c > > In file included from ../shared/linux/idr.h:1, > > from radix-tree.c:18: > > ../shared/linux/../../../../include/linux/idr.h:18:10: fatal error: > > linux/cleanup.h: No such file or directory > > 18 | #include > > | ^~~~~~~~~~~~~~~~~ > > compilation terminated. > > make: *** [: radix-tree.o] Error 1 > > > > [1] https://github.com/linux-kdevops/kdevops > > https://github.com/linux-kdevops/linux-mm-kpd/ > > actions/runs/13971648496/job/39114756401 > > I am quite pleased that you saw and fixed the issue with the kdevops > running the testing! Thanks! To add more context: As Luis mentioned in the "maple tree / xarray CI ready" thread [1], we still need the kpd setup to run kdevops on patches posted to the mailing list. While we wait for that, we are running maple and xarray tests with kdevops on a daily basis using the latest linux-next tag. That’s how we spotted the issue. If there’s a more relevant tree than linux-next for this, we can integrate it as well. [1] https://lore.kernel.org/kdevops/Z5u6UH2r-co6jS_u@bombadil.infradead.org/ > > The URL seems to have expired, so thanks for including the failure. > > Can you please not break the link across lines so they work with a > mouse click? I believe this is an acceptable time to run over 80 > characters. FYI, this is an updated link pointing to a more recent version (next-20250331): https://github.com/linux-kdevops/linux-mm-kpd/actions/runs/14173886747/job/39703944372 However, I think it's not fully visible outside the kdevops organization. So, it may be better to remove the link from the commit message. > > > > > Fixes: 6c8b0b835f00 ("perf/core: Simplify perf_pmu_register()") > > > > Signed-off-by: Daniel Gomez > > --- > > tools/testing/shared/linux/cleanup.h | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/tools/testing/shared/linux/cleanup.h b/tools/testing/shared/linux/cleanup.h > > new file mode 100644 > > index 0000000000000000000000000000000000000000..6e1691f56e300b498c16647bb4b91d8c8be9c3eb > > --- /dev/null > > +++ b/tools/testing/shared/linux/cleanup.h > > @@ -0,0 +1,7 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#ifndef _TEST_CLEANUP_H > > +#define _TEST_CLEANUP_H > > The "../../../../include/linux/cleanup.h" itself has these guards, so > probably not needed? They are not the same safeguards. The ones in the other file are "_LINUX_CLEANUP_H". The solution here uses the same approach as in radix-tree.h. It's probably safe to remove them here anyway.