From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22A7FC3601E for ; Thu, 10 Apr 2025 09:31:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A243A2800D2; Thu, 10 Apr 2025 05:31:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CF7E2800D6; Thu, 10 Apr 2025 05:31:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89A852800D2; Thu, 10 Apr 2025 05:31:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6C3572800E3 for ; Thu, 10 Apr 2025 05:31:24 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DB7B3C07DB for ; Thu, 10 Apr 2025 09:31:24 +0000 (UTC) X-FDA: 83317616088.22.862F49E Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf10.hostedemail.com (Postfix) with ESMTP id 13860C0007 for ; Thu, 10 Apr 2025 09:31:22 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VjL9FtRZ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of da.gomez@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=da.gomez@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744277483; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T9voPN3o8r4hlzDBNRrVfxlEaTNtX1vDrxYLQohj4NQ=; b=qVML6Pdp638jD+6YmgxWyO8CMlMjOZ2/oPdRXUXNngf/V3UBOVkP1BS7GI50MEF2FOk7oa O8l0U2aEats5PZ0KKQAe9Cl0ZhmpM4BYtcByelElPcITjPIoA4sEeI4WmsSXnNem01mgW1 BV3k2Fdr8yl6hh/SvNOTZZE3dBJV8Kc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VjL9FtRZ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of da.gomez@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=da.gomez@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744277483; a=rsa-sha256; cv=none; b=QhTHOpC6AJuvT/1YR7waEWv8rrQfcZ905DAzQ31nATf/nmSsox/1vmRb2iuDxC1uwL7F61 hI7C9uZv14JE2kEJi8UZKXOCfF6Gc5Dz8YHcrpzoUjBlBrb4R7cBSQmzRiNmMq90JbE8pn xzFcyvVpZ8TZ9qOuTH60zB6r91TrW38= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id E39B149E09; Thu, 10 Apr 2025 09:31:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23F6AC4CEDD; Thu, 10 Apr 2025 09:31:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744277481; bh=NUQSl8+KNt2Gck3bg5zy+/lvTkACE7uM59VfdQMYJzA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VjL9FtRZYiAIUa//U1cc/2gKUgnwvHeK4bT+9LIGC9mtHU1f4UcjRF0h8D7rOx7pz iR5HtXzcxamzNeae3/JNe/gPTy7boaa5FX9rOMKNiug9wVM0NIp6ZsP3YrBz8ld8hC emGVRKGBrQZolj9q3AkTLhoPDH3Cmug/BsiPEJafWnEdVDPuWXvw4oPf7MVZ883aIT SJ+/eOuPhOaJ8rHhdMAey+nmq2fZo514q3YXzOeVeKf81mzqfrbZtp/H00V0m26P/k 8ejdZ+VOEcTpTcNVTPAcNqpNmuKDVGm/wMQYhjBLxEDHI30rSti3DVMXfe8kASLaYC blPbZfprIw1cQ== Date: Thu, 10 Apr 2025 11:31:19 +0200 From: Daniel Gomez To: Luis Chamberlain Cc: "Pankaj Raghav (Samsung)" , Andrew Morton , Jonathan Corbet , linux-kernel@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org, Bagas Sanjaya , David Hildenbrand , gost.dev@samsung.com, linux-doc@vger.kernel.org, Pankaj Raghav Subject: Re: [PATCH v3] docs: update THP admin guide about non-tmpfs filesystem support Message-ID: References: <20250404140657.29285-1-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 13860C0007 X-Stat-Signature: rke49693cim9qwdh59wc6intdxttwhoi X-Rspam-User: X-HE-Tag: 1744277482-205162 X-HE-Meta: U2FsdGVkX1+3MwtsIap6DIzsEz/dNZpmI+Y9iz3OTGHDSU4kAvr2C5DysloHr7UFzQCF9PRDZzx057i6rXFwCD7HG8fqYRr28j5IsRHu/LkF5keNyJmXlD1fABFJfymaz59sNmVazeXO4cDut2fuCpBExS0HjoAhf+VGn6dqMEG/OZXaiiUNSCMg56yTqC/pEvUBg/dhAYuzYu7grR9Vwg3cnRFz5E0z4daNqhERndke36ih6XdQ6QtFuOpTOARXbQpzQMK6Oc86zVlKfzCj0aHbmXjrXuSONvx/GX//Sa2zZ/ismobkwnbKbWz+wnac8TTAhtmzsGLNaJx2u1o6E56o3Erjgvptzqoa35pdUtYHbNYamlzsm/V8CsovS9l1rtJy+6bY/J3+QozN0pVm4xlZ3mBtot+Y07vA/tdcyX6X6FBf1S1Cy+ReExYEedYfHWgZzCGYiakC+j3HVQPNT0xaOjhzXRlq+xQh10w22kUbGx04Lc+2KOA+9xmk/1udJyDZpO3M/0a6GRoegvR9/8+LRLew/GleGVwkwgObohdUh5XQQXqB5dvXZN4oamlAqs5MFKwG8Cnwxncu19YOBX8RG2foHtNU7mC9OeuvpeLGjU7iFbD8q+vS/IfZVBJzxowzT6oVcGRnYbPI+1ONR+lfUY+/3sh/YViAnCJIe75I69ezRi9Vl6mW94tAx55sXGltU16Zw6djktLHsx7Vgu7aWlAM8/dnqPX7TZ7sW5nOXgn3oH2zUhitrtEt1NNubFLyb4vVMONFRxbznimVL+Ufgam5IjuSCCkv4EB8sJmc9fYB9olOory3SeWCYuHvXA1ZDa8Y0z9rhb4gnS795nKLHUTUx5pA0JnxtaxLxv5c1kIdk53EDHvNep4TXTh/Rx3dUfyWBZNTqAYeJU1wpuXIQeBWVHC0Fipf8H8Nt2YwKImY7UH/qnxLGK2l251qBaVqTWzguJkKt6ud1o/ 9m+uh1u5 jybKhzdHXUcommCpKHspTcsha9smryt+meILpwW3chAeqQlaVRqf9cRGfhF5dOsL1s2rn1DDqQLRdhYdkYhhvS8MvbPQ8AxQgI5RJVgGFOthSLvswy2wPt/e1QNgSubvC47y3bg65BVMKd+GgUuL66HCPqcM6/DSQZyAh89NweGYMOd0legYRucZof2nrnTi8pyTpDN6eRgMfJbJB8QCWL4qkHALsmWmotA0hBS1ADMdjxEilAK+y4iER9h84gkwfYSx0a32vjF/uRxGPaZ5vaCbQq86m8h4BAPYmORVgvOVWGNYf/ko0aX26dUVF81CtWXEpkBeE4NPxC6Mas0sX5bX7qAkwo4jPuxT8GQsbMpr3RS8yuzFDqWGHRI6mlkoZpSTE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 04, 2025 at 11:02:46AM +0100, Luis Chamberlain wrote: > On Fri, Apr 04, 2025 at 06:31:16PM +0200, Pankaj Raghav (Samsung) wrote: > > On Fri, Apr 04, 2025 at 08:32:15AM -0700, Luis Chamberlain wrote: > > > On Fri, Apr 04, 2025 at 04:06:57PM +0200, Pankaj Raghav (Samsung) wrote: > > > > From: Pankaj Raghav > > > > > > > > THP support for non-tmpfs filesystem has been around for some time now. > > > > Update the admin guide to reflect it. > > > > > > > > While we are at it, move FilePmdMapped to previous paragraph for clarity, > > > > and clarify ShmemPmdMapped & ShmemHugePage. > > > > > > > > Signed-off-by: Pankaj Raghav > > > > Acked-by: David Hildenbrand > > > > --- > > > > > > > > Changes since v2: > > > > - Address comment from Bagas Sanjaya > > > > - Squash commits and Ack from David > > > > > > > > Documentation/admin-guide/mm/transhuge.rst | 22 +++++++++++++++------- > > > > 1 file changed, 15 insertions(+), 7 deletions(-) > > > > > > > > diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst > > > > index dff8d5985f0f..f8aae64e38d0 100644 > > > > --- a/Documentation/admin-guide/mm/transhuge.rst > > > > +++ b/Documentation/admin-guide/mm/transhuge.rst > > > > @@ -12,8 +12,8 @@ using huge pages for the backing of virtual memory with huge pages > > > > that supports the automatic promotion and demotion of page sizes and > > > > without the shortcomings of hugetlbfs. > > > > > > > > -Currently THP only works for anonymous memory mappings and tmpfs/shmem. > > > > -But in the future it can expand to other filesystems. > > > > +Currently, THP only works for anonymous memory mappings, tmpfs/shmem and > > > > +filesystems that support large folios. > > > > > > That seems to allude that THP can be supported on filesystems > > > that suppor large folios. I don't think we want to call that THP > > > > But we do allocate a THP in the page cache if we support large folios. > > > > See [1] where THP was supported through page cache. From what I > > understand, THP support was added first to the page cache and then large > > folios (orders in between) support came later. > > I see, yes Do we want to clarify this further? According to this thread [1], large folios currently depends on CONFIG_TRANSPARENT_HUGEPAGE, but that will be removed eventually. https://lore.kernel.org/all/ZPINmXyTgy2wqLqr@casper.infradead.org/ I agree this needs to be clarified. THP for anonymous memory and tmpfs/shmem is not the same for filesystems that support large folios.