From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C298C3ABD8 for ; Wed, 14 May 2025 16:39:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF3CB6B0198; Wed, 14 May 2025 12:39:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2F3E6B0199; Wed, 14 May 2025 12:39:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FBB76B019A; Wed, 14 May 2025 12:39:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5A6C56B0198 for ; Wed, 14 May 2025 12:39:29 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1EB13BE68B for ; Wed, 14 May 2025 16:39:30 +0000 (UTC) X-FDA: 83442074100.03.1069BC1 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) by imf24.hostedemail.com (Postfix) with ESMTP id 1F011180008 for ; Wed, 14 May 2025 16:39:27 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VMWuD3Zf; spf=pass (imf24.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747240768; a=rsa-sha256; cv=none; b=qcRZwsuUxWJqRFzf43OFjmSyehT1Rdt02b6AdAy+w9QJEnvK5tspQVh0SekOChDukRw7w/ THRcWYL2eobru8bguoQtrKiWSLmQOIBz/o/8LZ5Z0ekGes5xZZ0WPj5V84PDjH/NdHRZSU ExEgOVRS8pxWztxYs3vpW1VrEdMjV00= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VMWuD3Zf; spf=pass (imf24.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747240768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/xWysm/w4j0tfuTGmtdmeiPQvB/oeNRyr4xijzKsPPM=; b=sfT4Ld4Zk2NR7luQTF+JO9tMhx25qoK3rlOfQGLPwY4v9elLcj2H36gaP8dxjrvm9dmqMo qSNJvP2avsQ9pCAT7qaYQuH7JSGlrIGC+kDNhGMNO4SJ4IoL7SSCX3ovJ/jOaCb7VJz6Sa sY3ZT3sGbnLRq9BDOOoK9UtuqAKUHpo= Date: Wed, 14 May 2025 09:39:15 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1747240765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/xWysm/w4j0tfuTGmtdmeiPQvB/oeNRyr4xijzKsPPM=; b=VMWuD3ZfACb2Ls14tQJ6HXUOUKgV3OvLhyn/U/jHgtuxbvNJ/MMb5d1jb3KA9MSVrSj/24 nVk2Bq5GmgzyQ23cNPg4ARmKuhrKo/divVMJijkDn7h/2EXKn+f6L5iKLYGJc3fSyOAkdy WCBR4ejOmuv6XRaKQ+1n5wR8zOctWJY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Vlastimil Babka Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Alexei Starovoitov , Sebastian Andrzej Siewior , Harry Yoo , Yosry Ahmed , bpf@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH 1/7] memcg: memcg_rstat_updated re-entrant safe against irqs Message-ID: References: <20250514050813.2526843-1-shakeel.butt@linux.dev> <20250514050813.2526843-2-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1F011180008 X-Stat-Signature: 88uhsceaito59gx5y1ke5bxp4wpymbsk X-HE-Tag: 1747240767-517079 X-HE-Meta: U2FsdGVkX19h4762lAcCC3LdxNV2E/bGeyRyehLCQTThrLfGYByL5760TSPJ8EPGoBhtOAEZ+Y51qWp0kXgppCgPtBxWu5HKMDVlUbd0Nut0moslcHTXIaamLopy3kf/mWre0p+Jb/VCK1l7Ux8OeuS4IjGELyHzchddpq+sFVYyKufO5mzdydJzChZ9mWtGW8sXz7tko15nuLAEZvP7MNnvQX6YcJxSsb5a+v50X1BqfQzjs5y1tHZTanJRDpA1MxYQWzTUdMXRSZMJDkqC2szZVhf2+OcykJeptOYhAvHjZ/B6TqW+E2b8M6C+eKE/Bz1npXzQ1J/zp5wbaPdRyMJvEKCdX/8s3/3x4byLMEWn95DDonEuqXiItCXMdHwe+7hL9Vhb+vq/D5FM/DZ+am+8v+4BjOwhFUGibjUqSLB8TUifH1hLNU6H85YE00S6tv/vDibzFrZw8TKkkpBRTkm987OpHj3VOgg4rYha1ln6SCX1Vk5/Zenky2yRtWD1HcAOu4I5wJ17rYY0fMcgq1pfD9pAiT0K+XO6ChUOWZLd6p1UF6vrcn8V8xDEIh6uDCCbSYOvhm7LSyJh2Vp8D+NANZ/jVhJtak6m3Wfx6rMZiW63WdKmmcAix3LmI36rGvBqCXjpykJcUtsRW4MJ/x4hbXIxfDB8jecdRK4HGq0EI8P+9wQA6G8iZ1NzqYO2/3x3470UuxR6OO+i67Ji9gy9oqv6DQuq6NmmhIed72O2C+pey0mTmtfsCPOp3Osk//VDo/iDWh/HzuADPe5zX10Lf/pUEig9ssky8PVL6wIJa2UzhaLVO2UxNdrndRGr2aJDrOyzLnLFo0BENjDiKL+CSyMMwO+d51Bu24NjnrcVOvFGyG9b6XIJNkR35Ci49kBZszJjK3lzyYLmM8fJs2AmSOEkxdg+0DsBt3uVQmVrytLDaNmgz6EDx4MV5kJsGWsjJ6Ha5NjDDI2lJLH d+Np3TmJ Y6M8Wx30jK+Kec8/ISqv+5JKHdOUSsBj/ykgxyMES3F42XA42sMrWUEry314fJ3Pkxfgu6EbijfzyX4qUraH/tsmsIM9tDpsq0u8Am+a1xyd0zrsGm7jZ0D4h/t7oBN/JA53YMnb0Z6X/q5VKAcUd9XaHcBr5Yai6pLcVZ9XQu8OI/ZqtFRywMyVUodCYPhtcT7eHO1CQ5l9Cw/EXzB/tborAcw2HUrmMtIsP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 14, 2025 at 11:50:16AM +0200, Vlastimil Babka wrote: > On 5/14/25 07:08, Shakeel Butt wrote: > > The function memcg_rstat_updated() is used to track the memcg stats > > updates for optimizing the flushes. At the moment, it is not re-entrant > > safe and the callers disabled irqs before calling. However to achieve > > the goal of updating memcg stats without irqs, memcg_rstat_updated() > > needs to be re-entrant safe against irqs. > > > > This patch makes memcg_rstat_updated() re-entrant safe using this_cpu_* > > ops. On archs with CONFIG_ARCH_HAS_NMI_SAFE_THIS_CPU_OPS, this patch is > > also making memcg_rstat_updated() nmi safe. > > > > Signed-off-by: Shakeel Butt > > Reviewed-by: Vlastimil Babka > > Some nits: > Thanks Vlastimil. I will address your comments in v2 and Andrew asked me to rebase over mm-new instead of next which I will do as well.