From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51728C369D3 for ; Mon, 21 Apr 2025 17:40:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88B626B0005; Mon, 21 Apr 2025 13:40:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83A606B0007; Mon, 21 Apr 2025 13:40:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 703F06B0008; Mon, 21 Apr 2025 13:40:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 551366B0005 for ; Mon, 21 Apr 2025 13:40:00 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2943CB6721 for ; Mon, 21 Apr 2025 17:40:00 +0000 (UTC) X-FDA: 83358764160.27.2180654 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf08.hostedemail.com (Postfix) with ESMTP id E733F16000B for ; Mon, 21 Apr 2025 17:39:57 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=bDulU4eR; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=6G2lmqLi; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=bDulU4eR; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=6G2lmqLi; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf08.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745257198; a=rsa-sha256; cv=none; b=MyBuyKV/xI/WwyaSa0lqfGftxqKaRdJIg1vRizmlwtRW7TIHCDZfpd55LkZWJ+YYk+1mUe mPce1U17LCht5dVLyaRCvNBx6kqkmJBPHj5fY1oAO4ZKnh0Rp3evNAjOpf54GBXz1uAFLo QqTRSUxNSsoYf7F2qTOCdkQU1VPx4ao= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745257198; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EXmDV2NTlrhzoeaQPnEZB931iPAN+blDYH7pEAZJ4qM=; b=woKAcp+v+C7lvlZYclcrImQY63SFXD2tq65vY1m9XnbL+/u+Q93yLhYXGde5rGhZRegeH4 9UY0blEJEHT6mDBiXpk9NCcoz1DCGcUqS7WEfBryzVz8vnVB4ZUzscKLzxQUSQfkLC0Keu vTy/1eL1h6wYp/OnQcNcppuZ6Ie3eKI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=bDulU4eR; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=6G2lmqLi; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=bDulU4eR; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=6G2lmqLi; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf08.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 11BB921202; Mon, 21 Apr 2025 17:39:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745257196; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EXmDV2NTlrhzoeaQPnEZB931iPAN+blDYH7pEAZJ4qM=; b=bDulU4eRMZWRZ9FcBsmv/7u47mSjQiDFv1phx8iEHruCl1mdCet1hdpg2xQFDGVUuxOFWp UOsgK0YGOcNtbxlg+DvwmM+GFb0TSBLE/KPcla4GW8CumoGtPWQGu5lbM9M6bFDwPLjkSl vzbFtppuXpODQ4bNzISQ4h4Tk1QZoaY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745257196; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EXmDV2NTlrhzoeaQPnEZB931iPAN+blDYH7pEAZJ4qM=; b=6G2lmqLiOh8+3mNdzuzsKL7IN7V5BmFZgVSNKipyjFrgOb4vC+O5o48LzKBDv98GZ7CnF4 6A8+lEqaSTcMBuBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745257196; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EXmDV2NTlrhzoeaQPnEZB931iPAN+blDYH7pEAZJ4qM=; b=bDulU4eRMZWRZ9FcBsmv/7u47mSjQiDFv1phx8iEHruCl1mdCet1hdpg2xQFDGVUuxOFWp UOsgK0YGOcNtbxlg+DvwmM+GFb0TSBLE/KPcla4GW8CumoGtPWQGu5lbM9M6bFDwPLjkSl vzbFtppuXpODQ4bNzISQ4h4Tk1QZoaY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745257196; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EXmDV2NTlrhzoeaQPnEZB931iPAN+blDYH7pEAZJ4qM=; b=6G2lmqLiOh8+3mNdzuzsKL7IN7V5BmFZgVSNKipyjFrgOb4vC+O5o48LzKBDv98GZ7CnF4 6A8+lEqaSTcMBuBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 981A9139D0; Mon, 21 Apr 2025 17:39:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Q4FkH+uCBmgwbwAAD6G6ig (envelope-from ); Mon, 21 Apr 2025 17:39:55 +0000 Date: Mon, 21 Apr 2025 18:39:53 +0100 From: Pedro Falcato To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sebastian Andrzej Siewior Subject: Re: [PATCH] mm: workingset: Simplify lockdep check in update_node Message-ID: References: <20250421-workingset-simplify-v1-1-de5c40051e0e@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250421-workingset-simplify-v1-1-de5c40051e0e@suse.de> X-Rspamd-Action: no action X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E733F16000B X-Stat-Signature: y88tpswhxffuecp4u1od9mkuckszpuqk X-Rspam-User: X-HE-Tag: 1745257197-960098 X-HE-Meta: U2FsdGVkX1+VWaOshtwYU4hBRLdXvPDqIYADfXkXLy2cwxx/AQCNQXrOa76+SleVxOGN8QrH/JF+YBuJ0YVjEInCij86S7wkyQOJ82dP+NpN0NcZw1LHhkSmRfNucI7wOG0U3xGjDGI8ta/ls7ONp9wseBo4DjEYdzyT9CSQgUjWHCcMihWKm2CE/FkphO/UmnfjoZ2ANZhfG43gM3oSHT2umT2T7REaUCUAARNhZ8xwnK/vJ2nD2qpb8AUYARmxrIgjPfPO8u/7U9jPfjEhewSLpMp7EODIt5Qv18qTTLGXKy2z2ihDUQ2uFilsPVkeCLaOfAjlJ7EhNyyjigh5f1hI3Ec+Cqrh9w2QVU7O93ZJLPG94+GBji48nkI/TDxEIpy2A0++ccNzl27YNIGWybJHDOkaMBSWhAUcnX0iayHLFBNTEYBvnrtj1m1e08cUfVVF0VHd1Vk/HPNDfGrsG3/NOti+4/wkr5I2yXS/2TAZoe+Ldo2snv1P8GxculdGohf4sYBjPgX7lQPeRje0ESlANpFFJIPprJxNcDhiIqSStk9nn2y34OZ2HEkULej3xQwwns/WQG5u5yG+nr1VgLNDWc3edl8wt4alCKtL53sxqMbY2D4mzog/kZbBxpaHRWeEPZJuQ9rB0e9j0LZZjE7zk4VOBonrKL+Vji+c3Oy+IP7vIkKjco4z7vpEfQJBiyE8q0wLTMFzIIg0/S1LyhFfw+88xoUsk8aw5cSwnrD1lovcEJCs+uEpiTnBfqjH1lXXeXlcVytFQp9glufbXiOQdQKkCV9OV4sMeNmPwMyZVMpaiHmUwjGZn4oQbYnt+Wdw5olqE6Krp8D14Hnf+ZsZpMeQUmTUO2mxe6yPKms7EWebrHcHt1J4qTSVUEEvlbH9KqdzhIWN6AkpISg9hQsVtOUqxe1P+seniAUoC4KUOdEr5Do/p5qTvIYLsqdEyIsydRiS+gsWzVlq3R2 odYCDmz0 IJQ0DbZPOo3KdRxR6GliD4lWgAKCYT4hsoXembaCt7TrU02bLUl8tDF1Wo66hxA0OKiHS6eNmvfOZkZFEdExkenP7iR2NUpNeO2CAZQQ8bjKji9iqaqBFfaJBHOUWJ91ZfhGQo8nWmlc59U5+OzwaVlIMV2Hxy6efg9X3628c/MYA42Mm69eWjYOzvdHq7e/dOFMUpF4lEL1gEnpfslgcuXdl8KkGqoT5OqrWQ6rydx1nkxz3rYuPXlKRq1nZQZsFDBgGFI0M6uf8jetu1mqFX7onw3zR+3BMlCM3gAlcrxCmKWmBwSJrC5B/btmLMf06tnARCM8OviR4ZL1cd7EKF06XjqRAjsSyjF5x X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 21, 2025 at 06:16:28PM +0100, Pedro Falcato wrote: > container_of(node->array, ..., i_pages) just to access i_pages again > is an incredibly roundabout way of accessing node->array itself. > Simplify it. > > Signed-off-by: Pedro Falcato > --- > mm/workingset.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/workingset.c b/mm/workingset.c > index 4841ae8af41113797378846f08336cd7c5757bd5..6e7f4cb1b9a7807e9288955f180a5b6cffab1a40 100644 > --- a/mm/workingset.c > +++ b/mm/workingset.c > @@ -612,7 +612,6 @@ struct list_lru shadow_nodes; > > void workingset_update_node(struct xa_node *node) > { > - struct address_space *mapping; > struct page *page = virt_to_page(node); > > /* > @@ -623,8 +622,7 @@ void workingset_update_node(struct xa_node *node) > * already where they should be. The list_empty() test is safe > * as node->private_list is protected by the i_pages lock. > */ > - mapping = container_of(node->array, struct address_space, i_pages); > - lockdep_assert_held(&mapping->i_pages.xa_lock); > + lockdep_assert_held(&node->array->xa_lock); > > if (node->count && node->count == node->nr_values) { > if (list_empty(&node->private_list)) { > Actually, not sure if this is wanted given the original code is a little more explicit on what the lock is. +CC the original author If people think this is worse, just drop the patch, I don't really care - was just checking out the function for other purposes and found this bit a little confusing. -- Pedro