From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 923DBC6FD1F for ; Thu, 21 Mar 2024 22:17:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2086C6B00AA; Thu, 21 Mar 2024 18:17:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 191936B00AB; Thu, 21 Mar 2024 18:17:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00BF06B00AE; Thu, 21 Mar 2024 18:17:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DBC806B00AA for ; Thu, 21 Mar 2024 18:17:46 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9E82BA05B0 for ; Thu, 21 Mar 2024 22:17:46 +0000 (UTC) X-FDA: 81922459332.12.684DAA0 Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) by imf27.hostedemail.com (Postfix) with ESMTP id 0873E40016 for ; Thu, 21 Mar 2024 22:17:43 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=FZysDbxQ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf27.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711059464; a=rsa-sha256; cv=none; b=ZpqPv0HDOFFqVxIjvs9pIUoisWyfqXk0WQjOcN1OScY4iysrcIvJgbZTYpW1oF1ySzF2S0 ruRreo76dLYStLP3s+SA92bQwcBmW6XKUGgus0qFUxJw4L8oupVsPvPIPTxvrh+pbolaMX cKRe2TEERt3LyfIZgfyLDS+VUM8/2UM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=FZysDbxQ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf27.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711059464; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Avwu9Obvo7iLXBxmizf/EO08qQLthSdSW59GBeW8H+I=; b=sfEF9joXkNpDnPrGiOLfJeCzSWVV8PGobYHh/gWB/ZXXH7M12O68FmTFe3JxOzsYb1msEU 66SeC8QbyKIdn4VAKbBohGXBlvDUQ2u6qRBuB3eAb7zh1AzYLX2fkwTpIkSSa1RP58Ahpc Ci7rLOt+8N7u8pum77OdFjhiSkvtxC8= Date: Thu, 21 Mar 2024 18:17:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1711059455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Avwu9Obvo7iLXBxmizf/EO08qQLthSdSW59GBeW8H+I=; b=FZysDbxQhjIXqR1pi+xqtUgFMzj7/eEwMfqFXVNrKP4hKoq2eMyg+mr0CCyz9L7KqFOgHR p5O/ufNLq1uDGvJZh6zage2q2y2AKKbqhiaE8rWYbulPbyHbczbhEbHNktWz0RHQl+5yfX htak4lBJXiAjgjdWctvpqD6B01G3FgE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Andrew Morton Cc: Suren Baghdasaryan , mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Alexander Viro Subject: Re: [PATCH v6 05/37] fs: Convert alloc_inode_sb() to a macro Message-ID: References: <20240321163705.3067592-1-surenb@google.com> <20240321163705.3067592-6-surenb@google.com> <20240321133147.6d05af5744f9d4da88234fb4@linux-foundation.org> <20240321150908.48283ba55a6c786dee273ec3@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240321150908.48283ba55a6c786dee273ec3@linux-foundation.org> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0873E40016 X-Stat-Signature: wfgp3q3d4uwfqcmj6hp7qf7z1hwys7p9 X-HE-Tag: 1711059463-792366 X-HE-Meta: U2FsdGVkX19ETfSvPapuDMcHqH9LtrO7vH/UIR3hLr3JkowV1zb5wffeWu6JyAs0jHSj/ckH/EsQZfJVaREJU+GyY+XMq5HkuqbkYswFp35k8YunrkdHTRLfCgnBQJlU1OKzLRAVDPmKxLGXRnvXVLBiYUWdv2SR2WXWp4FRhkGUsCcocgw4DdutpiQLNqFPNVAg5lHAfdNciG+u9hukWjLCIPUzimN8jaPu2bnOjrlof9/10r4Ln02QaIHVuR3Q2rIyvMXWXgkZSgviC3BdzBlB9OKZx5/gICfFPUdl9q2cDoJb+Ve9iV9OoZRMbnpX0gOWuViZW2nEInBsYS+KXleRG1KoKexhQj48CxBhNPehZm30+T3S9J9tM+k8CJYXQhBB1awmmY6F39OdmE9xV+99WWrupM2lxP+UMDHkIMSBoQ9+SVKjaN7Bjg4oJd119O/rWHzFu97Qxh0v2YuqHMo2r90vmP5hAD7COZwVPdHptdzW9csCh+3G7+MjtVJfHiAmiwcFPKa+5Q34wt37DYdJwEpDQ+7U/Bv+AcmiEKYROA421alO+kQMgWlrU3yerSqOKzDYrFJkBPHwsD8OE2jg/CruaEmxVN9dDVXKVlfZU8EU8ztKDOdc/NSuWKL/rljaDB8fJrMO6tuEwetsYNM4fPZRG8J5dwEsG1lyy8HN6ylWJZc7AxmSHWhS2vAQDRQG6TqHGVc4fuquLflZ1fBep6yDk3v+6m+2nEcQNsSvK/xivg8TmnMEikKLassQ8sY14z7/LTWkwThg1r79heH089gmAyKS9xoYp+Yeqhi/RSpTJFjkKvKM5EHYlvcdv6eGvZWsHE8Kzy/J/6CwjSKC2EiTkwSVqJ9aBM5MJYc0vMS/7wW86OisfLQCmis9JdQRsJmkYvdrHC137VzR4gXV+VL51M+D1oLPhazDkYmr2wC29lwbMf1AnUtvOw45dzxNBh+osBgs6dQOD1n +ib9+19g gVaxZVXzVMqHheyMPgrZFEz7MihTLs71FTFiQeT8xHAk+B7Bn2j858fHxFfYQ2bstJs0uDQqqmmgvRJqiNnz1/V3+ZWVEButB7EXEWAIArOaYPNMimmmr7X28z78C21+4TOr4J6EaAt//JzKq2ummLrJxBmEzYi86NS6SoeNMFaJBcZf7dzvEgSKfFRmVJae9n4Qml6YYFqLrj/xW2NuFZw9uMtRtluHN49ZVGYqubkQVJZ8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 21, 2024 at 03:09:08PM -0700, Andrew Morton wrote: > On Thu, 21 Mar 2024 17:15:39 -0400 Kent Overstreet wrote: > > > On Thu, Mar 21, 2024 at 01:31:47PM -0700, Andrew Morton wrote: > > > On Thu, 21 Mar 2024 09:36:27 -0700 Suren Baghdasaryan wrote: > > > > > > > From: Kent Overstreet > > > > > > > > We're introducing alloc tagging, which tracks memory allocations by > > > > callsite. Converting alloc_inode_sb() to a macro means allocations will > > > > be tracked by its caller, which is a bit more useful. > > > > > > I'd have thought that there would be many similar > > > inlines-which-allocate-memory. Such as, I dunno, jbd2_alloc_inode(). > > > Do we have to go converting things to macros as people report > > > misleading or less useful results, or is there some more general > > > solution to this? > > > > No, this is just what we have to do. > > Well, this is something we strike in other contexts - kallsyms gives us > an inlined function and it's rarely what we wanted. > > I think kallsyms has all the data which is needed to fix this - how > hard can it be to figure out that a particular function address lies > within an outer function? I haven't looked... This is different, though - even if a function is inlined in multiple places there's only going to be one instance of a static var defined within that function.