From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 819A7E77180 for ; Wed, 11 Dec 2024 22:06:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A0CA6B0085; Wed, 11 Dec 2024 17:06:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1507D6B0088; Wed, 11 Dec 2024 17:06:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03F556B0089; Wed, 11 Dec 2024 17:06:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DA8F76B0085 for ; Wed, 11 Dec 2024 17:06:25 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 74CD5A181B for ; Wed, 11 Dec 2024 22:06:25 +0000 (UTC) X-FDA: 82884061974.30.C04ACEB Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) by imf28.hostedemail.com (Postfix) with ESMTP id BEF16C0028 for ; Wed, 11 Dec 2024 22:05:56 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="qv5X/xPv"; spf=pass (imf28.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733954768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9VOfl11aVQjjQ03B4nJjzJwNXXBd1opTt5mcv9gYqzc=; b=arfLgeVEV1SAfx6TqXQJNDBCciJKAT9iW97hmYvFxxNuZY8+fBH2mHCjjSq716wWxdsp9/ kifkSbFh3x2bcg8YrvpCxLqc2Rm3N066WYc9bym7Gih05F3T37GJRCE7Ah8gDSYue5Wa3A uEeMuxP9y5ngvRtXmL0YFoKNCxXUrds= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733954768; a=rsa-sha256; cv=none; b=46qd18X+wfdTGPl6ebnUy35X4IezSr014EMG17Z/ZhiWshx9qd1dgZrPpBav8HWwj39ScK EYE+RBCn5I1UzQ+uhxnDAQQIZHey9h7m7ykhs5YriL0C8/S0NkReaBaNQu2tITOIBA5AMI m0JqmGNUuiPDltpuUBNkW2BJwJM51Co= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="qv5X/xPv"; spf=pass (imf28.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Wed, 11 Dec 2024 14:06:14 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1733954780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9VOfl11aVQjjQ03B4nJjzJwNXXBd1opTt5mcv9gYqzc=; b=qv5X/xPvFcNThlC4whgtE5EK7P/ICRK4K9ngyzwR/+55o2KfZZv+DejqlzqwCMHPg5gn1a CWuw9DDMMvxLNQGUjCwOxR/yf6OpRmXKiQFjVoKjzIgYpvm5/20GkeNKPrel56IAUrmNJv m7iakyyuA9HPbe785cfT4HR4bJZ1+pA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Joshua Hahn Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, sj@kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [v3 PATCH 2/3] memcg/hugetlb: Introduce mem_cgroup_charge_hugetlb Message-ID: References: <20241211203951.764733-1-joshua.hahnjy@gmail.com> <20241211203951.764733-3-joshua.hahnjy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241211203951.764733-3-joshua.hahnjy@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BEF16C0028 X-Stat-Signature: 4f178b5cscx7b7x8mezxn7trzghqrnfy X-Rspam-User: X-HE-Tag: 1733954756-214663 X-HE-Meta: U2FsdGVkX18WASPhnuyzwNYVJOjvlus3LTcyZpedzpZUmrMgjF/fB0R/kJDZI/yIfrJoc+C0pXW/Rd7EAoR5HGXlr49gZdJ7SbYGaFiFK5EtCSQGyYtDseFRU+TwyOtEXLWbCwTWeSa55ATvO4+YTwaI8/VE2LmruxSP69hvxmQlLa/wNZFAWh4sp/OP4dpnBa1eICTdOxHi/ZpZ2p3eBbSjP6sYQ8E0EKT9C57GNoLqVZtexaT9oFZYFOiJT8ZPZTFzhu6fVPk93OnCYxZl/nAlXvZRzZoba8srVqHzpYH7kfPss08gRIoXsePZEZBIt2ajH5BMLT0FQKfjyY7LcQYt+8LCUFkIi/Byp4mQCUU044YpsH4Lw27O8Gr/hsUe/tlaSye8vBKOSUVr8HhpbDoVAFkord+dR05dSNepBvcW8Ti1xerd/uiJ+FwDbSK//kSVa9XEZp0AX0eWWh3mE4tH+yh72NN+PK0jsNT2FQTtEmJclxQrzEoFzIOGVnUvU+kI3GJYMHFtNDBjA2jQqoOynNkoQXMlUylkZg5zSpOkNRa8IrP503i0AmNV5bcj6m2pBopq1ojcEiPiBMdP2IL8Jet1K+bfwpatqs3ukto86kjBnoZ7BVOvGK3CM+b1sbu5Kp32L0+oqQrGMNtV0RYdSwpDGDr+b6g/fNGV9b/HupXeXgUsdhXpXcBLT1Appln5YqkA7fW5Z5fRlOT3y4TeeXybtjI07fXVc81BE4vca5QLAILxsy8qmhbZcbU6tBC8KJfnTKOkXRpy+cVXiLn1yis+hGoc+U4E/6NQTAZ9c2eGpL+yw+yUmY97P6IlMu7cMuRKuDTkbRXHArlrWtQCRBpqIMMLrOiVBzsCPL2ZUm5hYg4JhaufE31xv6a4FIu1jk5ZccLKIHcNEPvXpCVAByZ9+TZthnD7YMQKIRqRBuZBveKiFmQ645Skd93VLfL/sbJQ/70mQqX0fQG S8KmUs+L 9cHIhRlTWVEjmb9LvF3gtDvTYKmogleM9qcDD/FNynqfXS4227BiuUI/t2tK9n7sugn+w/61miOvEeP0gVAibACTyg+RCH4nGobhd4bkg1DMm7jHemj7Cg9Fo/NOKVnjlI0KuHHA7JSmTueF8ps5ziAUU5Rt/t4SeaOK1knSGeBtr/IZY8JQVg82jt4cyD+3AHljLr4XrJsiIM1f1xvGGSBD/pSG7AP5QEp5O6PWFJf53knCR9lk57UyeP2qpIQL09kJYCp0BkJw5MVaU5hdZYRsVnRxw5+DdNADm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 11, 2024 at 12:39:50PM -0800, Joshua Hahn wrote: > This patch introduces mem_cgroup_charge_hugetlb which combines the logic > of mem_cgroup_hugetlb_try_charge / mem_cgroup_hugetlb_commit_charge and > removes the need for mem_cgroup_hugetlb_cancel_charge. It also reduces > the footprint of memcg in hugetlb code and consolidates all memcg > related error paths into one. > > Signed-off-by: Joshua Hahn Acked-by: Shakeel Butt