From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50A08D3F29F for ; Fri, 18 Oct 2024 21:35:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 897D86B009C; Fri, 18 Oct 2024 17:35:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81FA96B009D; Fri, 18 Oct 2024 17:35:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C14B6B009E; Fri, 18 Oct 2024 17:35:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 44C886B009C for ; Fri, 18 Oct 2024 17:35:03 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 213C5140231 for ; Fri, 18 Oct 2024 21:34:50 +0000 (UTC) X-FDA: 82688028360.14.B587BBE Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) by imf03.hostedemail.com (Postfix) with ESMTP id 890722000B for ; Fri, 18 Oct 2024 21:34:55 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ivEc+vnm; spf=pass (imf03.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729287252; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hvC423U1n9cjJ+Cz4Y5WpHvfXoLa7fjRoh3nCRJpriI=; b=Nc82EqbxUPppSRVOPYUjS6MPHMztMSstUfFLtGl/VUfY1n6xJU53DjNv9zbQYS109MwFxm oW9gB5FxM6wbyEty4jSK6ahM0w91ewfQ0/1OMRqns9k0DXzNx8gsFEsx4UEsATFL0ZpJm9 nIgsn8YFyvjFEKpfNH/NX0cotxwVYVo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ivEc+vnm; spf=pass (imf03.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729287252; a=rsa-sha256; cv=none; b=QbobqgO7Tyu25R4xqWPMEnbspspvrvrKjoeXtXoGp2+id5TVUSdXJOnUTMY8FbLHdMEAl2 rYXjYKzqydCKeHbz9IVzBZtauVpOQVKYQnOvh60mOP6FBZcXsCv7QTmNfQ93WIshcLY1Dw 37Lm6lPvQKo2R2cyw2e+zkFqeiD9zQU= Date: Fri, 18 Oct 2024 14:34:52 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1729287298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hvC423U1n9cjJ+Cz4Y5WpHvfXoLa7fjRoh3nCRJpriI=; b=ivEc+vnmwNehe0JbqPgNJYuRggaGBJEIIBOklEXpayICxA8OyCOQNyyB7J0ElZXF+/T2qp LoNk3JDfMclh5gZNLwuv0axXm4nM1/Dlq57pYOhLARqZKLNfIUl95biehsYRfQNNOLcujL ArBydMUIyMDV+bOzNC2vupV5RzO2eio= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Joshua Hahn Cc: hannes@cmpxchg.org, nphamcs@gmail.com, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, lnyng@meta.com Subject: Re: [PATCH 1/1] memcg/hugetlb: Adding hugeTLB counters to memory controller Message-ID: References: <20241017160438.3893293-1-joshua.hahnjy@gmail.com> <20241017160438.3893293-2-joshua.hahnjy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241017160438.3893293-2-joshua.hahnjy@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: baxce5rtrsk3fatyhbmeu74yj4hkxwpm X-Rspamd-Queue-Id: 890722000B X-Rspamd-Server: rspam11 X-HE-Tag: 1729287295-865392 X-HE-Meta: U2FsdGVkX18/kNweCIqF4UJk6ncjIA69SdmM6iJuS1BOMSSSxoPeSpYItGbY8ZO6evJrMsjstGyYoy3AiD37xi9TgSouonb6JWRhuwbeMkIXWjuIs9aGKoZ4OEDWWGxwr+p9ez1xhifSVq0//T/ZxJC8WH/4gguoc51A/GY3ZClbSAEqddvfH+SfAuO4jUL/2Amyj6/kOsHaDG6Xc0d/i4fBTt02cwneQOaFbycxwEJPBt1Oi2/A9II0nQ16dvCxX3fSfFoxuMCuLlP4AFEFkzfIjDrIuAP/5iHIr4F+HUTmJjyvImOI66AuiyNM0S7e0mO5shEtdYA1yLt9+la+Hm7Ugoj2PJIJVnI/7LSmSBY5sa/Q5/f8PgPEVsqua/A3YnMu+O6FhpNFEZhgDFu1YNmjV+7MXyLg2J0Cd74yDuStMheP3B4WVhB2Aq93D0g/KJk8Fre2L5f39uNOorAjUxUuSCBcPEBD63leCDFj2Fd3s91qYdwh0D6eQrWdaVmSu3l763haY70+wahGp5EFMVZFmcYmMJO3o/91YAl3iZ4F7+chiJFk0eyjCUUXkMB0t3VBx0z6jRw2zu+gXWEgCGrrksQLJBqRMl1RBIrBR4bd355iPtwepVQ7hiuezyRzP3cbLvuU6H5hZcMhhZp468/FO3uIEFpQI7pXzvveXrZEA8qfengBPkZ2ZNuDKRpurqLDU/llFlOnjKfEtD5SwwI5YLMJLnrNhAohkHg3LguZIUGN95arQylbNvRLGyx31nvjHyusiRX4MKQGojYlxW6ns7lnXXsL/S4QROC5Zm0LGgn7PxPm5olIjRZfr95ygm2NCc8F1IkW6E43PvGJbVmgvxLbckLtD1U5ZAVM3Llj7eqUyZuCfIAB1d6s69BaY8dHQpxzWVQWztpTIYUtDAQgttjQxg77JvLWBBSsaERYAKNipvJex/2uZ2SR5xvpTJPCqOJzTlebpuLTTFi QrtfeVVa Ub4WMlj5mSer7WZnCZGbbUAZ1B4D2WFMNZTxZOxu+Ul6GVWoDYaAq6ms+h8bCFdSJpvbxQByOMsBEuyiuFsSHbuGYyEuxNRhoVelLHvm03fSWdsSJlZMV3hT3mhCA6d0R+kBVlU/IqLh8uvKEV1BRdBvBPy02PRxZkjZSBiSWC+UOAoTc0EbVMndFPGm9A8cSon4mJPGAdeZJRE2V9VrYhHAP7KEL7ANj9pIFejpy0OSSGGc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 17, 2024 at 09:04:38AM GMT, Joshua Hahn wrote: > HugeTLB is added as a metric in memcg_stat_item, and is updated in the > alloc and free methods for hugeTLB, after (un)charging has already been > committed. Changes are batched and updated / flushed like the rest of > the memcg stats, which makes additional overhead by the infrequent > hugetlb allocs / frees minimal. > > Signed-off-by: Joshua Hahn I have an orthogonal cleanup request (i.e. after you are done with this work). Hugetlb is the last user of try-charge + commit protocol for memcg charging. I think we should just remove that and use a simple charge interface. You will need to reorder couple of things like allocating the folio first and then charge and you will need to do right cleanup on charge failing but I think it will cleanup the error path of alloc_hugetlb_folio() a lot.