From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50513C02198 for ; Fri, 14 Feb 2025 18:22:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBA3D28000C; Fri, 14 Feb 2025 13:22:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D6AB1280002; Fri, 14 Feb 2025 13:22:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C59C628000C; Fri, 14 Feb 2025 13:22:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A733A280002 for ; Fri, 14 Feb 2025 13:22:09 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 00255120849 for ; Fri, 14 Feb 2025 18:22:08 +0000 (UTC) X-FDA: 83119369578.09.6AF5E42 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by imf23.hostedemail.com (Postfix) with ESMTP id A30AC140002 for ; Fri, 14 Feb 2025 18:22:06 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SilGwy3A; spf=pass (imf23.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739557326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aA7i6Y5wvJq18cjhRf2yTQBLujd+WtoFwszr0BvFdo8=; b=SzjXhRgZZKxMa784udYrXJh3atF82SSlHdI/1cqaANp3qFGumSI4g0sDQ793KJKW0MMx80 +69FsbKyvKlsxKC1WpaICGMhEpwAkrAxC/imwpX1Uj5qK3w/2N/1gqd9BGiDOW+BhMRKpE pVqjViv/jBxUyIgnZrbNp97HSvgChO0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SilGwy3A; spf=pass (imf23.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739557326; a=rsa-sha256; cv=none; b=mRcam5sXFOdFlv6p0xNex4+Y2fVNldYRbmpDHvQ/lhozOJJpg1EXjExbq+IO6/s9K/Lfj2 kZOvhk6Kpc3+/3vdB61UelhUwbGiWIwhjxO2anPnok+NdL5mgZ7Gto3q86NKGIT9pLainA PwUY2jwW7CSC594/JpH/2tQV1TRB4Mg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739557327; x=1771093327; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=gu3v+0nJkU/rA946+drvkvG+Kv5S6Z2/XIwZT3eT66U=; b=SilGwy3A+tgGWFvyQm5w2JsL4mKnjIuac5Sk7CyNsj81VCVGNL2HvwH0 45GzsNl5HBs2acQCtV/hkJGWdn6SccAOebgF9TypXrnGprzWJ3h+CtNe+ dvet8Sdre7e70DRSfK3X2aQ1EGVBya+drSkSwEOT/GnV8HlCjt3OT4lZs +mpCZ5Ms+n7X27AODulCe0p6yRsOzugRo2UKjOaoWy3kBZP2ybokm5DC3 EQgvP7quyCzCnDDUqAxdFPOmAOkVNf3Td78le5Ra2l8QbmCYzxI8zYt6D in9pMtsE8glZK+mP4N2dmdAcxvFuyNrgB4lZXHtVUj8J1p5QnspN+unM3 Q==; X-CSE-ConnectionGUID: EaYz8gF6QZaQNagxFA+IhQ== X-CSE-MsgGUID: IQQzkLFlQviAw9k38+f1vQ== X-IronPort-AV: E=McAfee;i="6700,10204,11345"; a="50959387" X-IronPort-AV: E=Sophos;i="6.13,286,1732608000"; d="scan'208";a="50959387" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2025 10:22:05 -0800 X-CSE-ConnectionGUID: 6bYL/771TLmqsYMXYHPEIQ== X-CSE-MsgGUID: ad1nNmhMTG+RzSVqSv0NhQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,286,1732608000"; d="scan'208";a="144380659" Received: from tjmaciei-mobl5.ger.corp.intel.com (HELO [10.125.109.21]) ([10.125.109.21]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2025 10:22:04 -0800 Message-ID: Date: Fri, 14 Feb 2025 10:22:07 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 05/12] x86/mm: add INVLPGB support code To: Rik van Riel , x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-6-riel@surriel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250213161423.449435-6-riel@surriel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 5kfhrzdkxrg7p3wenru1uaxtexoimrmh X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A30AC140002 X-HE-Tag: 1739557326-928215 X-HE-Meta: U2FsdGVkX1/Lh+FXIZVBgXIZ81SrFHwyZhQpe41DgOhK4vQuKLy2Iw06upOXFdRZxyMbqNEukFOpwg0SfM36lgApzCmla4IU9X3OzeWoFTQKTStaMGZCh+g7tRVfb3aBmq7JiTsc5CiJQi4QdVxvyO3pS6v0g7o3g4arOcqL0UvH+6KOZOEu2wceyccue4C3aiC+MkCktHaLNqRX9v/rxMr6uOQze2alIxhXG0qDy0r6swb9ah9mf0CR/qqVsRmxAH6lng6MkG1nRQjAsg4EX02F8OZ5N1EQaYSMLoDiuYXgnT/F7vYLMd69VIb7z7yRZRYv9nlYn4o5uKOSXV55Z7E0dmioohqFJ5wsN7J9HuStN5LgVLHAdVx8YeP6AxWzDgLWa/Gi+kTzUeojdcCb7JwoNVs4orCMzoT3d7RM/h8hSP/g4A5OTKLTqcx0FOwnm3CVzz+LHemUl0/2gwaJASfJrjZNLuNXsIMyuwjy0qcg/UExRUE6tw18YyWuO5vfRP7bDs42tfG9Y6ovj2pZUVNYmEx+Wlug3PS6Lz78aEy8BUdUmayBvmgVNe3cKRtJOoJtAUk2Ho7JVjbcXfWpI5oamXLR6bxFX/UhehoxyjKQtZ8u/VwxY1O8b0fXx4tFdzYI2w9bRJ+Z4KEtDYP/DOMMsjHuHtv/8sf4RcdYMsU0YVPG13F1CIFb7HFtK8vWFfcrO0XGxhAwmHoPMZTonJFszz0qWouwPFTbvGEJaC1fKScibkTXSbel1MESYkvLPKxyQGWDT61sRPnLdYVGG6HCzH4fzZNuOmVUuy2cyq2+9NrisfcxHqJTlVwnBKj7a6cQkLeRjPEfmmHKqTNDtvI7ZiEmT5E0aUSdjG2lyFZzjkMjthdgIFr7okM1fmtputXRNUwxtYzOQyNT7vbd4sGjoc5cTsrGz5n4UXP9CNcT0bHF+T+tLTAXcz7a9nQMlMHQP/NePSVl8elmvcj rzZd2ZqU p2/DtidywzduB8VY8vjOpfcn0x5d5wu4YunrkEPHNr5omEbUU45b2Gmy4JXklNzZ3h0D1vEqAk82MwgzYMZDAZ76hot4jrNQWwB7tDpk/z8rjLdzBD0mR8qzW8JqEsXe5oWBGCLZe2wS2bB28xTD3QjIZX4tdpjpz0V1e1/ABLd/+Dt1oObvbysVk7aCQyuFxqEA4DkCnQTvsCsROb/6Wc7VR/SfdSlvl7Y9z/qdoOfQFjGyS7sy1QNTygCIK/uRK2CXZUrszMMuYmJ/xMfCpY9wE5ehBSFjLQRjc2ETy3Ktekzc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/13/25 08:13, Rik van Riel wrote: > Add invlpgb.h with the helper functions and definitions needed to use > broadcast TLB invalidation on AMD EPYC 3 and newer CPUs. You should also note here that (or if??) all these functions get used later in the series. > +/* Flush addr, including globals, for all PCIDs. */ > +static inline void invlpgb_flush_addr_nosync(unsigned long addr, u16 nr) > +{ > + __invlpgb(0, 0, addr, nr - 1, 0, INVLPGB_INCLUDE_GLOBAL); > +} Something about the "nr - 1"'s needs to get mentioned *somewhere*. I think the best place is actually in __invlpgb(). Basically make the calling convention for __invlpgb() be the _sane_ thing where nr==1 flushes 1 page. Then do the nr-=1 in __invlpgb() and document why. I don't mean to insult the AMD ISA designers here. I might have done the same thing. But the software to use the instruction ends up looking really funky. It would be great to limit the number of places that deal with the funkiness to exactly 1. With those two nits addressed: Acked-by: Dave Hansen