linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Alejandro Colomar <alx.manpages@gmail.com>
To: Peter Xu <peterx@redhat.com>
Cc: David Hildenbrand <david@redhat.com>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	linux-man@vger.kernel.org, linux-mm@kvack.org,
	Axel Rasmussen <axelrasmussen@google.com>,
	"G. Branden Robinson" <g.branden.robinson@gmail.com>
Subject: Re: [PATCH v3] madvise.2: Clarify addr/length and update hugetlb support
Date: Fri, 10 Jun 2022 16:41:55 +0200	[thread overview]
Message-ID: <bfda1f0d-34ee-e9da-b9e3-d741c3070959@gmail.com> (raw)
In-Reply-To: <YqNQKMNXMvxH8+aE@xz-m1.local>


[-- Attachment #1.1: Type: text/plain, Size: 1215 bytes --]

On 6/10/22 16:07, Peter Xu wrote:
> On Fri, Jun 10, 2022 at 11:38:53AM +0200, Alejandro Colomar wrote:
>> It's not perfect, and currently it doesn't detect semantic newline problems,
>> I think, but I guess it could be improved in the future.
> 
> Semantic newlines can be challenging as IIUC it's not deterministic?
> 
> I mean, I had a feeling that some paragraph could have multiple valid ways
> to do the layout and newlines without violating the rule.  IMHO that could
> be a challenging part for contributors.
> 
> (Or maybe the rule was deterministic but I didn't really fully digest it..)

You're completely right; it's not machine parseable.  But it could 
detect the easiest stuff such as "foo.  Bar" for example.  And only 
maybe "foo, bar".  But going further, that's a job for humans.

And yes, many times there are several ways to break the line while still 
following the rules.

> 
> But the tool (even without the newline detections) looks promising and
> helpful.

Thanks!  I'll try to make it usable.

Cheers,

Alex

> 
> Thanks,
> 


-- 
Alejandro Colomar
Linux man-pages comaintainer; http://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-06-10 14:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-08 23:45 Mike Kravetz
2022-06-09 13:24 ` Alejandro Colomar
2022-06-09 18:48   ` Mike Kravetz
2022-06-09 20:13     ` Peter Xu
2022-06-10  9:01       ` David Hildenbrand
2022-06-10  9:38         ` Alejandro Colomar
2022-06-10 14:07           ` Peter Xu
2022-06-10 14:41             ` Alejandro Colomar [this message]
2022-08-15 20:41     ` Alejandro Colomar
2022-08-15 20:46       ` Alejandro Colomar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfda1f0d-34ee-e9da-b9e3-d741c3070959@gmail.com \
    --to=alx.manpages@gmail.com \
    --cc=axelrasmussen@google.com \
    --cc=david@redhat.com \
    --cc=g.branden.robinson@gmail.com \
    --cc=linux-man@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=peterx@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox