From: Joe Perches <joe@perches.com>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Hugh Dickins <hughd@google.com>, Minchan Kim <minchan@kernel.org>,
Nitin Gupta <ngupta@vflare.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH] mm: Use fallthrough;
Date: Sat, 07 Mar 2020 19:19:04 -0800 [thread overview]
Message-ID: <bfc9f9b69681c3ef285bf11b6506fa5b42b5917a.camel@perches.com> (raw)
In-Reply-To: <20200308031634.GA1125@jagdpanzerIV.localdomain>
On Sun, 2020-03-08 at 12:16 +0900, Sergey Senozhatsky wrote:
> On (20/03/06 23:58), Joe Perches wrote:
> [..]
> > --- a/mm/zsmalloc.c
> > +++ b/mm/zsmalloc.c
> > @@ -424,7 +424,7 @@ static void *zs_zpool_map(void *pool, unsigned long handle,
> > case ZPOOL_MM_WO:
> > zs_mm = ZS_MM_WO;
> > break;
> > - case ZPOOL_MM_RW: /* fall through */
> > + case ZPOOL_MM_RW:
> > default:
> > zs_mm = ZS_MM_RW;
> > break;
>
> Seems like missing fallthrough; for ZPOOL_MM_RW?
Consecutive case labels do not need an interleaving fallthrough
next prev parent reply other threads:[~2020-03-08 3:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 7:58 Joe Perches
2020-03-07 18:53 ` Gustavo A. R. Silva
2020-03-08 3:16 ` Sergey Senozhatsky
2020-03-08 3:19 ` Joe Perches [this message]
2020-03-08 3:18 ` Sergey Senozhatsky
2020-03-08 3:54 ` Joe Perches
2020-03-09 4:15 ` Sergey Senozhatsky
2020-03-09 4:51 ` Joe Perches
2020-03-09 6:20 ` Sergey Senozhatsky
2020-03-09 6:48 ` Sergey Senozhatsky
2020-03-10 11:10 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfc9f9b69681c3ef285bf11b6506fa5b42b5917a.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox