From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C31FAC77B73 for ; Tue, 30 May 2023 07:02:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E906900003; Tue, 30 May 2023 03:02:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5721F900002; Tue, 30 May 2023 03:02:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 412CF900003; Tue, 30 May 2023 03:02:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2DA5F900002 for ; Tue, 30 May 2023 03:02:09 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D84F51A0134 for ; Tue, 30 May 2023 07:02:08 +0000 (UTC) X-FDA: 80846027136.08.6F162D4 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf08.hostedemail.com (Postfix) with ESMTP id A72D7160012 for ; Tue, 30 May 2023 07:02:06 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KkuIwFMN; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=kOVj5AP5; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf08.hostedemail.com: domain of hare@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=hare@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685430126; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YenkraC+bjbP/G4WCSjSaJiEtLaIB5+AVqTvktqEFdc=; b=aGVbvvPX7Qpxm+XmjKWd/ojSlVUQnkoz9hKa94x7M8Hm9yJ7opJ7C2Vz++gZCHgWLV8oaJ GYfYi8/75ueV2TjTZX4mQ/5qvxHgQTm5tXVDWhFIa2kZOO0dB5WUEYEOpH6AACTBAnS2bF sn1T4eQfG4CsPhIK93WuHfFLSlzyAog= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KkuIwFMN; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=kOVj5AP5; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf08.hostedemail.com: domain of hare@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=hare@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685430126; a=rsa-sha256; cv=none; b=yIL3yrxdi+2pNxAMwymA2bjDWWVEWFp+kEgmcCy+3R+nsYvWM7Kee68/XT5fInsojTFVBc SMyZhmjfzKO8/j7HIGqmyVoKpZhcnXgoKkB4YT5nwIqogzxo4O0GqFoGQqn8nDA24khm4L IOcPkmOYA/UXP0ZHYBMV9uzJrp6Z1v0= Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 49D5321AE9; Tue, 30 May 2023 07:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1685430125; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YenkraC+bjbP/G4WCSjSaJiEtLaIB5+AVqTvktqEFdc=; b=KkuIwFMNGY4/68lBzM2ZwKA00NEYOSehnBFzhe4SB7MeU/FjuZj3JMrv1SZTuFng69BKc0 D3HEEhPtYiRsAiXsLVtrLCvffPOOVi/Que+i3MwGENrBqhTGS6EbR09Gbl9cwsPKlAUKcz qBLoMiM6K/nE0BQd7TlQ62faIDX37DM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1685430125; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YenkraC+bjbP/G4WCSjSaJiEtLaIB5+AVqTvktqEFdc=; b=kOVj5AP53OUtAes+ND83d5ospHYS8iuEOR3ZCRVkFNXBLbLzNRLQnZX4vIT5JaspYvVizS gVcLhVYi2WgBl5Cw== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 9C6011341B; Tue, 30 May 2023 07:02:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id xU04JWyfdWSzcwAAGKfGzw (envelope-from ); Tue, 30 May 2023 07:02:04 +0000 Message-ID: Date: Tue, 30 May 2023 09:02:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 08/11] iomap: use kiocb_write_and_wait and kiocb_invalidate_pages Content-Language: en-US To: Christoph Hellwig , Matthew Wilcox Cc: Jens Axboe , Xiubo Li , Ilya Dryomov , Alexander Viro , Christian Brauner , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Miklos Szeredi , Andreas Gruenbacher , "Darrick J. Wong" , Trond Myklebust , Anna Schumaker , Damien Le Moal , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org References: <20230524063810.1595778-1-hch@lst.de> <20230524063810.1595778-9-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230524063810.1595778-9-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A72D7160012 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: sd95dgr1s3jb3dcxt18zd8gy39senweu X-HE-Tag: 1685430126-479825 X-HE-Meta: U2FsdGVkX18Qk3qBSRJAR6cYVgXXGeguwaoXuIM96bq/yCfyoD6r/mgUo3OL55awMUy6HRpdCpu16J67IoomcH16ZCuun9ItoEXX7XbgiDTu2Uv2IQ2RrvDbyOgfRpXBgoXtTtn/8wr9tg0hoN9OdnmOmUzXimG/IHRBKUu7oDwH4BEW1zHwAVXJk+YLPcb5YRXJBlbzRrH5SpCDEbSWLZVVJxkh4E0L2zhque8FbP0F5zwKuyRN9C0mQM83Q36ak48f2MxeLYxK143MRNus3MDkxv2DX+n425VteK5HGjf4UqI477kzcwS9kKh7KylF0NvH4TXa4FfaIvUDzcqIXho7Lka7vGOjestITo9A8ufF4i1FvtSv6oSCfW7dFCu4YnNRW9etsN1bFqk3h/mORJ15vJzLT1pxpRmM16UmbZyBWEOgxCPMlPiUORl6w5PQ44UWZxKaHAozE089iUqHV9QqC22gr7RrrJayy3/ZB9lkOO9OlB9Cfd6K/4LLakkQh+LubqSLXVWTAWCiFcSPqUiI72oGPrMHvP5KYSfZHQSbblieTKz3WW01o9ywkv3w+Vqq4t9ViXl6SGtrLk6Si6SGJ97KqMILG/nlXKFvFnSYqU+pRWnKgUsdFnJ7aup7VToBzUgtvD54Udo82uK71+H18isrHOM8mwYS/VnTCq3Swp9ZCxlpSNQprJQkQG5BgFdosxq8ODSjiaoeQ3d/omhVCl8JhK/BOVqTUF1MjIQDvPGlnU1qJHVuczFUlQZOgK5029N8/fvKrBvugxgaWXCYsocpn5JJeFRZ2a5ruglC3YBy4nHNmAJR+uiAIpJrhUSSdVAnKwKkfbui+PRh04oOfK40vAX0oxOTA3XFNg0zhEp6OUYddlmQXOd6iHG77lc7ZdS7FjAdPbF77mgAa0xJAInasILsKOQtuk1qRtAJbtyRjhN27T6qzSq1hUEpxFl7eYb+zYjzxRu2MFJ BAug2idU dgjsPJRLZyxmFY+tawVV+dilbRr9Kvmrf4nR5ddsXNUSRo6hT4l3ZYB3ZvbxFvYD45x4xzn7fiNKc3CWKlIuQQQoK2qBYHhsZGv2ox3xaX9L+wWE8hUzIbvGxhtXxK23rhAemHsHqhTGetPiJnauHtNTD+9o9sSwOv7ZHivbKYd5QYkZZAzPWDUyiNSvRN7lnLChFgN2Hpjv72Dt4NWXylhoPN5v6y4N8i+Dj3AUt7wuWqwRNckSNM9snJ6Gb+Ui0zIunOQAWRKHv0IqoW/kqyu2KvqgAJ1+fqQOPbybXF6mUCRPt5Y4bY2Z6CHfwL/6HPHVt4KUjRhSLnLA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/24/23 08:38, Christoph Hellwig wrote: > Use the common helpers for direct I/O page invalidation instead of > open coding the logic. This leads to a slight reordering of checks > in __iomap_dio_rw to keep the logic straight. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Damien Le Moal > Reviewed-by: Darrick J. Wong > --- > fs/iomap/direct-io.c | 55 ++++++++++++++++---------------------------- > 1 file changed, 20 insertions(+), 35 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman