From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA059C432C0 for ; Sun, 24 Nov 2019 15:24:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7C3E620748 for ; Sun, 24 Nov 2019 15:24:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C3E620748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B9B3B6B0558; Sun, 24 Nov 2019 10:24:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B4C346B0559; Sun, 24 Nov 2019 10:24:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A62496B055A; Sun, 24 Nov 2019 10:24:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id 914486B0558 for ; Sun, 24 Nov 2019 10:24:47 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 42DA3482A for ; Sun, 24 Nov 2019 15:24:47 +0000 (UTC) X-FDA: 76191543414.14.rice35_c653ddf3630b X-HE-Tag: rice35_c653ddf3630b X-Filterd-Recvd-Size: 6335 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Sun, 24 Nov 2019 15:24:44 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=38;SR=0;TI=SMTPD_---0TiwwSUG_1574608754; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0TiwwSUG_1574608754) by smtp.aliyun-inc.com(127.0.0.1); Sun, 24 Nov 2019 23:19:15 +0800 Subject: Re: [PATCH v4 3/9] mm/lru: replace pgdat lru_lock with lruvec lock To: Johannes Weiner Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, shakeelb@google.com, Michal Hocko , Vladimir Davydov , Roman Gushchin , Chris Down , Thomas Gleixner , Vlastimil Babka , Qian Cai , Andrey Ryabinin , "Kirill A. Shutemov" , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrea Arcangeli , David Rientjes , "Aneesh Kumar K.V" , swkhack , "Potyra, Stefan" , Mike Rapoport , Stephen Rothwell , Colin Ian King , Jason Gunthorpe , Mauro Carvalho Chehab , Peng Fan , Nikolay Borisov , Ira Weiny , Kirill Tkhai , Yafang Shao References: <1574166203-151975-1-git-send-email-alex.shi@linux.alibaba.com> <1574166203-151975-4-git-send-email-alex.shi@linux.alibaba.com> <20191119160456.GD382712@cmpxchg.org> <20191121220613.GB487872@cmpxchg.org> <20191122161652.GA489821@cmpxchg.org> From: Alex Shi Message-ID: Date: Sun, 24 Nov 2019 23:19:06 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20191122161652.GA489821@cmpxchg.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =E5=9C=A8 2019/11/23 =E4=B8=8A=E5=8D=8812:16, Johannes Weiner =E5=86=99=E9= =81=93: > On Fri, Nov 22, 2019 at 10:36:32AM +0800, Alex Shi wrote: >> =E5=9C=A8 2019/11/22 =E4=B8=8A=E5=8D=886:06, Johannes Weiner =E5=86=99= =E9=81=93: >>> If we could restrict lock_page_lruvec() to working only on PageLRU >>> pages, we could fix the problem with memory barriers. But this won't >>> work for split_huge_page(), which is AFAICT the only user that needs >>> to freeze the lru state of a page that could be isolated elsewhere. >>> >>> So AFAICS the only option is to lock out mem_cgroup_move_account() >>> entirely when the lru_lock is held. Which I guess should be fine. >> >> I guess we can try from lock_page_memcg, is that a good start? >=20 > Yes. >=20 >> diff --git a/mm/memcontrol.c b/mm/memcontrol.c >> index 7e6387ad01f0..f4bbbf72c5b8 100644 >> --- a/mm/memcontrol.c >> +++ b/mm/memcontrol.c >> @@ -1224,7 +1224,7 @@ struct lruvec *mem_cgroup_page_lruvec(struct pag= e *page, struct pglist_data *pgd >> goto out; >> } >> >> - memcg =3D page->mem_cgroup; >> + memcg =3D lock_page_memcg(page); >> /* >> * Swapcache readahead pages are added to the LRU - and >> * possibly migrated - before they are charged. >=20 > test_clear_page_writeback() calls this function with that lock already > held so that would deadlock. Let's keep locking in lock_page_lruvec(). >=20 > lock_page_lruvec(): >=20 > memcg =3D lock_page_memcg(page); > lruvec =3D mem_cgroup_lruvec(page_pgdat(page), memcg); >=20 > spin_lock_irqsave(&lruvec->lru_lock, *flags); > return lruvec; >=20 > unlock_lruvec(); >=20 > spin_unlock_irqrestore(&lruvec->lru_lock); > __unlock_page_memcg(lruvec_memcg(lruvec)); >=20 > The lock ordering should be fine as well. But it might be a good idea > to stick a might_lock(&memcg->move_lock) in lock_page_memcg() before > that atomic_read() and test with lockdep enabled. Hi Johannes, Thanks a lot for the suggestion. I will look into this and try. >=20 >=20 > But that leaves me with one more worry: compaction. We locked out > charge moving now, so between that and knowing that the page is alive, > we have page->mem_cgroup stable. But compaction doesn't know whether > the page is alive - it comes from a pfn and finds out using PageLRU. >=20 > In the current code, pgdat->lru_lock remains the same before and after > the page is charged to a cgroup, so once compaction has that locked > and it observes PageLRU, it can go ahead and isolate the page. >=20 > But lruvec->lru_lock changes during charging, and then compaction may > hold the wrong lock during isolation: >=20 > compaction: generic_file_buffered_read: >=20 > page_cache_alloc() >=20 > !PageBuddy() >=20 > lock_page_lruvec(page) > lruvec =3D mem_cgroup_page_lruvec() > spin_lock(&lruvec->lru_lock) > if lruvec !=3D mem_cgroup_page_lruvec() > goto again >=20 > add_to_page_cache_lru() > mem_cgroup_commit_charge() > page->mem_cgroup =3D foo > lru_cache_add() > __pagevec_lru_add() > SetPageLRU() >=20 > if PageLRU(page): > __isolate_lru_page() >=20 > I don't see what prevents the lruvec from changing under compaction, > neither in your patches nor in Hugh's. Maybe I'm missing something? Yes, it's a problem.=20 Guess we could move the lruvec recheck after PageLRU() test in compaction= . Then it could be safe, and add a bit more burden on compaction should b= e fine. at last we have no disturb to file read. Thanks Alex