From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44F78C4707C for ; Fri, 12 Jan 2024 06:50:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34EC16B0085; Fri, 12 Jan 2024 01:50:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FE856B0089; Fri, 12 Jan 2024 01:50:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C6506B008C; Fri, 12 Jan 2024 01:50:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 091B06B0085 for ; Fri, 12 Jan 2024 01:50:32 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BF3991A06E4 for ; Fri, 12 Jan 2024 06:50:31 +0000 (UTC) X-FDA: 81669735462.23.9B01360 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf29.hostedemail.com (Postfix) with ESMTP id A2B0012000A for ; Fri, 12 Jan 2024 06:50:29 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=4lNpPT8A; spf=pass (imf29.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705042229; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MlwSyou2modxkJptQsGCaqFAJ4RumG9kIorw0KBq3N0=; b=FERR6UbnrKZzUDSGUSWrkxI0NQ+HcIWVRXNbz5UMaqx1HomRKpOgW76nyMr24pvSd12HJl jvFZwOpPwjyAWUOqm47ZfroOBE+Cj3/8sX1oeNEyGlwWD/6wMUMMxwwBqhmYsr7x4vvAO+ kM+ij1jpkTtGCFLpg4kK+UhM/McOpVc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705042229; a=rsa-sha256; cv=none; b=JERIYBn9CCsPLXU0W53VfTajgoRxECPBQYZi7TZlC09VbZxdR3DH64I4pEAq/fkE6W0PDn ACJqkukRKaGY6QjAZt08D3xd6eQELuEHlQfbLxNsa4CKTopo+PIqRrToTXJDymgAUCH5St 0P59FaVSWjYu9a9PEw83PId2INnZQqQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=4lNpPT8A; spf=pass (imf29.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1705042228; bh=rXcbu4QY6UCu3qy4gvXw+tpopWxC0tsBqLnsgFqfj/Y=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=4lNpPT8APDolfFCTLwh0woAmpgkpMjWjRiAcuOwGVtOmZHgPQJPjDY1i+rTrdB2jo rcLq9g8koWFxvFcoNPA6t6zy4fOxXySsLwmAPgXM0FD+11scWCGX3MGaDgD/FZ1CyV KMRCqOYoCxQQrN7fbTlRVoBgBdkE8c/9sFm7cHxjIzhxP8nr1tEn51VGbVZNWvbg+K 4oJveuu99TmvFwQj7tp1/wpHPw+/4BsCoOMl2XjIJnulTxtFHOxzY/6EDeQhnuBn9A rPAyhbTVZdGvr+4haE6jnHKRaXNN9G779HKR2d3cHiwmg9/1Zji3GKx+wnSwFBsOeZ A7PSHbMh2Jijg== Received: from [100.96.234.34] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id EC6403780624; Fri, 12 Jan 2024 06:50:25 +0000 (UTC) Message-ID: Date: Fri, 12 Jan 2024 11:50:33 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , Shuah Khan , "Joel Fernandes (Google)" , Lorenzo Stoakes , kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/mm: mremap_test: fix build warning Content-Language: en-US To: Andrew Morton References: <20240111082039.3398848-1-usama.anjum@collabora.com> <20240111131405.4b47521fb8884760d712e93d@linux-foundation.org> From: Muhammad Usama Anjum In-Reply-To: <20240111131405.4b47521fb8884760d712e93d@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A2B0012000A X-Rspam-User: X-Stat-Signature: fk1eit461dbqsh9y7uem4h3dm8qwcznx X-Rspamd-Server: rspam03 X-HE-Tag: 1705042229-277666 X-HE-Meta: U2FsdGVkX1+s57oniJb6bXz97NA1WoT0iWKrnA4q6trPO3z4u/baHCKiKKvmNXf76f4wX6Qzj7JT6sMM64fin2gLQ/bPw0Um8iWgphFjKwOZ/n5Jfwuq8292MQgb0kG2pGd/LS26iNwXgA6jAh/pHJXHk9LQHjajNNNd4MoALPiBgmCs88MiR2d70tqVi9Bh5B2maWQ6qwbTtc3l3UsCoDDuIPn7EJWzILkr9W0ukuHWMF3LiBkWci3TO40u7cWhHAJfnGXEH6nBMQ7ir4IWLlK8ceL7Ai1GZfk0FcfuBSr7MM7YaYyT3uQRxiYt65uFd5PminUZEBlOSsJNXqad9nc4bgVRXVc36HNdUOJxbZYsBc63KSuI2vQ4U1DpX+DYt9hOk4350jkMFdmBLbioFNJyDl/w84EusNg55IpOIL5Y7Bx/gFCXeJlCZNwft9TSLazlVwnrj7Wo104Z91dVdr6ox/7H09gEiGtFg5XYqADOc/9vjnzfP1mh1jJawJmPw6J4G/lpwwf0X3qfp5qHn97Apqwmfa8b72VT4qhnQwCSKzi8B8KiBc+rohfsXY5nhC8jKuP7AYNJl2pfDoaaKuVSsPzVqybYX/o5bSCugV0zXrcgt/d80QEwUJkHpHPUPWIvZ/R7tNop8m2uq/hWB4/FEwTVMJSrd8LDOAXsEmOaMQgMoZLp8ceLrJGmLh4vg0iJXEKg/VMmSuUTKnlzExjQKiKOuNug3tAW+IuVrElyWiwdOAl51EVopnTL7vnFbk5jZIMIHhmxBlc9Uc5snhlXx4Bm5nplaTyvH60lQX8pVGNMrAca1+U7EN1vVRoA0hDqC8+5wiikumKrLJ5IwGCv6hZ8XwSnHX5BnXBGsGUPjw/W4BQRIgiM4zSSs/6KgUCiQpF03Uj8HdI7Vug2KkOgyU64x8R99Ux7ULjXd04Wvo74dQYYcns+jPmUcX0FpzlSzDo75VBRwMhlhbH hdec3WFg GdS5P1jwQ1mnDXRxpWU3kmdv/3GEI3orv2a+4WGHjC7Lcbqh1EnToI8jakI53NgY9l8UfHHyCnNazZv+s1mKsfqnzInE6HSqfFvbw3Y17Y0jKqUeBbFI8ZWg1OOdtRd1SGrYg0SDPdUaKk/j5swd8oHpi292igFOpB/InalrewWg6y+6ZQgNq+nbOH9IID1G+GW0NomWy8sP5cFqz6Gusbh2tqjdw6Afq/Fg0K7wIi/CMIyW51dQWRxZq1AN1MsIOTFY/lWhFPKhY6rhWjXdoGfH1/itbWM+7Y+ds/G9znIBNQxivLLqW+jrKfpFFhSQ8dsffikSEgzGdJHzdd01yeTrZow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.007800, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/12/24 2:14 AM, Andrew Morton wrote: > On Thu, 11 Jan 2024 13:20:38 +0500 Muhammad Usama Anjum wrote: > >> Fix following build warning: >> warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘long long unsigned int’ >> > > Looks good to me, but... grumble. > > `i' is an integer. That's just how it is, Blame Fortran if you like. Didn't know this. Thanks for sharing. I'll send a v2 by using two variables. > Discovering that someone used `i' for an unsigned long long is like > seeing > > struct inode *page; > > It is surprising, and readers shouldn't be subjected to surprises. > > `i' is used in two ways here. Twice to iterate across threshold values > (as a ULL) and once to iterate across dest_preamble_size, which is an > int. It would be better to have two different variables for the two > different uses. Ones with more appropriate names than `i'. > -- BR, Muhammad Usama Anjum