linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Igor Stoppa <igor.stoppa@huawei.com>
To: Matthew Wilcox <willy@infradead.org>,
	Igor Stoppa <igor.stoppa@gmail.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Michal Hocko <mhocko@kernel.org>,
	linux-mm@kvack.org
Subject: Re: Distinguishing VMalloc pages
Date: Tue, 12 Jun 2018 15:35:56 +0300	[thread overview]
Message-ID: <bfb6a847-0a8b-b03b-b61f-a16861cb5cb7@huawei.com> (raw)
In-Reply-To: <20180612113615.GB19433@bombadil.infradead.org>



On 12/06/18 14:36, Matthew Wilcox wrote:
> On Tue, Jun 12, 2018 at 12:54:09PM +0300, Igor Stoppa wrote:

[...]

>> Although, in your case, you noticed a problem with userspace, while I do
>> not care at all about that, so maybe there is some wriggling space there ...
> 
> Yes; if your pages can never be mapped to userspace, then there's no
> problem.  Many other users of struct page use the page->mapping field
> for other purposes.
> 
>> Why not having a reference (either direct or indirect) to the actual
>> vmap area, and then the flag there, instead?
> 
> Because what we're trying to do is find out "Given a random struct page,
> what is it used for".  It might be page cache, it might be slab, it
> might be anything.  We can't go round randomly dereferencing pointers
> and seeing what pot of gold is at the end of that rainbow.

Ah, I had understood that it was already given that it was a vmalloc page.

[...]

> It might be useful to refer to the earlier patch which included that
> information:
> 
> https://www.spinics.net/lists/linux-mm/msg152818.html

thank you,
igor

      reply	other threads:[~2018-06-12 12:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11 12:11 Matthew Wilcox
2018-06-11 17:25 ` Christopher Lameter
2018-06-11 17:59   ` Matthew Wilcox
2018-06-12  9:54 ` Igor Stoppa
2018-06-12 11:36   ` Matthew Wilcox
2018-06-12 12:35     ` Igor Stoppa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfb6a847-0a8b-b03b-b61f-a16861cb5cb7@huawei.com \
    --to=igor.stoppa@huawei.com \
    --cc=aryabinin@virtuozzo.com \
    --cc=igor.stoppa@gmail.com \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox