From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 541D4C02199 for ; Sat, 8 Feb 2025 02:56:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E29836B0092; Fri, 7 Feb 2025 21:56:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD8B06B0095; Fri, 7 Feb 2025 21:56:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA0246B0096; Fri, 7 Feb 2025 21:56:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ABC7F6B0092 for ; Fri, 7 Feb 2025 21:56:12 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 37B5D814B8 for ; Sat, 8 Feb 2025 02:56:12 +0000 (UTC) X-FDA: 83095263384.12.F9BDF4F Received: from 009.lax.mailroute.net (009.lax.mailroute.net [199.89.1.12]) by imf16.hostedemail.com (Postfix) with ESMTP id 42758180005 for ; Sat, 8 Feb 2025 02:56:10 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=acm.org header.s=mr01 header.b=qqqt+jJm; spf=pass (imf16.hostedemail.com: domain of bvanassche@acm.org designates 199.89.1.12 as permitted sender) smtp.mailfrom=bvanassche@acm.org; dmarc=pass (policy=reject) header.from=acm.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738983370; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KwuZ81rmSgUnJO+YLCot41L9ydO8R0QlMFuV7Y+uaGE=; b=mKlz8JXO7uUVyVhG3043vuyzCgYA+FCty23KZyHnx+GOKxifnuYDS2jdT9Id2d1FfzbTBB j5JHrGrGDWC+0WXiR4hmnR4J5CbvGPMqI/vVdYXvIPQDoPJfZAzEVPNxbEovy5eQmmLt4f Xg7AuHBvjBDVvZJT3M5s02Jml+xaAJI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738983370; a=rsa-sha256; cv=none; b=6YNpIyQ/fE1M5s6wBeteXuf01HDIQGaxfw9bpAJmF5zIuiCVR9AMdjRRoT3/38clTA1qoO UUwmWyiGh5+nRRB1f3HNKuUDVau7IUIhWIBroXK44v7xLPgrpdIybl859iNLQ30Gm2im4T nUfhiON3d0oLwU4eWE+DERidHEbxfb4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=acm.org header.s=mr01 header.b=qqqt+jJm; spf=pass (imf16.hostedemail.com: domain of bvanassche@acm.org designates 199.89.1.12 as permitted sender) smtp.mailfrom=bvanassche@acm.org; dmarc=pass (policy=reject) header.from=acm.org Received: from localhost (localhost [127.0.0.1]) by 009.lax.mailroute.net (Postfix) with ESMTP id 4Yqb7s07fQzlgTwZ; Sat, 8 Feb 2025 02:56:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1738983362; x=1741575363; bh=KwuZ81rmSgUnJO+YLCot41L9 ydO8R0QlMFuV7Y+uaGE=; b=qqqt+jJm1BIJ4Ff0cHQ6ozc73esF/WJXorVvu96r jxwwUvxDuJV0jWuTRJdaGfA8uUDelBvbdO9TN/V/hwX6o4SPmTwJ7dZbCr4ePkp2 nMk3BfE2YCidGiof/retWtjZwW4DyeZQKdpQftepp4LwqpADZFVXWB4sndQO2D6f ADralK/kUY/+4a4x0s6UKe04hhxFbf5QGixvIkoY3g2801so3lsvYT1dA3VQv34l /09qHe1WC08XEtAXdLD9mw3TX1PjKpIST8NyxK1MagZDp6CUWr7cwhN27570Whb1 17UypkiJot8Xd2imlyvlWaBeil23HJhenNCe4keYCzO78g== X-Virus-Scanned: by MailRoute Received: from 009.lax.mailroute.net ([127.0.0.1]) by localhost (009.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id idO_ODQyjQtp; Sat, 8 Feb 2025 02:56:02 +0000 (UTC) Received: from [192.168.51.14] (c-73-231-117-72.hsd1.ca.comcast.net [73.231.117.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 009.lax.mailroute.net (Postfix) with ESMTPSA id 4Yqb7d6GCzzlgTwF; Sat, 8 Feb 2025 02:55:57 +0000 (UTC) Message-ID: Date: Fri, 7 Feb 2025 18:55:55 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Fix clang W=1 compiler warnings To: Linus Torvalds , Jakub Kicinski Cc: Andrew Morton , linux-mm@kvack.org, Ivan Shapovalov , Vlastimil Babka , David Laight , Nathan Chancellor , Pasha Tatashin , David Rientjes , David Hildenbrand , Kaiyang Zhao , Joel Granados , Sourav Panda , Johannes Weiner References: <20250131191231.1370466-1-bvanassche@acm.org> <20250207164926.6daeac77@kernel.org> Content-Language: en-US From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 42758180005 X-Rspamd-Server: rspam07 X-Stat-Signature: u5fwehcx6he7wsm7cs3q8x49fxs1175p X-HE-Tag: 1738983370-567285 X-HE-Meta: U2FsdGVkX18rTKxKFt6PlXG+XiQlqeD9PdDBRfKsR4mwBK4Ls/dgJGAq2f9cIvlEvyQIZu0VzVkIZ5jKHnujJbm66A8V7GOGo3xuxd2tyTtB9QoA8djhIlkbUgvjXjpUtjWuNK+VaOp+g7gO4KkcWGXTSlnxAEuFkTXkh6IAlq9sJmhb9UgR+RIQlX9PsTU0Hn7/YQ1NiALm/FbMP7WamMWCbo5bYXB+cTMiqF02h9k00tWhFY51hKPRYqeGYTpHwOk27OJ97F1DEwuhgs0jVaBtJGqpUPEgs6wNUvTBPUrpl+fXOto0F5uJ60l53Z4CFCrtg8ubPqWjmd9iH1LItR1le0Z0mbF512ruTzWDZ38rzcO0xq/RXEp9obo0lD9VWyvLQ9tXpClZd8DxVhsQEfYDRrB34vcGsfmdBcBTwR7wnMKlOfc3LDPWagAaFvlDrGdUh+8phLiFNiCQ7qutby6yDe1eWb4Iu9QtthI36qU0sF4dpGPNNtsdMSZMmnfPgvtwIpz7j1Muy8abjckXuVh7jcUWPQdSWyN+Hbq23BLVTCIk9oNqXCerYaSLgNX3Zactjh6WUKwC6zB8inD4PiybKY1N/uRjdVrqDg4PXOvIHToJK9rhSXI/7Qe40dOA25y0FOrTWxhUJu4KS+SMJcA2+JJz0SAYAyi1xR48lJNQDwHNE5TnlPQL2Yx4pQO2aa6PEG0rmQVZSCcfdmoisJSlOUrPVfis6sX2GBgbVhWhIZhg4LICF6BsT2artjW+1oBhaWtwxGc8fINoGOM3fk5OKqq5IMVUiB3RJiOxVlchgQMdh9LTDecXYKOryWLt8zb4g15qml+8dmPJAnSCCzNs8ImbQN7M1ja0YxVZ2DbmC0Ywf6M6oGMoTFFdab5osNUCj4pjTrsxdTY4hvAwvwbyz6IiL1LVwp4LNP06/n0BmW/ARAZASL8TDOCEdsMjfa0dB70IJ94y4pTbrcx juI22PQk kjlT20ip/t8/hBPwl5Qh1HMqThpYG/wZLtqKrrQuFZYa/7BEhCUZODf6ItT1s9+0YozTxnK5dChIW8kebpsnplN4iGCsjcYLT3AcsFuP5SwH2J4vdzp9GrFg1DasKkcvnWNb3SLE2ZjFWRrbr1n9I0K6prN00mT6joZewuucq8HHzOc7jI2aoSAh6TaNDMl1dS0PXsih56oK2y+7Z5rPh33c85Kl09GYZVaGfPts6HOcyUcdDpNiQpOo7E/BFIEHiILYu8EE7XtmBXry5WVuThzzgDP3L7p/g1VBCVfKcg46KLd+72ftP6uypNA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/7/25 5:01 PM, Linus Torvalds wrote: > On Fri, 7 Feb 2025 at 16:49, Jakub Kicinski wrote: >> >> Could we possibly please still consider taking this in for 6.14? :( >> Since the warning comes from vmstat.h pretty much every object file >> generates this warning. clang 19 is getting more widely used now, >> its making it hard to see new warnings. > > So: > > - I build the kernel with clang, but I don't have clang-19, so it's > kind of pointless sending patches that DO NOT EVEN EXPLAIN WHAT THE > WARNINGS ARE. > > - and even if you explain *WHAT* the warnings are, please also > explain *WHY* they are valid and should be cared about. > > Because honestly, W=1 is literally meant for "warnings that aren't > necessarily valid". That's why they aren't on by default. > > So no, I'm certainly not applying unexplained random patches that > don't bother to explain the what or the why. Not for 6.14, not ever. > > Fix the patch. Explain the problem. And possibly just disable the warning. Got it. Since the patch at the start of this e-mail thread is a follow-up for commit 30c2de0a267c ("mm/vmstat: fix a W=1 clang compiler warning"), do you perhaps want me to submit a revert for that commit? Thanks, Bart.