From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D11BC001DC for ; Thu, 27 Jul 2023 08:43:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 407BF6B0078; Thu, 27 Jul 2023 04:43:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B90E6B007D; Thu, 27 Jul 2023 04:43:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A50D6B007E; Thu, 27 Jul 2023 04:43:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 18FD76B0078 for ; Thu, 27 Jul 2023 04:43:45 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DF40F80420 for ; Thu, 27 Jul 2023 08:43:44 +0000 (UTC) X-FDA: 81056753568.15.BF45FBC Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by imf09.hostedemail.com (Postfix) with ESMTP id C42A5140010 for ; Thu, 27 Jul 2023 08:43:42 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b=K2texGDX; spf=pass (imf09.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr; dmarc=pass (policy=none) header.from=inria.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690447423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eVhIaLzkqXJBDg7d2NX9a14f5srX8J/oITvD2eUzZOs=; b=mxBDDVhBDUWLLYmwHXO0EXlcUuYTO1EoUdBFqxZXzCtMVsSAiDeEJ9Rc2WxvLC8arx8jrO UvrGS0ezlORf8QjN0vt1YnmubNC8NWwAMUZK5p97/ZlpRNPr3xvs8KRr4t4e7mv3NjiwTC kRXhA2sUFGWGuHrRm8EZqLD6qiOP11g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690447423; a=rsa-sha256; cv=none; b=BrrjDBgG6+1xl3PBGp1pcZtTlIYzmxB0w1gOiDmx2/3fvAvEc1zj76sIkUBi+XUgDJ8Ao9 AQiHAhJ2XPMXafG9VdBW7/VmZw1F9wgkPM3D2H75zZ2SsHtYMoD2rgt6ZVQWO5ExCNTCDq 0EiXcown9/yj1xaH767BnGvZMAqKHkE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b=K2texGDX; spf=pass (imf09.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr; dmarc=pass (policy=none) header.from=inria.fr DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=eVhIaLzkqXJBDg7d2NX9a14f5srX8J/oITvD2eUzZOs=; b=K2texGDXNfJz8UtV6W3NhQpxNxUDRYtVae6+8V3MJWVldpACu3RVLrj8 QoPbGISrpLO0xpA3luWzdzBwuHQiWHt+U3ahKuF28eVSjCFclPahN6uGH gXro077LmE5/V9yKZZSStTNpY9Ba6rS1RWpCwmh+Ep7q/O1RwQwxBDiXx A=; X-IronPort-AV: E=Sophos;i="6.01,234,1684792800"; d="scan'208";a="62454059" Received: from dt-lawall.paris.inria.fr ([128.93.67.65]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2023 10:43:40 +0200 Date: Thu, 27 Jul 2023 10:43:40 +0200 (CEST) From: Julia Lawall To: Biju Das cc: Linux Memory Management List , Stephen Boyd , "oe-kbuild-all@lists.linux.dev" Subject: RE: [linux-next:master 2742/4710] drivers/clk/clk-versaclock3.c:404:2-8: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead. (fwd) In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: C42A5140010 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: tnsz3a4ts5ru6ig6uurpqux9cqnaqrj6 X-HE-Tag: 1690447422-810863 X-HE-Meta: U2FsdGVkX1+2oKet84lFsClCv49z0W+NxF/Kj64/AE28f8XPev4sdUKyyUfkbAzMm3MkEnEEqmHTj1AHA9MHNiadzJQBnXRG1d+dgorcEbHSoyNy3fXW85caaohNEeKYaDSdLWIh7VC9FpSpeIsukIzbH+9HG7JY2oDxBvrRNgH+6JP0FOTF7Hht7odWrkgc6QD2MsQ9+AqI1BbwdECa9AtQEeZpr843kcu79+ituzmC9gZk8zYzApyEZFanWxy6Rf3cPp9jT+741dT7lcpFhmsIOyxJx08DlGvyPT1EzqoDhRoaUUsRuLKDBCWXKf6ZW45QDqAyhHEMlbTWTtDXYn9b+6UDyxCIMhxe80DriIdehQl7XTZ+xjuL+IQByBL060LQKOWEgO6eeUb52VWlVSYzLeIEH57TcWZ9P8kHw8UGMUxi91gVlB6O7jD0JOuGdyYVGB7dEnoT2WwGBXt3ODJOGe8xFHLrkvh8djCfpEM1kGGDspC12Gk2beJot0E9iV2r9MA12tpKpmIgPLXFPARwUSimrb046YBnPngkP2HfAC7omrLTnhYsOlHdilssOSHr4K3+Ya8reSLoIRKp+HFz2yWs7GVimFlrb1fgbBCyxS93snzd52TqA0AfFX8WgnK+ax5puHJLnxbNyvQfMNx8vNfZnc/JBcz6Pi51kQkEd+VNoUM/y2TwoybPX0ohTarpGrle3fAhb6HxNSXBPmLqseaFNN5OvQj40EdW10cWEXHXaICzTHMIPtB4D5r0Mxn+ulKiXTCA3zPiIdoziSGzYHZmrarapGhdYS8qdwNfSyiGO26sF39BDTEZdJlgj8k8X90XQ2FCTq+nDLLli4jB1QtdiF5EsjqMozJKWj3yLwmlENjwm48pdGaFuOHrXlv1nGD5jfHjHxQGkptj6sElukOnlRXQUT0deUyZKhn/A0OB+Fb7vPMPbaYvtgj26HWwSR6chV7E7ncXw1j 6rGCN/Pb DsoYNs7F1TFbpZKHm1caPKcvXcRxKWGFwcMRLBvMDcCULRKLoDtr9eyTK82Cp2GYsRdZ8GJnLIixt51RO4j+wTwig44Y24PL7Q2OieK/fyZYGXXo0tnoEM8TlhfddtP/0y0lBHnJIvdr+o+bGMnCH805cVwxeAZiihOsApdH2vATFDLNU8oxQ8Jv2UZiU2DFIWeKR0tDZVBtP06ExsxbTRekFzvj1og90uQ9gvkEE2ZGSzoEr+uBU1UZS0swypW7pnmCstGZw/pKmoFOQ12/2Th7zRvsg0TfdKMZJ+iwZ14tOWsv4YP4s+6DD9+NK322hKkeibCT19txO+H/qGiwqdX5sGjSsOYuuaKISR22NSqqlH/tj0akcmPS8DWkC2evP9W+VP0PHJRlH3sv75TP8guOFJAJu9bp3dHzg5hozCJsCcc+3BIqEhRKFx+ONGg2j5Oyt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 27 Jul 2023, Biju Das wrote: > Hi, > > The reproduce link is not working for me. > > https://download.01.org/0day-ci/archive/20230727/202307270841.yr5HxYIl-lkp@intel.com/reproduce > > Can you please provide instruction to reproduce this issue? I don't think it's intended to be reproduced. The issue is just that a long value is being passed to an integer that is 32 bit. If the long value will never be very big, then you can just ignore the warning. julia > > Cheers, > Biju > > > versaclock3.c:404:2-8: WARNING: do_div() does a 64-by-32 division, > > please consider using div64_ul instead. (fwd) > > > > > > > > ---------- Forwarded message ---------- > > Date: Thu, 27 Jul 2023 08:50:37 +0800 > > From: kernel test robot > > To: oe-kbuild@lists.linux.dev > > Cc: lkp@intel.com, Julia Lawall > > Subject: [linux-next:master 2742/4710] drivers/clk/clk- > > versaclock3.c:404:2-8: > > WARNING: do_div() does a 64-by-32 division, > > please consider using div64_ul instead. > > > > BCC: lkp@intel.com > > CC: oe-kbuild-all@lists.linux.dev > > CC: Linux Memory Management List > > TO: Biju Das > > CC: Stephen Boyd > > > > tree: > > > > If you fix the issue in a separate patch/commit (i.e. not just a new > > version of the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Reported-by: Julia Lawall > > | Closes: > %2BsY49B78%3D&reserved=0 > > > > cocci warnings: (new ones prefixed by >>) > > >> drivers/clk/clk-versaclock3.c:404:2-8: WARNING: do_div() does a 64- > > by-32 division, please consider using div64_ul instead. > > > > vim +404 drivers/clk/clk-versaclock3.c > > > > 6e9aff555db7b6 Biju Das 2023-07-05 382 > > 6e9aff555db7b6 Biju Das 2023-07-05 383 static long > > vc3_pll_round_rate(struct clk_hw *hw, unsigned long rate, > > 6e9aff555db7b6 Biju Das 2023-07-05 384 unsigned > > long *parent_rate) > > 6e9aff555db7b6 Biju Das 2023-07-05 385 { > > 6e9aff555db7b6 Biju Das 2023-07-05 386 struct vc3_hw_data *vc3 = > > container_of(hw, struct vc3_hw_data, hw); > > 6e9aff555db7b6 Biju Das 2023-07-05 387 const struct vc3_pll_data *pll > > = vc3->data; > > 6e9aff555db7b6 Biju Das 2023-07-05 388 u64 div_frc; > > 6e9aff555db7b6 Biju Das 2023-07-05 389 > > 6e9aff555db7b6 Biju Das 2023-07-05 390 if (rate < pll->vco_min) > > 6e9aff555db7b6 Biju Das 2023-07-05 391 rate = pll->vco_min; > > 6e9aff555db7b6 Biju Das 2023-07-05 392 if (rate > pll->vco_max) > > 6e9aff555db7b6 Biju Das 2023-07-05 393 rate = pll->vco_max; > > 6e9aff555db7b6 Biju Das 2023-07-05 394 > > 6e9aff555db7b6 Biju Das 2023-07-05 395 vc3->div_int = rate / > > *parent_rate; > > 6e9aff555db7b6 Biju Das 2023-07-05 396 > > 6e9aff555db7b6 Biju Das 2023-07-05 397 if (pll->num == VC3_PLL2) { > > 6e9aff555db7b6 Biju Das 2023-07-05 398 if (vc3->div_int > 0x7ff) > > 6e9aff555db7b6 Biju Das 2023-07-05 399 rate = *parent_rate > > * 0x7ff; > > 6e9aff555db7b6 Biju Das 2023-07-05 400 > > 6e9aff555db7b6 Biju Das 2023-07-05 401 /* Determine best > > fractional part, which is 16 bit wide */ > > 6e9aff555db7b6 Biju Das 2023-07-05 402 div_frc = rate % > > *parent_rate; > > 6e9aff555db7b6 Biju Das 2023-07-05 403 div_frc *= BIT(16) - 1; > > 6e9aff555db7b6 Biju Das 2023-07-05 @404 do_div(div_frc, > > *parent_rate); > > 6e9aff555db7b6 Biju Das 2023-07-05 405 > > 6e9aff555db7b6 Biju Das 2023-07-05 406 vc3->div_frc = > > (u32)div_frc; > > 6e9aff555db7b6 Biju Das 2023-07-05 407 rate = (*parent_rate * > > 6e9aff555db7b6 Biju Das 2023-07-05 408 (vc3->div_int * > > VC3_2_POW_16 + div_frc) / VC3_2_POW_16); > > 6e9aff555db7b6 Biju Das 2023-07-05 409 } else { > > 6e9aff555db7b6 Biju Das 2023-07-05 410 rate = *parent_rate * > > vc3->div_int; > > 6e9aff555db7b6 Biju Das 2023-07-05 411 } > > 6e9aff555db7b6 Biju Das 2023-07-05 412 > > 6e9aff555db7b6 Biju Das 2023-07-05 413 return rate; > > 6e9aff555db7b6 Biju Das 2023-07-05 414 } > > 6e9aff555db7b6 Biju Das 2023-07-05 415 > > > > -- > > 0-DAY CI Kernel Test Service >