From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F124AC00144 for ; Wed, 27 Jul 2022 02:20:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2179F6B0071; Tue, 26 Jul 2022 22:20:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C7C66B0072; Tue, 26 Jul 2022 22:20:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08F928E0001; Tue, 26 Jul 2022 22:20:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EE0CA6B0071 for ; Tue, 26 Jul 2022 22:20:49 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BCD2440AFE for ; Wed, 27 Jul 2022 02:20:49 +0000 (UTC) X-FDA: 79731276618.10.E681E1B Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf14.hostedemail.com (Postfix) with ESMTP id 554321000CA for ; Wed, 27 Jul 2022 02:20:47 +0000 (UTC) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Lsy9T5lMsz1HBPc; Wed, 27 Jul 2022 10:17:49 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 27 Jul 2022 10:20:42 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 27 Jul 2022 10:20:41 +0800 Content-Type: multipart/alternative; boundary="------------m0zQ3VREyHb09770hSSrhjBN" Message-ID: Date: Wed, 27 Jul 2022 10:20:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] memblock tests: compiling error Content-Language: en-US To: "liuxp11@chinatelecom.cn" , mawupeng , "rppt@kernel.org" , "linux-mm@kvack.org" , "david@redhat.com" CC: linux-kernel References: <1658804705-16996-1-git-send-email-liuxp11@chinatelecom.cn> <9bf50501-fac5-cd59-660e-52a6b779865f@huawei.com> <202207271006248558685@chinatelecom.cn> From: Kefeng Wang In-Reply-To: <202207271006248558685@chinatelecom.cn> X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658888449; a=rsa-sha256; cv=none; b=Xb2vXNQCsP15WoT7r5B0S9jz138AzsgHHWMp/Nr42pT5KPPSXX5Tio2/73zM18c2/w4gKC ODZB1X0R9N+NR+AaM+l1ZEoFUcKvq9g/wTYkJuLf5hpn81rMO+JtEPE+syjprxc47LNga+ rGfNS+dkCkJh8U5hobK9MjSsMgh2hNs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658888449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ieZMSVNphjVJeHT0yaohQKOwn5VQALn2nGL+F8PrOS8=; b=hCC+dCqImHqYcgePA6aIgf8mhb5+q235kUO5WQoyNLyyx4bDjGULw489prgb77QiDybHYQ wSGLTkbKCWoibaMzonAQCUm3mVLmNRvfva9hoHYWza+9EoJZ6Pioa12AiS6hrJSwwZWti8 ex7JLg4i+TE4G+9Jqk3jfLyoqwqNsqc= X-Stat-Signature: sc6fmedh3ih3qrurixjsjtegzbwp1gkx X-Rspamd-Queue-Id: 554321000CA X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam02 X-HE-Tag: 1658888447-519251 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --------------m0zQ3VREyHb09770hSSrhjBN Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit On 2022/7/27 10:06, liuxp11@chinatelecom.cn wrote: >> On 2022/7/26 11:05, Liu Xinpeng wrote: >>> memblock.o: In function `memblock_find_in_range.constprop.9': >>> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited' >>> memblock.o: In function `memblock_mark_mirror': >>> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore' >>> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not >>> specified") >> Fixs should not have word warp. > >> Tested-by: Ma Wupeng > I will send patch v2, such as, > > Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not > specified") and 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning") no,  see https://kernel.org/doc/html/latest/process/submitting-patches.html please check fixes part. >> +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__); > And removed the comma. > > > thanks your test, > Liu Xinpeng > --------------m0zQ3VREyHb09770hSSrhjBN Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit


On 2022/7/27 10:06, liuxp11@chinatelecom.cn wrote:
On 2022/7/26 11:05, Liu Xinpeng wrote:


      

        

          
memblock.o: In function `memblock_find_in_range.constprop.9':


        

      

      

      

        

          
memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited'


        

      

      

      

        

          
memblock.o: In function `memblock_mark_mirror':


        

      

      

      

        

          
memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore'


        

      

      

      

        

          
Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not
specified")


        

      

      

      

        
Fixs should not have word warp.


      

      



      

        
Tested-by: Ma Wupeng <mawupeng1@huawei.com>


      

      
I will send patch v2, such as,

Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not
specified") and 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning")


    

    
no,  see
      https://kernel.org/doc/html/latest/process/submitting-patches.html

    
please check fixes part.

    

    

    

      

      

        
+#define pr_warn_ratelimited(fmt, ...)    printf(fmt, ##__VA_ARGS__);


      

      
And removed the comma.


thanks your test,
Liu Xinpeng



    

  


--------------m0zQ3VREyHb09770hSSrhjBN--