On 2022/7/27 10:06, liuxp11@chinatelecom.cn wrote:
>> On 2022/7/26 11:05, Liu Xinpeng wrote:
>>> memblock.o: In function `memblock_find_in_range.constprop.9':
>>> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited'
>>> memblock.o: In function `memblock_mark_mirror':
>>> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore'
>>> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not
>>> specified")
>> Fixs should not have word warp.
>
>> Tested-by: Ma Wupeng<mawupeng1@huawei.com>
> I will send patch v2, such as,
>
> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not
> specified") and 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning")

no,  see https://kernel.org/doc/html/latest/process/submitting-patches.html

please check fixes part.

>> +#define pr_warn_ratelimited(fmt, ...)    printf(fmt, ##__VA_ARGS__);
> And removed the comma.
>
>
> thanks your test,
> Liu Xinpeng
>