From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: "liuxp11@chinatelecom.cn" <liuxp11@chinatelecom.cn>,
mawupeng <mawupeng1@huawei.com>,
"rppt@kernel.org" <rppt@kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"david@redhat.com" <david@redhat.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memblock tests: compiling error
Date: Wed, 27 Jul 2022 10:20:41 +0800 [thread overview]
Message-ID: <bf4d1261-474d-121a-565d-d79a9c093d7b@huawei.com> (raw)
In-Reply-To: <202207271006248558685@chinatelecom.cn>
[-- Attachment #1: Type: text/plain, Size: 976 bytes --]
On 2022/7/27 10:06, liuxp11@chinatelecom.cn wrote:
>> On 2022/7/26 11:05, Liu Xinpeng wrote:
>>> memblock.o: In function `memblock_find_in_range.constprop.9':
>>> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited'
>>> memblock.o: In function `memblock_mark_mirror':
>>> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore'
>>> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not
>>> specified")
>> Fixs should not have word warp.
>
>> Tested-by: Ma Wupeng<mawupeng1@huawei.com>
> I will send patch v2, such as,
>
> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not
> specified") and 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning")
no, see https://kernel.org/doc/html/latest/process/submitting-patches.html
please check fixes part.
>> +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__);
> And removed the comma.
>
>
> thanks your test,
> Liu Xinpeng
>
[-- Attachment #2: Type: text/html, Size: 3978 bytes --]
next prev parent reply other threads:[~2022-07-27 2:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 3:05 Liu Xinpeng
2022-07-27 1:01 ` Souptick Joarder
2022-07-27 1:03 ` Randy Dunlap
2022-07-27 1:53 ` mawupeng
2022-07-27 1:53 ` mawupeng
2022-07-27 2:06 ` liuxp11
2022-07-27 2:20 ` Kefeng Wang [this message]
2022-07-26 3:21 Liu Xinpeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf4d1261-474d-121a-565d-d79a9c093d7b@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuxp11@chinatelecom.cn \
--cc=mawupeng1@huawei.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox