From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D1A0C83F2C for ; Tue, 5 Sep 2023 07:32:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A2E0940007; Tue, 5 Sep 2023 03:32:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 752158E001A; Tue, 5 Sep 2023 03:32:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64269940007; Tue, 5 Sep 2023 03:32:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 58FB68E001A for ; Tue, 5 Sep 2023 03:32:46 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 32039A0AB0 for ; Tue, 5 Sep 2023 07:32:46 +0000 (UTC) X-FDA: 81201726732.08.0EEA0DE Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf24.hostedemail.com (Postfix) with ESMTP id 2EEB6180012 for ; Tue, 5 Sep 2023 07:32:41 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693899164; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7tiIvQ1WoUGflw8s7jUAA0FNbo9ghvTLREDKNJCf0jk=; b=m3OOwJzhgf4aL268bL+lQkOKwwWHpTFTmPi/HxjVAJeTBgJQkLVtMIQwxGFKk6nAtExJ59 abca/xRbo5ei1jgr9vp/Yg0JRmFaKZU6LTfw4s2fTLbVxEeqPgl+AsfdrCVlWvn6jbpdCE A2EAHjJqlEbnXtgRT1vuIpMCT0eSlp0= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693899164; a=rsa-sha256; cv=none; b=h2aKL1MnoIQmR74xSTCHuLdF4FgwXWgKGDW5SPXgpj112FgkWAur39G5eImAfwl1aswxKx tPLp473bOqei6nP67Zr3JtRXw5viK/KyvVdYkoYvsgavWeYerDYSiYf2SD8B6LSMQrb/Vs tEP439mvxsuhWYQ22l7h5P1oWG4sEi4= Received: from dggpemm100001.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Rfxxj2PKHzrSdM; Tue, 5 Sep 2023 15:30:49 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 5 Sep 2023 15:32:35 +0800 Message-ID: Date: Tue, 5 Sep 2023 15:32:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: hugetlb_vmemmap: use bulk allocator in alloc_vmemmap_page_list() Content-Language: en-US To: Andrew Morton , Mike Kravetz , Muchun Song , CC: Yuan Can References: <20230905071016.2818810-1-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: <20230905071016.2818810-1-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm100001.china.huawei.com (7.185.36.93) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 2EEB6180012 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: zfr3t3xge3fgke1q3itutwgy8yttgci3 X-HE-Tag: 1693899161-568441 X-HE-Meta: U2FsdGVkX19r5ZzSjqDrWTKGq7ut9GZvvdxZKnpev2FVE7iz0Nna4RPB95w2gCAuYKikBQAV9MRqE3C90RE78HIZTVJVQ7iy6BLciIV8DHdMxgNT/3pIM59TWCZteu+3xeW4NTpBSykvJD+ZDGmQ6k5ip4HTPDf0hCV/qVPViCxi6gZzyA1F9oj+e5yVGOxMhRgAAmBdt7dFTg8mQoFvUOkikYP8U9yftxrUBWll5OQxDT9dpSpt0Yi0zSxBtso58IlyLTntFYuuy7JT4LeCXp9ww+fCBkfl+Ef9D9Dvd3k20ROrm/QJqxX6kGo0VrOS3+tTOJ714JM7Fp3+6WqKWgI3KJJ+dTThYwEhC/nZRUTvfUWAGUCPJj11r5DE8boF7XVMAO48PHay3GyF3c9mSQqMfUgSoElQGrKupz1jvcAPD9Lw3WWtma5nkNUKf27G87nneJE4O/7YtnsqV7gdW5GaJ36PDM4dK2QKoRa3maXBwMBHlaDpwoWjNkea3ipT274lU10NP5nluoqHU6Zx0vnvMnUjcR08vL0+EZ8c9EYCNOmqXE+aqaCuHhj4dJ6Axhc1V9yX8o6Wcxvreh9i1GwKfCgpdY2BSPkVAqmWuQ7Xo14m5ISWmNFqUPq52lsborMqqRecDryyPoLuZh6A+WXK+ghbVfBYy63UtHYxUWxQloyUPQ2DT1EcpsYjabDeVAo4iTXJHZ/u39TfMCjpQdrFipyBg2dETZp+wtqqV+vNULQHqAvSedAgDuR9lhBO6p6RZ7xxNe68EJDysK3JHzFpshYMyofyzrLZAzj/1uKweFeQ77QEUjOGqOEfoFb0k1Lrn2+llP3UtiTCSxgKB38ia+OKpwg0NM2e9Yx9F2DNUN/ZjWgRn5kuwQaWdpL9V+ow72BRejAmFE1m+x+MEJ9y1VWUaih2aDJ0xJeHL5IXBYUxPb/XoQzR4nt73BR6J5pcd/zJMF+oLpKtW6Q wAojjlhn ZMdbCPvzjqjMYcRUIbXryBcOxDRSGh6kh2TCPJLMS9UWv2UiWRZqeE0jqwt+sxVq4x8aO7gLlmJcvYN98E8Mkm71EOEU8ziTsYCy1yFFjDV0v0AbGYgs8Y886awAhIqkoFq9pEMIBAHX7Gg82Y32Spg11/JCgdtIRo0PHnZv2oDLNVeDJibQrSpgucCOAwiROLyAQAU8ihra8mGMpxERR7T3prqPKfYAMx0Cl8QSusMSIHOc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/9/5 15:10, Kefeng Wang wrote: > It is needed 4095 pages(1G) or 7 pages(2M) to be allocated once in > alloc_vmemmap_page_list(), so let's add a bulk allocator varietas > alloc_pages_bulk_list_node() and switch alloc_vmemmap_page_list() > to use it to accelerate page allocation. > > Simple test on arm64's qemu with 1G Hugetlb, 870,842ns vs 3,845,252ns > despite the fluctuations, it is still a nice improvement. > > Tested-by: Yuan Can > Signed-off-by: Kefeng Wang > --- > include/linux/gfp.h | 9 +++++++++ > mm/hugetlb_vmemmap.c | 7 ++++++- > 2 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index 665f06675c83..d6e82f15b61f 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -195,6 +195,15 @@ alloc_pages_bulk_list(gfp_t gfp, unsigned long nr_pages, struct list_head *list) > return __alloc_pages_bulk(gfp, numa_mem_id(), NULL, nr_pages, list, NULL); > } > > +static inline unsigned long > +alloc_pages_bulk_list_node(gfp_t gfp, int nid, unsigned long nr_pages, struct list_head *list) > +{ > + if (nid == NUMA_NO_NODE) > + nid = numa_mem_id(); > + > + return __alloc_pages_bulk(gfp, nid, NULL, nr_pages, list, NULL); > +} > + > static inline unsigned long > alloc_pages_bulk_array(gfp_t gfp, unsigned long nr_pages, struct page **page_array) > { > diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c > index 4b9734777f69..699c4fea6b9f 100644 > --- a/mm/hugetlb_vmemmap.c > +++ b/mm/hugetlb_vmemmap.c > @@ -384,8 +384,13 @@ static int alloc_vmemmap_page_list(unsigned long start, unsigned long end, > unsigned long nr_pages = (end - start) >> PAGE_SHIFT; > int nid = page_to_nid((struct page *)start); > struct page *page, *next; > + unsigned long nr_alloced; > > - while (nr_pages--) { > + nr_alloced = alloc_pages_bulk_list_node(gfp_mask, nid, nr_pages, list); > + if (!nr_alloced) > + return -ENOMEM; > + eh， forget to inc nr_allocated in the fallback patch， will resend > + while (nr_alloced < nr_pages) { > page = alloc_pages_node(nid, gfp_mask, 0); > if (!page) > goto out;