From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4CD3C30653 for ; Mon, 1 Jul 2024 13:51:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 325006B0096; Mon, 1 Jul 2024 09:51:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D5A16B0098; Mon, 1 Jul 2024 09:51:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14F626B0099; Mon, 1 Jul 2024 09:51:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EB66A6B0096 for ; Mon, 1 Jul 2024 09:51:11 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 979AB81B58 for ; Mon, 1 Jul 2024 13:51:11 +0000 (UTC) X-FDA: 82291320342.27.7003C9D Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf23.hostedemail.com (Postfix) with ESMTP id 46BBA140005 for ; Mon, 1 Jul 2024 13:51:08 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=MV7rCaNH; spf=pass (imf23.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719841858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wkwol188JKz1B5rW/B2G6vVOO1OrwlFykqlmh5zqw50=; b=Lg5sd+gME0cpKxDQPr7W7NrOFeB65rkcy4C6wfDPaGtgPmY7tN2oRA6Zk6EckWHbDTW+oW T6RNSRU3mZhSMF9DYuEgXOw7WGwv0nP49FCZRp/F3l4dOpRdCTgdGdk961rmn81mO5TudW B0Shnj9YybLS2KhnUGFevlKj++7MqRk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=MV7rCaNH; spf=pass (imf23.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719841858; a=rsa-sha256; cv=none; b=qaB8ZqKsc7vQr4k3Ul1MnvF1ju9Efl7/dkPOTacUOBbvunfSPfkW2SuvrghN2J59sbXuVI 1CYfV4+wKgkwvkj7dW2VvFvXya47JLk3oLRMo8ASZNLwNWE83uZzMWpNTbS/gs60AHGWON 165jG3c8wS5iA/8y/o7bDKSN6vheZpk= Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 461AN4X7026803; Mon, 1 Jul 2024 13:51:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Wkwol188JKz1B5rW/B2G6vVOO1OrwlFykqlmh5zqw50=; b=MV7rCaNHpn+PXDsa 3Xl7feCm29yqBcWJ8LmecGxdkD9et+XGl+uKsA0aTwJmwPEatQeRSoXoB5SPDNj2 L498AAA92W+79pPhwk4gvpN5G4+uypZXazXWmSbEZ1cJkFa/DrkhD3PIJa23j2Pz zDx4WQNBqCuvjtcnaipainxpIxqahNtq1ZSYTUobeIPw8k4rS8RXRlz/slR1JDhD j1cfH8g3D+JvZBloke7BvGZkYY1JDEcwxa5L/Q9i3Qz963NXxOt2y+rKbDySAxfJ axAZtxYZmPXeCHYIRABnVM7g7yzcFaX/Gh2xqCGckb/IQjm8KwlmlSVu+phZVNSX PlNmxw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4027yf4n8a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 01 Jul 2024 13:51:06 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 461Dp6vd032388 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 1 Jul 2024 13:51:06 GMT Received: from [10.214.66.164] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 1 Jul 2024 06:51:04 -0700 Message-ID: Date: Mon, 1 Jul 2024 19:20:21 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] mm: Prevent derefencing NULL ptr in pfn_section_valid() To: Waiman Long , Andrew Morton , David Hildenbrand CC: , References: <20240626001639.1350646-1-longman@redhat.com> Content-Language: en-US From: Charan Teja Kalla In-Reply-To: <20240626001639.1350646-1-longman@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: AwV5igHBQTKOIQMPkCqXNOuxXVHgNfL2 X-Proofpoint-ORIG-GUID: AwV5igHBQTKOIQMPkCqXNOuxXVHgNfL2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-01_12,2024-06-28_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 mlxscore=0 lowpriorityscore=0 mlxlogscore=657 phishscore=0 impostorscore=0 clxscore=1011 malwarescore=0 suspectscore=0 adultscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2406140001 definitions=main-2407010107 X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 46BBA140005 X-Stat-Signature: gsbt6kqdbip59371m9eixru1nbm934cu X-HE-Tag: 1719841868-595932 X-HE-Meta: U2FsdGVkX1+wHbweh2AM89TN9RaxvYTNFi4iAjIFNv8xJA6+ebRcGtA1K2m9oibCg1ScU+J+JVBntAN4SDJENLU0joRe5H92nfpU4l7hUx71lDHbWmqRoSlveymuZF0kAml8wYGhX6LP38A3gL3mYB4/md2Gw28rqnLx1VvTWBVnY3QhufjSa3BzHqyNNBweB2wQT8LTXuLqd6yLYa2/ZxIFfjJdYD46VGemgCJffLsYeDYPZjLQtyOSKUIeQTD0aLncnpxDja6Oy8Njn6ki7dMZrCLM7XtjLL8Yy1527OyoN0Np04eBboW0AOumoGQQBnxbC9p81uOHRFgRCQSpxkExnt0VapHyNbz7p751UX/jk9UKTCSKTC/FDh7yA9qzHSKLZuG2VuCHBc0pUrz4+zp2hCKQsYyLH7hiJAqJ6QDYWjrKiD8c8daG3L87wzCpnKowowd/VIXxdHuKPrPpp94easO9peC6QQYl9X4mUur4B1SOWh/bEcVW53+dkhG5a7S4IYqAKB+/erGDplcm+JslczUdByyMR0EnFLYnEDseUHp+SjzBz5PwFZYismTIa9Hht98hTLs7QGpnjz7djiS2Z04saMiSNecG9PsEe3njpZhLqVupgHLq47PG5YpYU7B6B751ESOa5hrCi1gq3bHOnLN6Zk50NSYEnBGdfX856IVXmXXBynxVQYcIYtrqD7JQELpYCxGk55/HT2ZK2vxCUQZWSpP2FwpWGH+xl9cf7Mx5Cj2sMLiARM0fqtpGv4piP9kt8tSikdlx2xbLvecF1lHojtrIDgFz9qURHya6rYVpGLuXadj+b4C47mtCeFoUac7fWCMD70A7uCXQMScdMSzTkCDXdGb0WcC3dNeG53Gh8aGjXJfeB40gYXCj6ep3ytvHGvEQZGvY8zppCKja/Prwjp8rMkwLo0nBz/dRbQAxkEgUQ7c6hB9XcH8lvFEWmMYSNov0WcnWNpG vZcz9TXh Duj21nbU0qiamZAOrIFhP4ccs+X6+jyYvBo0vnK4c3HgDyAN/XnssSYXipJ71h8EvD/C7dUqnPTxvxldNIEW6hgl6MnLH341YLkF+cGAPgwS47v2/3OeLn4q8ATw6DDv8+eCmusRlrN2uIEVKkHIeVG17cRdAaqSdggFXhKX7gpCO+0NEqEB8/NEyeI3fySI2quYkctK5Z0wkoybPPORzbFx/4cWdTMg9VpiTx6rp7bB4wHRlhsGbL7qLev+h9cHwEOxFSihDheNbldk83PB0pDMXLkHeXmWPv17dD/0YbsHwA44iS21KU4ix1w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Waiman, On 6/26/2024 5:46 AM, Waiman Long wrote: > Commit 5ec8e8ea8b77 ("mm/sparsemem: fix race in accessing > memory_section->usage") changed pfn_section_valid() to add a READ_ONCE() > call around "ms->usage" to fix a race with section_deactivate() where > ms->usage can be cleared. The READ_ONCE() call, by itself, is not enough > to prevent NULL pointer dereference. We need to check its value before > dereferencing it. I am unable to see a scenario where ms->usage will be NULL when pfn_section_valid() is called: 1) In pfn_valid, valid_section() check ensures that pfn_section_valid() is not called as the section is marked as invalid. 2) In pfn_to_online_page, online_section() check ensures that pfn_section_valid() is not called. and in the update path, we do: kfree_rcu(ms->usage, rcu); WRITE_ONCE(ms->usage, NULL); Could you help me in understanding about what I am missing here, please? > > Fixes: 5ec8e8ea8b77 ("mm/sparsemem: fix race in accessing memory_section->usage") > Signed-off-by: Waiman Long > --- > include/linux/mmzone.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 8f9c9590a42c..b1dcf6ddb406 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -1980,8 +1980,9 @@ static inline int subsection_map_index(unsigned long pfn) > static inline int pfn_section_valid(struct mem_section *ms, unsigned long pfn) > { > int idx = subsection_map_index(pfn); > + struct mem_section_usage *usage = READ_ONCE(ms->usage); > > - return test_bit(idx, READ_ONCE(ms->usage)->subsection_map); > + return usage ? test_bit(idx, usage->subsection_map) : 0; > } > #else > static inline int pfn_section_valid(struct mem_section *ms, unsigned long pfn)