From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D259CD3445 for ; Tue, 19 Sep 2023 07:06:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2375A6B04B6; Tue, 19 Sep 2023 03:06:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C2FE6B04B8; Tue, 19 Sep 2023 03:06:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03AB66B04B9; Tue, 19 Sep 2023 03:06:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E33546B04B6 for ; Tue, 19 Sep 2023 03:06:00 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B0A83B3C02 for ; Tue, 19 Sep 2023 07:06:00 +0000 (UTC) X-FDA: 81252462480.29.B9429B1 Received: from rivendell.linuxfromscratch.org (rivendell.linuxfromscratch.org [208.118.68.85]) by imf27.hostedemail.com (Postfix) with ESMTP id B3F0C4002A for ; Tue, 19 Sep 2023 07:05:58 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linuxfromscratch.org header.s=cert4 header.b="aqoK/Ilc"; spf=pass (imf27.hostedemail.com: domain of xry111@linuxfromscratch.org designates 208.118.68.85 as permitted sender) smtp.mailfrom=xry111@linuxfromscratch.org; dmarc=pass (policy=quarantine) header.from=linuxfromscratch.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695107158; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T7nfawYenRjk+4ZCMjkKSaoE2W7ZD+Q1umpTZ/cT6R4=; b=E2kRk4Cnim5yhUC8e1PbXByWsDvUKJCkNmxVpbWIB1El/qq9/y0sWwdBI3fxWwWnZB7crO T5E3sFijAbDI1ZPBSzGlOh4fInZkX6c7PykMIkLH9Y4S+Q/tvAu6DoxHVJq8AxN1xhw5/r D8ULXhDzQARE6sYlztqmJgatI+mZnhM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695107159; a=rsa-sha256; cv=none; b=j8i8t75U2IN7IypoDJTsRHKa2mpkYTw6o2VmOkh/7lCiMD0sblRX1lCbV3YW1vpzwmn+za Sx7K1ah+s+ScyVQ7989xzi2Ln7gkvoXYSROPBOaDwjZgaYQLB0UtFW5juvmIWGOxBIeI9g drh2CA71OUWZwkA3Sq1b5EvAc7/WnB8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linuxfromscratch.org header.s=cert4 header.b="aqoK/Ilc"; spf=pass (imf27.hostedemail.com: domain of xry111@linuxfromscratch.org designates 208.118.68.85 as permitted sender) smtp.mailfrom=xry111@linuxfromscratch.org; dmarc=pass (policy=quarantine) header.from=linuxfromscratch.org Received: from [192.168.3.211] (unknown [36.44.140.33]) by rivendell.linuxfromscratch.org (Postfix) with ESMTPSA id 26A431C1DD6; Tue, 19 Sep 2023 07:05:30 +0000 (GMT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 1.0.0 at rivendell.linuxfromscratch.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfromscratch.org; s=cert4; t=1695107155; bh=9wNEeAzCOPg0mCdyHRKNEVbZmXBmTaugcI3ERiby3k0=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=aqoK/Ilc8LvyUE+Xk4kK0TbIhFHarWsn2uBwrCvOIBF6xZoiA1f4tJ9dbKWFKRiu6 paL+GBbo9SPpEBIbiWrsPB0XfpKTd2+G50VtbF86FGHEVOMJSrRDmkMaTUMORk6h/3 qLapgrTCCQmetnyxXQd0oMfEVgIT+/HKvVoU4IKX272amD2+FjwGF7/9QSILQuggfV BI6kNxpQvUY/+hAogUxC35kr9T5IahyPaFtyYIDE5cZir6pdZggqKuZtpzkHOubZ1J isHMMtWcQM3xaSsKJn5GsqEfCinyGk71Ww3uWLHV11gy8ssXk8BO2mWnXKo2ok/N19 WGA2g3mo4aO4w== Message-ID: Subject: Re: [PATCH v7 12/13] ext4: switch to multigrain timestamps From: Xi Ruoyao To: Jeff Layton , Alexander Viro , Christian Brauner , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, Jan Kara , bug-gnulib@gnu.org Date: Tue, 19 Sep 2023 15:05:24 +0800 In-Reply-To: <20230807-mgctime-v7-12-d1dec143a704@kernel.org> References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-12-d1dec143a704@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.0 MIME-Version: 1.0 X-Stat-Signature: f6j1aa1kynb98m3f5d5brxfkc97fa93y X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B3F0C4002A X-Rspam-User: X-HE-Tag: 1695107158-52124 X-HE-Meta: U2FsdGVkX1/UDRCmVDtUcJKSL/dJNQLlM3XefvhObOe1YliW2y4TvDOCvuQXfUbL81H4aBEqFXbcyg5DPlS27Cg7cKuz2dE5wA/QgQv9lqmfIyHeaSt4Dpn0aVDp79x4HhKNVAihsD0FR7gLK4UFrTcTrTTXuKy0Lpk95x7Cd7Up09By8fgwGVL8H5SeRgi1LhdD65PMENfXto28hqv8byolY/OeQBGZ0mCUp791qdsh53aLp1lqNtYiBjTc5VSvtJ9tkPybnor1Gt4hwX2xgyI/EVRjO8dmLQ6aiq7pVbXyvbT90gYKsFD/nMKEvpG+w4cGc44DhfrUQyXj+eiZU5aXkU7zmlf0pRrgbDKHuNSlP66v34dEAR+qpn7pWtBsKg+P7Zjy4qjLdUrcwgUtJHPfBnYbAgIODxLcmU6Rai6l2g9CcEHjQWeJrdDK0XxS6YsMRY/z/JiE1yHceHVNsTTUwfuF+jL0vShoxgCQaDgUeogZJaJognd10aRPbATaRCOk0c/7W/7/lbTikc53XUwDYwgQkjFyT2adD8aLCvEeW9UUUGcvalUr9N8rD/APKIERYv88l4iEwX5Eim/z6KhtzoSDrhNmqpHFnOWFxqRdIdU3kPgtUkTIEEVrMyEqBwyKcjK2wQYyy9wzAGHFSQdjqOkHLqXEoLE9Hi2iN6ttmQTk913gaOc9Ad0veDkn8iRE5OAt19YwDnVZDvjmfdND9jmXtKrJqXAMg/wcHjJDDhitICITmtWH8lECt7+xpnbZ4QRbBd8Izt8gvmVEgJdlDaSbFBItKj3+8h/qtdbWoSDs6h2u2hyAacCrhRkOCzDtpgSvI9Xhsw7fzO2LhPKZqZhfTfg+dYF/EhCK+ljdKVtO0FBHFbRLT7SumyYDNNL4KGVo+n6GgoOI5lufPZKVVEeamp0yKxEOEXJQv/3T2HFFEo9SpBBIDAZFXRw6oSzwW80RtbFuTFycYJp KircNMPO jPvHOXqIfqK8YklTkyaYx8Gkbi8Z0lQyDMPaTMR5XG9mSBukQ4w1KJ7k5oVpRCKEacx1okfXL5zDqUoCKfi4jELcFCYscfNvJrHia9mwA/s++SwufTooJE7b/3Rx2TGO6F2qCEE/Db9rperdrq0GcJYlskhmTybE+8tmCehEb+9kM1aoo/9kO5UAJNo900waTT+RQmcFoo1f94c9/h6CIe9mPtNN1iRMzrM2J66rWtPDGiCZ09hJ9ljKnP7nFA4G8TDuQS4cnmxPU/8k86+iHuaY32w3PZQLvWPmEH/vULelzcNCFOQ3HSlFvq8bq4fZW3Mw3OqnbZtxLnAM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 2023-08-07 at 15:38 -0400, Jeff Layton wrote: > Enable multigrain timestamps, which should ensure that there is an > apparent change to the timestamp whenever it has been written after > being actively observed via getattr. >=20 > For ext4, we only need to enable the FS_MGTIME flag. Hi Jeff, This patch causes a gnulib test failure: $ ~/sources/lfs/grep-3.11/gnulib-tests/test-stat-time test-stat-time.c:141: assertion 'statinfo[0].st_mtime < statinfo[2].st_mtim= e || (statinfo[0].st_mtime =3D=3D statinfo[2].st_mtime && (get_stat_mtime_n= s (&statinfo[0]) < get_stat_mtime_ns (&statinfo[2])))' failed Aborted (core dumped) The source code of the test: https://git.savannah.gnu.org/cgit/gnulib.git/tree/tests/test-stat-time.c Is this an expected change? > Acked-by: Theodore Ts'o > Reviewed-by: Jan Kara > Signed-off-by: Jeff Layton > --- > =C2=A0fs/ext4/super.c | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index b54c70e1a74e..cb1ff47af156 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -7279,7 +7279,7 @@ static struct file_system_type ext4_fs_type =3D { > =C2=A0 .init_fs_context =3D ext4_init_fs_context, > =C2=A0 .parameters =3D ext4_param_specs, > =C2=A0 .kill_sb =3D kill_block_super, > - .fs_flags =3D FS_REQUIRES_DEV | FS_ALLOW_IDMAP, > + .fs_flags =3D FS_REQUIRES_DEV | FS_ALLOW_IDMAP | > FS_MGTIME, > =C2=A0}; > =C2=A0MODULE_ALIAS_FS("ext4"); > =C2=A0 >=20