From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8D2DC77B7C for ; Mon, 23 Jun 2025 15:33:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61BE76B00B9; Mon, 23 Jun 2025 11:33:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CC956B00C0; Mon, 23 Jun 2025 11:33:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46D5A6B00C7; Mon, 23 Jun 2025 11:33:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 355DE6B00B9 for ; Mon, 23 Jun 2025 11:33:30 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DB98CBB6B3 for ; Mon, 23 Jun 2025 15:33:29 +0000 (UTC) X-FDA: 83587059738.06.7DF06BE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 7FB5416000E for ; Mon, 23 Jun 2025 15:33:27 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K2qwDaTb; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750692807; a=rsa-sha256; cv=none; b=Vz/SiHTIEaiVwhtrZcrnKp3OJWx/eZo+Yb7j0hgA9vF+N61tEdh3fOQ1q9yK815dqru4be WjIpgFekI4RnXdPd0sOy1qq8QQOzQbWjoGiG6SoQS2mzxQZ9s2+47SSgEUrHsCto9oiBiu mQ1SVaLxRhC8X2Z/G7nI4x8NCGKXpVE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K2qwDaTb; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750692807; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VMFE5XFmCnZwpDxXjyOQUDgj/ACDl6iF3epiv58I+/k=; b=T3AfrO/zbh8oYR1y3HT7X9HGUOwRSgTXtLpCyY/TPx4FE3Gz5TQTdX3hp8P1DiczNEHDwp BewKRMqrFGUlbsuUIUmiedGyoMEIiK6fW7aN8wcBDwY+YhG/fldC5tSPK4W7oR5Nh0BPPY qFvM0zjHuOkFSjhjwXSgXONZtPrvtJ4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750692806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VMFE5XFmCnZwpDxXjyOQUDgj/ACDl6iF3epiv58I+/k=; b=K2qwDaTbDZf7XRVml9Z9htxZ6N7b7V0mslw050l/zYMS792f8oMJMJ9orYJx53rBVtyk3w BTuPu2QoqBRu2SCH38sO+n9bxYjVnSSR30xmPJ6O9+gU5FW09pcztXoF+vXaYqJfHSIDvF /1iKQ/4cgkRM2TKr9QSyzGDdA7DFwa0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-454-pr_0gh_3N1eC9Es5cOuEvg-1; Mon, 23 Jun 2025 11:33:20 -0400 X-MC-Unique: pr_0gh_3N1eC9Es5cOuEvg-1 X-Mimecast-MFC-AGG-ID: pr_0gh_3N1eC9Es5cOuEvg_1750692799 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4fac7fa27so1645780f8f.0 for ; Mon, 23 Jun 2025 08:33:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750692799; x=1751297599; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VMFE5XFmCnZwpDxXjyOQUDgj/ACDl6iF3epiv58I+/k=; b=uWYpiBDn+aVSjLreTC79U4U+/kbtNbZ7aROPVRECR9HGlFbF0MtjRbtjKNIG2hK+Ex F103HdmqJkhvJFsFNfb6Frw57j3i1yAa8oA291XeZjvi5lecR0y3A8F8oBS2VyZuWXVD AvmEYScnKsLVEU0xNzIsaoxSkOU4mHFv1YktYqWU+hZx6e9fJdGxdQ7oJsakjgdPX6FF JHRGbHzIjAKmeSfy0KKmyIG2k6KDVb7H7XdVoZepu3e/HuqgumtjfK3lXxTZcVuw7wct wXGHd4FVeSCoY9KIa7VZEIu7TmYcRDE+ouwqxRpyUI2Wz5SuPO0XBmE/sivJJjC5wPqA /mkQ== X-Forwarded-Encrypted: i=1; AJvYcCUkgWrhXKLFcJmsvAsY+oz+zXADzWF9q+8fXqa0gl19gzSILQ5lO9lrRMnu+GxWhR4S+fJxYTpS/g==@kvack.org X-Gm-Message-State: AOJu0YxzrPO7N/H9iw/RzexdwSP3h/FRdTvouh8rIdUTqvjQ3kG/MrHO fgqon+/1AsSvgxNVJX3ipTiBAvfxpx85Hi9rmlcwoYisB217C1XjGC+O01hdkHq8YEXu0U85kc8 yC14CBIJJHTNCR7y7v5EXwT8ChFVUOnwRU6u3XuvcjwVjWc93hpMe X-Gm-Gg: ASbGncvN8hU4ev5e597L+z1shaaXc87eFl++TSo/FGR563xTErAq6hrCJ8nYyf80NnM oeWR7ToKSQD4qwqMgLVafKhi5fL2J7YYnfXX6Wzsm0nfmMxR8boDwR6lRfER/TKD4qHgo/3s5wR z9gU6AACn9eSzKbGedhaq3tV5WEvorXVFMWAepLHJyfuMaIr89/J7+gr8G7gQJXaRbQs1pjJlKB WpiCUX3a5xUHGSww2W7UBAeN2IDdSGsLxsTzcXL14kLY+SUiVkFZrNNe/GI+3uy2xYnm8diM7UC YJkuA+iLeOqH8P35Ww/0z3KYiVOZ0xV+N90eNPHnXXcphkFcExqXgN9AyMEpdRi0pXpP2hdrwnB udRsIbJMb+mtgI294XJEBJFK2AoUtkAjfbdQsOrMfYAKyDHN1Rg== X-Received: by 2002:a05:6000:387:b0:3a4:edf5:b952 with SMTP id ffacd0b85a97d-3a6d130453amr12674322f8f.36.1750692799211; Mon, 23 Jun 2025 08:33:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE85hMTnbdKxy1bT4Kk698V7XUcW8rVuxvFEPAA18LssuPVWWrj7O2eHAW4gMzCB9Bjo1Zu+g== X-Received: by 2002:a05:6000:387:b0:3a4:edf5:b952 with SMTP id ffacd0b85a97d-3a6d130453amr12674261f8f.36.1750692798755; Mon, 23 Jun 2025 08:33:18 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159? (p200300d82f4efd008e13e3b590c81159.dip0.t-ipconnect.de. [2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d0f18152sm9522292f8f.27.2025.06.23.08.33.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 08:33:18 -0700 (PDT) Message-ID: Date: Mon, 23 Jun 2025 17:33:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 07/29] mm/migrate: rename isolate_movable_page() to isolate_movable_ops_page() To: Zi Yan , Matthew Wilcox Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250618174014.1168640-1-david@redhat.com> <20250618174014.1168640-8-david@redhat.com> <9F76592E-BB0E-4136-BDBA-195CC6FF3B03@nvidia.com> <4D6D7321-CAEC-4D82-9354-4B9786C4D05E@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <4D6D7321-CAEC-4D82-9354-4B9786C4D05E@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tYa7p1Hi0W5TSFgbsJ-Tc4IAvaR77F9KeQmKkxOOmoc_1750692799 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7FB5416000E X-Stat-Signature: mgx7x1ebh1fu9dhax56ctwa3gopi8a7d X-Rspam-User: X-HE-Tag: 1750692807-85669 X-HE-Meta: U2FsdGVkX1/1iQLoFFSknqQBf6mA/veATJjj3TFY01HPpdVrdScExl7XzK3AoQnfUhqYAFDzR/zxEWA0psGBmDlQCYjQtAthkbN3+CE7WfD+XkjrMp3cuBDEJ3uu1AejVqJGDvbvH4PcEITWic9sVj14RkytIbwmnm01YF5a/dzaSNWf92jNqvlte5uJRzzCafiJNOt6ENEy5VAXEVNlB5lhdX2gPwzENpnqts1yncls1DwYQRYxyvMrf75vYgsmCoZPcnSmyau67slWiR4Rx35N1uyqTxNXAYU1NPwEyJX9fpzwvqw9cOhBuXcS9MF2tNlIUH3qr/BrwStmdWZLwUAJT+qkaxUTGKGDTp78OfYc8KQzO2tV+2xvCtSwIApQ3fYqr3hWmgAOunDj9FAI6FZZRBurZPlFgpHGJVK2TBlonrytq1MJWDl80uqCOQn6X26ejD9NOlbCLovqGx2UO63XsCnTKgRIu5YX/Bz7TojrnVCL2btP+1oCAiOlxGaViesT9RhNRoTjIa164/pXf7lm7POLieO0rhN8lqG3Q6ImEL2+45n/hlgYkqgkyzOCorkZJNREb7MYimuh5XwX+n6hIEJ6oWVMK5OiaC64CTXZ8LGuJYLouwlkdu2MgtyIWaopfQgUd0CH6t0t+jTbzi4pTZlmkDStQWRlaM77kZM1yNo0B3pXquQB24NAr4kiMF0j19Cpgzp4HBYrNrPgDdfdHT5iJJmGPVDL0lL5fSSSABjyLvT52mupdynwCqhF+p1MUvTxxWtGg673BMpMLShv/Bcy4Th3maF8ngKwLZZWYPiUyCCz5hSvAwGETQpwz3u4sw5v1Y4NkoRivBte37ek826TB16cdj2G93gl4Sya0DdNHBKnH0incBDZnbjoFU7taEzl+q05k0gDUYmXOdvV19mLKYRohR1CBrLriT7BTMiio88XyrtEMn2cDUTNO8XCcW21A3X238esXwl 5OU2xu+N KUhXo2w7Flph6izwN76MiKiY5hgsbMgIBAa3+f8H9xf59uJ0QMS3d6mj+ED1KNlr9lXEbvMS1/LepRLx+5bNLj5GYtxDaJ0VEU1St6eiEigUyowmGltJbukw4BdqwWT++qynxRv1EzSCB5U+fj+mb2StJg0gno2H+Ysmm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.06.25 20:48, Zi Yan wrote: > On 18 Jun 2025, at 14:39, Matthew Wilcox wrote: > >> On Wed, Jun 18, 2025 at 02:14:15PM -0400, Zi Yan wrote: >>> On 18 Jun 2025, at 13:39, David Hildenbrand wrote: >>> >>>> ... and start moving back to per-page things that will absolutely not be >>>> folio things in the future. Add documentation and a comment that the >>>> remaining folio stuff (lock, refcount) will have to be reworked as well. >>>> >>>> While at it, convert the VM_BUG_ON() into a WARN_ON_ONCE() and handle >>>> it gracefully (relevant with further changes), and convert a >>>> WARN_ON_ONCE() into a VM_WARN_ON_ONCE_PAGE(). >>> >>> The reason is that there is no upstream code, which use movable_ops for >>> folios? Is there any fundamental reason preventing movable_ops from >>> being used on folios? >> >> folios either belong to a filesystem or they are anonymous memory, and >> so either the filesystem knows how to migrate them (through its a_ops) >> or the migration code knows how to handle anon folios directly. Right, migration of folios will be handled by migration core. > > for device private pages, to support migrating >0 order anon or fs folios > to device, how should we represent them for devices? if you think folio is > only for anon and fs. I assume they are proper folios, so yes. Just like they are handled today (-> folios) I was asking a related question at LSF/MM in Alistair's session: are we sure these things will be folios even before they are assigned to a filesystem? I recall the answer was "yes". So we don't (and will not) support movable_ops for folios. -- Cheers, David / dhildenb