From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7964C5B543 for ; Thu, 5 Jun 2025 17:34:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A1A96B00CB; Thu, 5 Jun 2025 13:34:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6520A6B00CD; Thu, 5 Jun 2025 13:34:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F2686B00CE; Thu, 5 Jun 2025 13:34:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2E66D6B00CB for ; Thu, 5 Jun 2025 13:34:36 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D08C8C118C for ; Thu, 5 Jun 2025 17:34:35 +0000 (UTC) X-FDA: 83522046510.29.6CB94B5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 5002E18001B for ; Thu, 5 Jun 2025 17:34:32 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cefRyqHG; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749144873; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N+VarYqLQuGgClJsa5xpg1rG90PvZ9CaNT9z4QUrLYA=; b=ns6Za0ZTeh61WAfAHjFEdSrBHLt31ReiS60hrdnd863gLSqJ0PtyDZy+cN+W9cu3O22Y68 vjCIpl5frNl/nG1RiMMICbNOERcC2NChxXaoaQYWSa4Str0CRQnyKuyNujQSsmaqjexmI2 qFXdHF91LGuvKrUu0ixc6BSxHfprZOQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749144873; a=rsa-sha256; cv=none; b=l9EqYP3pp+FSOnDbz+fGNGSR5RIt6uxpYBa76S4RZjQ4AXzGHdFEx7bHoeW8Mj12ky8UPC eSWtAZfALq/alSjuAnRabKXFGzqNlfA5GfVl7h7hsWExwzvpvcqDl5rq5pUAlyAMsf4E4H 7nMGFPT+S4Md415qhmEt4boHqoq5ZJU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cefRyqHG; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749144872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=N+VarYqLQuGgClJsa5xpg1rG90PvZ9CaNT9z4QUrLYA=; b=cefRyqHGb18uwJ0fXDPp6FWw4tX4V1Vs9ZmmUpSxeTUzgwaqlT90TNoNfj9LjmCe+sNTsu DyzdjFR5WqZi+IgxT3n1XEb8PYIPFbb9JYFLnQNXB5Lkf1pxWPK05iX/zIvFuGhYXMv7Bi N+JoWX7jd0Whvb6O5HjLSEGLNVDh88Q= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-490-0jUnbIoXMm6CMB4QJF7IAA-1; Thu, 05 Jun 2025 13:34:31 -0400 X-MC-Unique: 0jUnbIoXMm6CMB4QJF7IAA-1 X-Mimecast-MFC-AGG-ID: 0jUnbIoXMm6CMB4QJF7IAA_1749144870 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-442e0e6eb84so8007265e9.0 for ; Thu, 05 Jun 2025 10:34:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749144870; x=1749749670; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=N+VarYqLQuGgClJsa5xpg1rG90PvZ9CaNT9z4QUrLYA=; b=ocNJEG9sEPw/a/QlLP3UfYyFGMRkYEmWCnhGa5KRMplQLNtNpnfmMcEKxG/r9jkrtj 3c1xA1mlJz6Msg3XB+bnLvzrsksx4tY0zeFbIkdrHE6qWstwWs+n2QhAXarMw7j06hei xYJx84PesR8is1iWGBPrFDiBDqW7YgdFZhMY65fceJ/FRGAX/vP4e2+NyvsAMmmFu4jt qff+3cHUVCH+guBcCoW+zsHKljus1/ejyJqxIjMHW2jpNtwBP6japszb5XOL6PHWGFKs 6sYRC25q3N5gSNxhkywfX+R5/wSra9xF07AMAeEgNWImdUfHtg2nm1nSAcEEBytXEcMd hfNg== X-Forwarded-Encrypted: i=1; AJvYcCW8SGNJGEcEvSVMPtZcmESNi4h4a3cBQlsrELqM3K6ZPhTqozFlWBrjwn1IbTK6YEmtV7p4Uw990A==@kvack.org X-Gm-Message-State: AOJu0YweXh4AJVJhOV/yQrI79jZc1LZpADTrbDGlwYX9iYwhIH1s9s8Z oWt5AfLm8o75s8AIlUXXeQsADpJH9eNlMQQ+5FVsYlChlOvzbpqgp+8mSUNPiVgqkxoKXQd4GvT Ix8s2L6YQhbuFcpUWIEO38SqL2q+UnmzEAQBzA+/Ysj6V0YRy9tWwSf6P0tU5n54= X-Gm-Gg: ASbGncujP3Flyz3vbSgs308r+FzDw4pz3pxh8Lz/UHtzllALq2Msw46oH6LSFLSnoVJ C13UwLJSCil0xkj8PjvvwzCZlZptTeRZrAemhcY+HLcwin1pUtgrWHOVJQnGcmfq9O/pjIf1xfM ZoM1HMPB29564gpjTWCKnSp/66Pht9kmPZw4nVg9Sy812jdgxyeRKhJS49gomUPabZLqNYT4Q2p p8eWXHanNOPWRwAL2f6drcbaZc1+wSBDJiuPmyxyMJC78hHVPxx3dBKnPEarS43F8oWH3kZjxE0 FBbPHgiJFlfH2fh1m1JPTDfe4+fgqynoQBkrH9nGltFQIhxH0FInXW59Vfh6FvFuKzRyuLgFMGE tiJZbscWfgl3nrYKAAfYLHPTdKLLj6XdghO1RAFvJgI7ysm8= X-Received: by 2002:a05:600c:3e85:b0:43d:300f:fa1d with SMTP id 5b1f17b1804b1-45201427814mr2246155e9.31.1749144869663; Thu, 05 Jun 2025 10:34:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFOIdwk9vIvHkwUdjltnf7udOV3nMdpRUY7MDy56aIo62nojlBrO6s9zCIJ94lF/1hMXSvDyg== X-Received: by 2002:a05:600c:3e85:b0:43d:300f:fa1d with SMTP id 5b1f17b1804b1-45201427814mr2245885e9.31.1749144869297; Thu, 05 Jun 2025 10:34:29 -0700 (PDT) Received: from ?IPV6:2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2? (p200300d82f27ec004f4d0d38ba979aa2.dip0.t-ipconnect.de. [2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-451f991967csm31016945e9.32.2025.06.05.10.34.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 10:34:28 -0700 (PDT) Message-ID: Date: Thu, 5 Jun 2025 19:34:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm To: Mark Brown Cc: Lorenzo Stoakes , Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250527-selftests-mm-cow-dedupe-v2-0-ff198df8e38e@kernel.org> <20250527-selftests-mm-cow-dedupe-v2-4-ff198df8e38e@kernel.org> <722628a8-f3fd-4fb9-ae04-2313a52ffb36@sirena.org.uk> <66db3d9e-73a6-4fcd-8abd-db65cfff49ab@lucifer.local> <661fc4ce-839f-4c47-bc3a-0c864e846324@sirena.org.uk> <077b6af0-bef3-4f1f-b785-9e351d01a89f@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qxPBo-c10fINCOMnnRc1tLYqzOvZGGnrwNQvcIJvukI_1749144870 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5002E18001B X-Stat-Signature: xojfgww8hxdk98nd1cssp76o4d4gm6uz X-Rspam-User: X-HE-Tag: 1749144872-32022 X-HE-Meta: U2FsdGVkX1/HB/HJdLlAzdXwYylv1eV2ujqjKP2xazzRQkTcxWEwr53IwBLLitDWJyuoiSvLyQDxUumRxrhzgbAFWcJwts5XVM2+w2sub3M/vdVGllXNYlqccB/KINYFTL0l48nEmcYyo8/7UM+jr/kp7JdnFx6nf0sjZTj8Jo6HP/Gr4PqrpR/15cPJEExdAkcyXkYTXyI7yVOfK68iO81WKovMiH5sM4887cHqTvs/YNf2RijLhygB9BAXd7vW7mgFHVBdbQdm4GuxoS0kEg4oO/gNKThEYvbc1EK/q9EHgK25nX7pHRUSx7Eo5YrMQFaOSPdWpX+0Y5hlczuny4y6PAF6+5GYQuGnk7dkAuf/kQXVISVtQTG/Iej3xvQvduMG0Jx/ij+73jFW99A2JpPz/Ek2+RfObXbqM5Ds4TwRW6ujNSQtKZDb8kSxWGtbI6tiF4GdXPI5HjC5Z1pA3dwnbn4ff7Cc/Cc5uICHvF7g7hX+vTjiYAF1XZynUmcdtaBU5U0qbvfKry8u5RUnELQpmDVMXsjSBemk6iigwF9KBgDUWr0w4eOC6VQi8qsmHoC/eEyRy/1DiFuaGwQHzeZLio34apF+r1c8AlntBp2hr83LEl1YD2lo2vowoB3/HvOnvja+ofwo4yKApi+m1QwGGT/aa5mgu10Jv4zZuPjRRDywM1vC8HOKR3N65htIzvGfiRCes0d0wN5yAw8foxMaLlgfDiqH3buIEAvMWizAfIPSA5U+6lyFG9Q1qdWmTNvl/weYUy5MQSuzGPsdT5aoWXkDzj9skR8deedK7C9wxT6J+J9h7QkA3seTJax0zeFtTCrTgCdppznwLZ+nmfMvHR/vb04482UFfUzJGM3pusfcKBchzA+o9wL4LNGqkqNbvvO313aUsnGAw42ce5I8BrIgErKgpOpO6bgkLBfiZbw7zCaupQW1ZJ895r64kaMBmx5bSiuQV0jDeV5 bD7rDqJ2 DzkfqjGpt6F5su3JV6O+EevaeA1kcyK/1s/7khDh3nx4amG+NbhjJUrorhBvtOGnC2i5SipptLkmmsVJv+vmytk2eHTjSQ+Evx24i9HQh+x8AQAezRJtwr7d4uDbtJLpmx6DXm4UQFmUBtezJ49ArNMQBFiP4BbYkQASRqkCpASi/vg7CsUGZj15kK8jYMbZOInF8BvNjGtLcBXciWh3AP2LthsP1hgQ9TLVVMgqgcaxKWt85+FaISBIXKnJJ3Wuasm+HNkLoaHpPeWtKLe9ko6fsjVaInsz/vGJj+F/8g6TLzJ0Gvp9x0K/3gHHv2AHdNTkd49fVB3x0CkuOH3wzv76i6UbkCdW9osVs5yqgIOP1O5jgH+SRV0CmDfL9JBlMfTUj1N8E7yFAZgsFbM2ag6uIrMT2C6iehk1Grfnf6D77kOHZiYxVByX3m8AeHoSOq605 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.25 19:19, Mark Brown wrote: > On Thu, Jun 05, 2025 at 06:55:53PM +0200, David Hildenbrand wrote: >> On 05.06.25 18:42, Mark Brown wrote: > >>> I can't remember off hand, sorry. > >> I assume in ... my review to patch #4? > > Oh, yeah - it's there. I did look there but the "not a fan" bit made me > think it was one of the stylistic things as I quickly scanned through. > >> What an unpleasant upstream experience. > > TBH this has been a lot better than the more common failure mode with > working on selftests where people just completely ignore or are openly > dismissive about them :/ . Probably room for a middle ground though. Can we *please* limit such reworks to mechanical changes in the future? It's just absolutely hard to spot these things during review (I did at least on patch #4). And Andrew apparently just merges them -- and I am left with the feeling that we create more mess by "accident". Anyhow, thanks for working on these tests ... -- Cheers, David / dhildenb