From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E674C7115B for ; Mon, 23 Jun 2025 15:27:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E28036B00BB; Mon, 23 Jun 2025 11:27:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8AD76B00C0; Mon, 23 Jun 2025 11:27:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8F7F6B00C1; Mon, 23 Jun 2025 11:27:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A37C46B00BB for ; Mon, 23 Jun 2025 11:27:58 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6B639160789 for ; Mon, 23 Jun 2025 15:27:58 +0000 (UTC) X-FDA: 83587045836.25.27D3FDA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id E11D414000A for ; Mon, 23 Jun 2025 15:27:55 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DXRYLVQI; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750692476; a=rsa-sha256; cv=none; b=TJaQzt3WTMk3eItbUEZZjcibUVq8WonZygckrLpGJBz6Yt7PJsLjTG8uxzdEaFtB+kV8aL ptmMTflITB5/qzuoU1apy47Mgq3ZpM3hr/5OCzI1OOvzo+bkxX+g2syzC5XjeG2DXMBMlT U3Qe0Amf789vBSHYF/W/IlyFyK5LEoc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DXRYLVQI; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750692476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Pxej4Be5/c9j1n89M+jkXuuoHAyPKQExUDiEWr44btc=; b=EeeVDvPVu3KdoGLAH9bLqyJ7ZVGxS+9eJQA6SZynY9FPy3qzyZln8g0dH8M1OaoPz1Pgok /suPRxEy1SfHGOB9gQimxwtI7XWT7rPKI9Bmx9vueRkvu3vJ045VycuuHBAylcXGvbFh4j H6qr/p8XZPqLtQPrlXGCWrjBD/oNEPA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750692475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Pxej4Be5/c9j1n89M+jkXuuoHAyPKQExUDiEWr44btc=; b=DXRYLVQINJDU3k+UbrupIl4lx91A7iJho7DQ/eJmv/b4B902F9Nj0/3NKWuMDE/KRDKP5e Rh8uTMeEyW5dRa5vaJX7mjWwevbyAPGuRF4gur/o0oQhh4ueULxYw+XmlOIRziXxE2fVqE aXR81Y8dYQEVs1pGIO/y1Ra7qX59fHE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-33-L1zs5B66PtCmbkdmR4uavg-1; Mon, 23 Jun 2025 11:27:53 -0400 X-MC-Unique: L1zs5B66PtCmbkdmR4uavg-1 X-Mimecast-MFC-AGG-ID: L1zs5B66PtCmbkdmR4uavg_1750692473 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45311704d1fso27672415e9.1 for ; Mon, 23 Jun 2025 08:27:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750692473; x=1751297273; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Pxej4Be5/c9j1n89M+jkXuuoHAyPKQExUDiEWr44btc=; b=Z6XnIiIyuidovunJVA53ZteinjnA8jQvHWufNC27A5zU6hxCa44JWJP96YeagJ8S5e Q8cn2bvB1L2cN2BrtHckxmkeMQfkIo0WJ2SdBEMYo7w2Jrt3dBu9mCqscUSzT7VR//m9 cu7P8nl4XBZFiIXNCoSorUrj5CIvEboQSrJCjGnE1ZxZAutSP8nrRbHCz4dhxMqpI6LJ wukPyld2RM2SPgTIon/aRR/S4JnDVeBIwEWao5OKV87djkrq2L0qiU24Dhwg0B675TTn YitjqSf3fM1kMY0QEPwmGxHABUT2GXnmJIjSFNaVEreTCozn177roPO09p8SuKZa/QH1 uaUw== X-Forwarded-Encrypted: i=1; AJvYcCXun6k1r+QUx51EwHHwNVt24pEM/XwJDOLrFNQxGBOXkxj04wHqn0c/LB/MRVDjQiOHzc2jH3ALaA==@kvack.org X-Gm-Message-State: AOJu0YzFkxD24pQ5pIXsZg5/6CU03uoEni+TEL6jLj9+os3zkwmTqdkl shV0KnMguZtnKUve8L7v6Z7DTWRPkIOTjENmJ/t3M7QY9I8pmSlOWYOStvHDn6U/q9ejWY2hmIQ QkDEqeqonroNCEuJOSTfdeF7VPo+Tycdn7WeolK01SqCt5bx+DuUL X-Gm-Gg: ASbGnctTzrejkjE0fpgLJZkgiypb87grbk6jOoTW5a+K5ArOSalU5GaHxlH8tCURSXh pCMaxjqmdnZszYVvlNa67gTRtwATFcNYO44ryftF2+6sg+5uIG1/2W+EgHIVtNSZPoSaXzP+4QG v7N64lcV/r0+KNDSJ/Khty6IvxSn3KcVxIh4FvkvHdPu3kfk+fpiZYKzhZmRSGG5QvgGifc0REm CKV0plje8n2/5bw+ijhWqMCp9bwOqs8eipzctt55KfNhoKQsAcEHG0DbXjZSpBDITmPSOnN2dJk 5bTKuOxTgltA68GVzFGMgvaRvMTARakI644l8jS+hZiiyCefF2BqaNjbtg0VC+ADr7dIbea38PQ t3oFsPbPayy1YaBtdcsBQV+SRMOyhsEoo6AQfI6ZOzEteEIxPwg== X-Received: by 2002:a05:6000:480f:b0:3a4:da87:3a73 with SMTP id ffacd0b85a97d-3a6d12dee06mr8313662f8f.42.1750692472668; Mon, 23 Jun 2025 08:27:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdT39TbThk3Qh/5ilj30MJfKQ2I2zikQzZNduY5teMOhv+k+uk/nLRmFEoy8dlARo9Q3L/mw== X-Received: by 2002:a05:6000:480f:b0:3a4:da87:3a73 with SMTP id ffacd0b85a97d-3a6d12dee06mr8313543f8f.42.1750692470720; Mon, 23 Jun 2025 08:27:50 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159? (p200300d82f4efd008e13e3b590c81159.dip0.t-ipconnect.de. [2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453646cb5ecsm117373425e9.8.2025.06.23.08.27.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 08:27:49 -0700 (PDT) Message-ID: Date: Mon, 23 Jun 2025 17:27:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 04/29] mm/page_alloc: allow for making page types sticky until freed To: Zi Yan Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250618174014.1168640-1-david@redhat.com> <20250618174014.1168640-5-david@redhat.com> <6E57AE2C-7754-4269-B16A-A39D168C5285@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <6E57AE2C-7754-4269-B16A-A39D168C5285@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: LEZuBTl2Getgu7aaZOZEElerxRlmwoBHA5NvxC--ksU_1750692473 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: impuuyqiitstq8ud1exskqgbmw6z1ma5 X-Rspamd-Queue-Id: E11D414000A X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1750692475-858596 X-HE-Meta: U2FsdGVkX1+CgN2hQwp8Ge/NuKuj9pTBplODYhMwm60XWkuw7J9AbNQTpSd/c/jiCC8tifkLhRdvK7RiLE52x+L04VOmT3elAF1YVd8h2JSUVsD0sCqmoH0GyD7G9/wDGZTczf5Wbs61p6Ckcf7CMgN8m/rvXj4xP+HyVnH5051SqHm53lgZTL0rwaUIr5FtOqISloriRHT/uSsGKcoPydSIu52r9flLUK/Tm71HJYBuWUe058Iw76gjnlYD1XZUA3Od18vTknJm2sJ7GmZ6qCRFQXU8hIo4kVaBgvACsfDcQ8N3pcE7G704mePdTbF2fteyUrDlEgmKii5neWisrRbpDb60rTUoaxrCY5UVHn/YpfAdp3a677ubnNRmy8xNxGWUat8hpJ/Qcvle21zyRbDEg2bCKakeMBIcArxVRy8eHIP4x4AP3vEa+KOOOVzm2HATQ1y7u5JBHQoxUdbgHIjrn6f3JvkwZT//5NCVG452dYiftL913dgtFlLQBNnW96ENrKnjAZnQievcxX2VqVdI8E61zYE+aFI9tI0vquhXV71gWxvoU28g7gNl+fp3ZQT2xYZUS3PeGRcXyOAKM8NSEqMKtUgHo80R6H6BaH3TsC5Q655VklMlfQQDLMlbY2SB0ci9XwNiex1opRx51RtZc1rZMPKLMYjuYfoO6vTrshdW5vPlciew3uGMwa9CPK35LGgc3QWkI+bWRH/VWddloO0LFym9SXySk610ESNQVL4UlL6F/7bfpGohOikP99EoQ5DqI7/tILjrUazHL4Z1UiJNJCM8ot/mPH8qL4pwvxzXbu4T/GvG4dDK7QCOuWwwK+a6ldBC2zKvea1UBD/H4ENFXZlhWtPtWSNjdwZLPUcZDmR/ExV0Z6G6UUXLOc95/oMu5asUUuUI6ZK6bRCivA7Q0NbxpeAlWvPK+NdHWpnMzbl6VxTQ34pkuNCQUVZopckb6y/geL23p5o w8o2GaKL rYkWFop+N7g3NFL+WOdhlsV06mLFG4oR/ZL1SbwtC3pf/I1dmc3ANvlU7lTHtVZO9vu1cx+Lnq8OnbB4CLYS2Cct63rNhOilz8uFx1pwdZ1tNq5GviGL/RJXu52q/Or/1rp9WDKaT8j3S1WHbDoQvetLcoe0dnO86uZVEDbt0/LX5urC2V2r6mChw4Q5Tfx6FimF2TzZMMGwwQozhTIDQ/MATDajYpngQFXyqth5J8movso+96dy3UstpWgBdoXbFqaeJge6bcb+ypJMF5Y2erVKN1RWI7dt8DGAiMia+GA1mc4fP/5BqZ07ArhJLyGtewPopEXDTuKqXvPYLUwGXX1+XIMow9drNwczOon5Fx6qzeqGPT0J+aztojNDNK3nAv/3R+Y5P+X3X0O5Ff/cXvEVY/nD4yOeBqqyHqtZGqsEVq3Yu/C8/41lTrpw2Irm+dayTcUE17j4B2VjNqbO6Lmko5YjMvqhk/mnM4vE35dTB69mUVhDbluOyGRjAMcGnEoDDTqYO8FwFOHXTRtgdmhnlYmuvC/v86fmn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.06.25 20:43, Zi Yan wrote: > On 18 Jun 2025, at 13:39, David Hildenbrand wrote: > >> Let's allow for not clearing a page type before freeing a page to the >> buddy. >> >> We'll focus on having a type set on the first page of a larger >> allocation only. >> >> With this change, we can reliably identify typed folios even though >> they might be in the process of getting freed, which will come in handy >> in migration code (at least in the transition phase). >> >> Signed-off-by: David Hildenbrand >> --- >> mm/page_alloc.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index 858bc17653af9..44e56d31cfeb1 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -1380,6 +1380,9 @@ __always_inline bool free_pages_prepare(struct page *page, >> mod_mthp_stat(order, MTHP_STAT_NR_ANON, -1); >> page->mapping = NULL; >> } >> + if (unlikely(page_has_type(page))) >> + page->page_type = UINT_MAX; >> + >> if (is_check_pages_enabled()) { >> if (free_page_is_bad(page)) >> bad++; > > Should we be pedantic to only do this for PageOffline and PageZsmalloc > and warn for the rest page types? I think we should just allow any page types. Limiting it to specific types sounds like some use-after-free check that probably shouldn't be handled that way. -- Cheers, David / dhildenb