From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CDBCC636CC for ; Tue, 7 Feb 2023 04:46:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEB806B0078; Mon, 6 Feb 2023 23:46:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E99A96B007B; Mon, 6 Feb 2023 23:46:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3A816B007D; Mon, 6 Feb 2023 23:46:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BF9C66B0078 for ; Mon, 6 Feb 2023 23:46:34 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8F4CC80B48 for ; Tue, 7 Feb 2023 04:46:34 +0000 (UTC) X-FDA: 80439259908.30.AA1B723 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf12.hostedemail.com (Postfix) with ESMTP id 5A52B4000E for ; Tue, 7 Feb 2023 04:46:31 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=HotiWq+S; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf12.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675745191; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t2JrZkTNoAC8sbAtJTUTJzdMO13KhFylQrwKNlTmAko=; b=kJ1WaFwj7p37EKRTtc9F6a1ZGXmdCGfHQmUMuTGJrnIb941h2ztb72sOTxzgX+3CL9/84u vbwPWfQcMpbgmaXqTTdjFxY1///PxP5PhZwLk0RM1Pazd6u7eu2CWVLWG/nBkyTxJUOgit Q25w5VEjnPB2f6+DNJUbLGLJ8VedwJE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=HotiWq+S; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf12.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675745191; a=rsa-sha256; cv=none; b=dapbbSE+t+ahIjei/bXBCCJ95Qn9GYgVH2ePObEaGv8XGPIfogAfXT8Yf4dvd2GOrHBkMs m5qZ4RgZr0y3YFd3aTtb5/Fd7srgLmEeJyMVLHbuHoCy1geUElb1F2Znaq0Dngx4XQKN2x ZW9OH9Ge+l9Rhx3sV/FXKQKprMzO1AI= Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3174I9F3005921; Tue, 7 Feb 2023 04:46:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=t2JrZkTNoAC8sbAtJTUTJzdMO13KhFylQrwKNlTmAko=; b=HotiWq+SJ017YTwqEpawdceyXcbrMVYiLdYfsz+Iya/QfkzIlH711js9WR2kjFIywbft dOZdUpNKOgI5xeBYHG+LTnKJbnf4L7vEFPahLD9FksJ22LdhoJRYbgcvI4QNSMPlc2Ad IpcpCL8G2GErVGpYGeRBYEKZE7dfUMMCyrtHzg6+wH0K4GHp2rWOIfkP9ZY8MDO42Yk3 mbA3cuKjZGPUXroOy7us4FhhVxl+/0pZX4jxiIEI41W59n9dqxrfOEk+C6vzZgfm2QDS zZb6/L/GeMQBAhgI8JcOdyxCZUbvIX8Lj17GsRtn4WvOg46XMGUwdM3/y9ZF+srcY06g WA== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3nhg4rn9da-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Feb 2023 04:46:26 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3174kP7G005455 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 7 Feb 2023 04:46:25 GMT Received: from [10.214.66.119] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 6 Feb 2023 20:46:20 -0800 Message-ID: Date: Tue, 7 Feb 2023 10:16:17 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH V6 2/2] mm: shmem: implement POSIX_FADV_[WILL|DONT]NEED for shmem Content-Language: en-US To: Matthew Wilcox CC: , , , , , , , , , , References: <08e04b5d2fc7a2300a52fb7fff1bc6316a53927c.1675690847.git.quic_charante@quicinc.com> From: Charan Teja Kalla In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: ZsyuDWR9Bj0yOxs_vT2QecngFL2eBepa X-Proofpoint-GUID: ZsyuDWR9Bj0yOxs_vT2QecngFL2eBepa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-02-06_07,2023-02-06_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 mlxscore=0 impostorscore=0 phishscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 adultscore=0 bulkscore=0 spamscore=0 mlxlogscore=687 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302070041 X-Rspamd-Queue-Id: 5A52B4000E X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: bzkoyxs9szngdizu65n1hoeejrrxnpye X-HE-Tag: 1675745191-69834 X-HE-Meta: U2FsdGVkX18+K90acf/noiXf64RvbE6K9us5zJoaWCVAwox7Mhj7vGz0BfmZom/fq9ptv5xpmk5eIUBJe0+w2WHlgQt9Lwv+6gUB5ZzC+snkaKBIAxrwRTSaxEDI7i/7y5LsxKzI2CMNV9yRLNBBIIWa8HRVwYKLpNtaLbXQb15oZyTKBYhBbw4Cb7z1KqH6xGeCkqETdjimPlNbKhT6/SNPG9WBQW3UKpEVE/yBMQxnqZjeB48e2kUCXDaDLekQnVGlyncdaHm9Id0YAUxVIEL+6cpp54tp68pg2hRqNkse0EynJv++xhwb7M3NLrRqn+w5VIakGLjWt/C++Bu6ZfuuBht7zR+AT1Mrtc3R+bQyISnoVxMAV+LkUfdVcwSsq3ZWQ5ZCMI9OLntYFW0uNKsFgpNfUAQ7myJBiLoo5yzMJ3ix7zrGBOllssoQx93Dad1sazffzgXqE+2FOHumE6t6ZwHK7buFFaf7eh/llbyCbcft048PzrpNOWO5ln14Qae+Rb2k752dNpDX88TCNOxPn9i80iu3ka2tMLq2xrxKCn6SSr7CCDfEYLQ+zHJmkzatm4Xy2OO2CsZkwJ5EEKFN7qYq6tSLa9P/7b3jmvInyK9fOhYHug4ATWSx7Elpp3YS6HlSDVbhEv8Ml2OGPFCxk/jULcw1DK+RnOVACueryZp1G4eE+aVpK/EwwNO+AD0AJo5VcvMOyqpqKLgOEDiWuK7ZTepKRP1ob/14Z2I/ryPr+24D5w1uaBP5nqSRJ/VdRO7sT729ta/7Y0SMYZti62fh9vLgQll2p7Ik3rmA3drlyv9Y0ZX6wvIr/v5W7mJQWwt2YNYOOjOlrWpMOPL4qxITc8C8J8NnpCXeu3eoyuAos1jKIR/PA6eYRAyzq1mqAEL6pPMkIOskZr4iqn0KwzZpADcWEmDDIq3T4OC3ad65ekEejZvSuTCOxfs0ynB16UQivjopOcy3wgb 4yBSgYwR SsccBbjXSE7/4Dr/kmMVIE+CZzNj7UryhRurUKITFhLJTOJpHbKRp02bb6rU3QMYnw9yJ8d14oyo8irJQ0iVsfDL96g7WkALx2Js/FA8YzlGSGPuheAHKI89QQmvta4lfqYr8Mr7GtTIh9PbV5Ti9CLjSLCTZ0eNQ83SwiiPLLHzzeBCnNm8D8qGNiNioSks5ZMLxQ8ulsBxL/rbJel6c8HJSOqLmHrmsZYo/Ukyt+SxuEltirgbS7WSftVDH3xfSIGOVjXXRzxmpbXA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks Matthew!! On 2/6/2023 9:48 PM, Matthew Wilcox wrote: >> +static int shmem_fadvise_willneed(struct address_space *mapping, >> + pgoff_t start, pgoff_t long end) >> +{ >> + struct page *page; >> + pgoff_t index; >> + >> + xa_for_each_range(&mapping->i_pages, index, page, start, end) { >> + if (!xa_is_value(page)) >> + continue; >> + page = shmem_read_mapping_page(mapping, index); >> + if (!IS_ERR(page)) >> + put_page(page); >> + } >> + >> + return 0; >> +} > Hm, that's a gap in the shmem folio API. Patches imminent. I will change this piece of code to folios based on your recent set of patches. Will wait for more reviews before update. Thanks, Charan